summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamuel Mannehed <samuel@cendio.se>2016-11-28 10:02:13 +0100
committerSamuel Mannehed <samuel@cendio.se>2016-11-28 10:02:13 +0100
commit38d8cfdf835a297515aa4e2a19f11cb730018c55 (patch)
tree120056697c977e1f5b04274b9654cc72d1579bb1
parent38f3d92c5e654e7e334db4c85411a06dbb08dbba (diff)
downloadnovnc-38d8cfdf835a297515aa4e2a19f11cb730018c55.tar.gz
Fix fallback error handling
Start using the correct API for window.addEventListener('error',..). Unlike when using onerror, the handler function gets an event.
-rw-r--r--app/ui.js8
1 files changed, 6 insertions, 2 deletions
diff --git a/app/ui.js b/app/ui.js
index 4bd5f0f..9d0a3ba 100644
--- a/app/ui.js
+++ b/app/ui.js
@@ -26,12 +26,16 @@ var UI;
"use strict";
// Fallback for all uncought errors
- window.addEventListener('error', function(msg, url, line) {
+ window.addEventListener('error', function(e) {
try {
+ var file = e.filename;
+ var line = e.lineno;
+ var col = e.colno;
+ var msg = e.error.message;
document.getElementById('noVNC_fallback_error')
.classList.add("noVNC_open");
document.getElementById('noVNC_fallback_errormsg').innerHTML =
- url + ' (' + line + ') <br><br>' + msg;
+ msg + '<br><br>' + 'at: ' + file + ':' + line + ':' + col;
} catch (exc) {
document.write("noVNC encountered an error.");
}