summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Don't crash if we can't use localStoragelocalStorageSamuel Mannehed2022-11-021-6/+26
| | | | | | | | | Our settings are not a fatal requirement, we can fall back on the default values if they can't be accessed. A scenario where we've seen this happen is when cookies are disabled in the browser. It seems localStorage is disabled along with cookies in these settings. Fixes issue #1577.
* Ensure the correct cursor on disabled buttonsSamuel Mannehed2022-10-311-0/+3
| | | | | | | | Without this fix we still get a "pointer" cursor on disabled inputs of type "image" in Firefox. Currently, all our noVNC_buttons are <input type="image">. Reported to firefox here: https://bugzilla.mozilla.org/show_bug.cgi?id=1798304
* Remove unnecessary legacy CSS propertiesSamuel Mannehed2022-10-311-12/+2
| | | | | | We depend un such modern things anyway, having these kinds of properties are more confusing than helpful. Let's not give the impression that we make any attempt to work in old browsers.
* Change default dimensions of clipboard textareaSamuel Mannehed2022-10-281-1/+2
| | | | | Make it slightly taller and not as wide, this makes it stand out less compared to the other panels.
* Limit webaccess clipboard textarea min widthSamuel Mannehed2022-10-281-0/+1
| | | | | | The clipboard textarea could potentially shrink further than what was possible for the header text elements, which looked a bit broken. In that regard, a min width is introduced for the textarea.
* Don't let the clipboard textarea grow too highSamuel Mannehed2022-10-281-0/+2
| | | | | There are scrollbars inside the textarea in case there's a lot of text in there. We can limit the height of the element, it looks better.
* Fix max-width of clipboard textareaSamuel Mannehed2022-10-281-0/+2
| | | | | It should not be able to "eat" its parent-panel's padding. By setting box-sizing: border-box we can prevent this.
* Use border-box for noVNC panelsSamuel Mannehed2022-10-281-1/+2
| | | | | If we use box-sizing: border-box we can avoid having to account for the padding when calculcating the max-width.
* Set max-width on all noVNC panelsSamuel Mannehed2022-10-281-4/+1
| | | | | | | All panels should be limited in this way, not just the clipboard panel. One additional upside of this is that the numbers used to calculate the max-width are closer by, in the code. This hopefully makes it easier to avoid mistakes in the future.
* Merge branch 'latin1' of https://github.com/CendioOssman/noVNCPierre Ossman2022-10-273-12/+40
|\
| * Correctly mask non-BMP clipboard charactersPierre Ossman2022-10-272-4/+23
| | | | | | | | | | | | JavaScript strings use UTF-16 encoding under the hood, but we only want a single '?' per character we replace. So we need to be more careful which methods we use when iterating over the clipboard string.
| * Mask unsupported clipboard charactersPierre Ossman2022-10-272-2/+16
| | | | | | | | | | Add a more explicit '?' for characters that the clipboard cannot handle, instead of getting random junk.
| * Remove redundant inspect() overridePierre Ossman2022-10-271-6/+0
| | | | | | | | We do this for all RFB tests now, not just these specific assertions.
| * Restore Websock.allocateBuffers() after testsPierre Ossman2022-10-271-0/+1
| | | | | | | | This was accidentally removed in 0a6aec3578.
| * Update method to limit assertion outputPierre Ossman2022-10-271-2/+2
|/ | | | | Newer versions of the test framework use the inspect() method instead of toString() for overriding the default output.
* Move control bar hint outside of the control barSamuel Mannehed2022-10-242-9/+14
| | | | | | Makes it a more independent element responsible for it's own positioning and vertical centering. This makes the hint easier to adapt for external CSS styles and makes it possible to remote the fixed size if needed.
* Only show the control bar hint once per "move"Samuel Mannehed2022-10-242-1/+14
| | | | | | | | | | | | After the user has "followed" the hint by dragging the handle to the other side, the control bar will switch to that side. Once this has happened, we will now hide the hint until the user starts over by dragging the handle again. This change was added to make the hint feel more like a "hint" and less like a permanent GUI element. It isn't as persistent and intrusive now. Note that we don't want the act of hiding the hint to result in a transition animation here.
* Merge branch 'fix-1695' of https://github.com/m1k1o/noVNCPierre Ossman2022-10-192-0/+71
|\
| * auto release keys while meta is held down.Miroslav Šedivý2022-10-152-0/+71
| |
* | Match touch area height with height of handleSamuel Mannehed2022-10-141-1/+1
| | | | | | | | | | Instead of hard coding the height of this touch area we can just use its parent's height.
* | Move <input> and <button> styles to its own fileSamuel Mannehed2022-10-143-148/+150
| | | | | | | | | | | | This makes it easier for integrators of vnc.html to write their own input and button styles. It's also positive to cut a bit off from the size of the large base.css.
* | Clean up control bar padding/marginsPierre Ossman2022-10-132-14/+25
| | | | | | | | | | Try to make it a bit less messy by trying to get more general rules in place.
* | Use latest GitHub actionsPierre Ossman2022-10-133-11/+11
| | | | | | | | The older ones are getting deprecated, so make the switch.
* | Style <button> the same as <input type="button">Samuel Mannehed2022-10-131-2/+9
| | | | | | | | | | These styles are meant to be complete, that we didn't have a style for <button> was a mistake.
* | Rename CSS section to better reflect contentsSamuel Mannehed2022-10-121-1/+1
| | | | | | | | These buttons only exist in the control bar.
* | Make error handler's focus changes best-effortSamuel Mannehed2022-10-121-1/+8
| | | | | | | | | | | | | | | | | | | | When the error handler itself causes an exception, it falls back to a simple document.write(). This means the proper error dialog isn't shown when this happens. The focus changes that were added to the error handler in e1f8232b are not crucial for its function. If these focus changes causes an exception we can just ignore that.
* | Check if activeElement exists before using itSamuel Mannehed2022-10-121-1/+1
| | | | | | | | | | According to MDN, document.activeElement can be null if there is no focused element.
* | Respect font settings on input elementsPierre Ossman2022-10-111-0/+5
| | | | | | | | | | The browsers override these instead of using the normal inheritance. So make sure our global font settings are respected.
* | Add more air to settings panelPierre Ossman2022-10-111-1/+6
| | | | | | | | | | We want some space between elements to avoid things getting cramped, so add some minimal margins.
* | Increase input element paddingPierre Ossman2022-10-111-2/+2
| | | | | | | | The text gets a bit cramped otherwise. Extra so at larger font sizes.
* | Stop setting margin on input elementsPierre Ossman2022-10-111-3/+1
| | | | | | | | | | Margins behave badly on inline elements, so let's try to avoid using them. Margins should be handled by the block elements anyway.
* | Handle crash dialog overflow betterPierre Ossman2022-10-111-2/+4
| | | | | | | | | | Avoid making assumptions on how much space is available for the stack dump, and instead handle the overflow on the top element.
* | Fix typo in fallback_error CSS commentSamuel Mannehed2022-10-071-1/+1
| | | | | | | | Typo from commit e1f8232bc90c77e5746f6f8356613962021cc862
* | Block user interaction when fallback error showsSamuel Mannehed2022-10-072-0/+14
| | | | | | | | | | | | | | When this error is shown, something has gone very wrong. It shows when a bug in the JavaScript causes an uncaught error. In these scenarios we dont want the user to be able to interact with the GUI or the remote session, since we can't guarantee that things work.
* | Don't react to interactions with disabled buttonsSamuel Mannehed2022-10-041-5/+5
|/ | | | | Disabled buttons should not change appearance on mouse hover, click or on keyboard focus. Doing so destroys the "disabled" impression.
* Don't use explicitly HelveticaPierre Ossman2022-09-231-1/+1
| | | | | On many systems you get a poor substitute, so let's instead instruct the browser that we merely want a sans serif font for our interface.
* Set font family on root elementPierre Ossman2022-09-231-1/+4
| | | | | This is a very global setting, so let's put it on the top node for clarity.
* Avoid using translate() for positioningPierre Ossman2022-09-161-3/+3
| | | | It often results in a blurry result on WebKit based browsers.
* Document state classes uses in CSSPierre Ossman2022-09-151-0/+12
| | | | Makes it a bit easier to understand all the magic in this CSS.
* Merge branch 'italian' of https://github.com/M2Rbiz/noVNCPierre Ossman2022-09-144-2/+374
|\
| * Add italian translationFabio Fantoni2022-09-084-2/+374
| |
* | Use automatic version when building snap directlyPierre Ossman2022-09-142-2/+2
| | | | | | | | | | Make it easier to build a snap from your working copy by removing the restriction of having to modify the version field first.
* | Remove unnecessary clipboard clear buttonSamuel Mannehed2022-09-092-10/+0
|/ | | | | | This button fills no real purpose. It's easy to mark everything and delete with either "Ctrl + A -> Delete" or, on touch devices, "long press -> mark everything -> Delete".
* access to raw image dataFrederik Fix2022-09-073-0/+85
|
* add support for for enabling authenticationnickcFRU2022-08-231-1/+14
|
* Merge branch 'patch-1' of https://github.com/VibroAxe/noVNCPierre Ossman2022-08-191-1/+3
|\
| * Allow continued reconnect triesJames Kinsman2022-08-081-1/+3
| | | | | | Currently novnc will only retry once (assuming the server is unavailable) and then stop (as the detail from is unclean, usually "failed to connect"). Minor change will continue to reconnect every reconnect_delay seconds until either reconnected or user intervention cancels the attempt.
* | Merge branch 'authprio' of https://github.com/CendioOssman/noVNCPierre Ossman2022-08-192-194/+260
|\ \ | |/ |/|
| * VeNCrypt should handle classical typesPierre Ossman2022-08-182-36/+109
| | | | | | | | | | VeNCrypt is a superset of the original security types, so it should be fine to send any of the classical values here as well.
| * Prefer security types in the server's orderPierre Ossman2022-08-182-27/+29
| | | | | | | | | | This is how TigerVNC has been behaving for years and has worked well there, so let's follow them.
View Lorry Controller Status