clarify uses of createTester

10 files changed, 7 insertions, 22 deletions

diff --git a/lib/detect.js b/lib/detect.js
index c37ff91..1ea4eb4 100644
--- a/lib/detect.js
+++ b/lib/detect.js
@@ -1,7 +1,5 @@
-import identity from './internal/identity';
 import createTester from './internal/createTester';
 import doParallel from './internal/doParallel';
-import findGetResult from './internal/findGetResult';
 
 /**
  * Returns the first value in `coll` that passes an async truth test. The
@@ -38,4 +36,4 @@ import findGetResult from './internal/findGetResult';
  *     // result now equals the first file in the list that exists
  * });
  */
-export default doParallel(createTester(identity, findGetResult));
+export default doParallel(createTester(bool => bool, (res, item) => item));
diff --git a/lib/detectLimit.js b/lib/detectLimit.js
index 4efdd3a..e9ff158 100644
--- a/lib/detectLimit.js
+++ b/lib/detectLimit.js
@@ -1,7 +1,5 @@
-import identity from './internal/identity';
 import createTester from './internal/createTester';
 import doParallelLimit from './internal/doParallelLimit';
-import findGetResult from './internal/findGetResult';
 
 /**
  * The same as [`detect`]{@link module:Collections.detect} but runs a maximum of `limit` async operations at a
@@ -25,4 +23,4 @@ import findGetResult from './internal/findGetResult';
  * (iteratee) or the value `undefined` if none passed. Invoked with
  * (err, result).
  */
-export default doParallelLimit(createTester(identity, findGetResult));
+export default doParallelLimit(createTester(bool => bool, (res, item) => item));
diff --git a/lib/every.js b/lib/every.js
index eb10748..ed00f72 100644
--- a/lib/every.js
+++ b/lib/every.js
@@ -1,6 +1,5 @@
 import createTester from './internal/createTester';
 import doParallel from './internal/doParallel';
-import notId from './internal/notId';
 
 /**
  * Returns `true` if every element in `coll` satisfies an async test. If any
@@ -30,4 +29,4 @@ import notId from './internal/notId';
  *     // if result is true then every file exists
  * });
  */
-export default doParallel(createTester(notId, notId));
+export default doParallel(createTester(bool => !bool, res => !res));
diff --git a/lib/everyLimit.js b/lib/everyLimit.js
index 89a69fc..536229a 100644
--- a/lib/everyLimit.js
+++ b/lib/everyLimit.js
@@ -1,6 +1,5 @@
 import createTester from './internal/createTester';
 import doParallelLimit from './internal/doParallelLimit';
-import notId from './internal/notId';
 
 /**
  * The same as [`every`]{@link module:Collections.every} but runs a maximum of `limit` async operations at a time.
@@ -22,4 +21,4 @@ import notId from './internal/notId';
  * `iteratee` functions have finished. Result will be either `true` or `false`
  * depending on the values of the async tests. Invoked with (err, result).
  */
-export default doParallelLimit(createTester(notId, notId));
+export default doParallelLimit(createTester(bool => !bool, res => !res));
diff --git a/lib/internal/findGetResult.js b/lib/internal/findGetResult.js
deleted file mode 100644
index d1462f4..0000000
--- a/lib/internal/findGetResult.js
+++ /dev/null
@@ -1 +0,0 @@
-export default (v, x) => x;
diff --git a/lib/internal/identity.js b/lib/internal/identity.js
deleted file mode 100644
index b25a2d4..0000000
--- a/lib/internal/identity.js
+++ /dev/null
@@ -1 +0,0 @@
-export default value => value
diff --git a/lib/internal/notId.js b/lib/internal/notId.js
deleted file mode 100644
index 65a676e..0000000
--- a/lib/internal/notId.js
+++ /dev/null
@@ -1,3 +0,0 @@
-export default function notId(v) {
-    return !v;
-}
diff --git a/lib/memoize.js b/lib/memoize.js
index 84526c3..7c82cf9 100644
--- a/lib/memoize.js
+++ b/lib/memoize.js
@@ -1,4 +1,3 @@
-import identity from './internal/identity';
 import setImmediate from './internal/setImmediate';
 import initialParams from './internal/initialParams';
 import wrapAsync from './internal/wrapAsync';
@@ -47,10 +46,9 @@ function has(obj, key) {
  *     // callback
  * });
  */
-export default function memoize(fn, hasher) {
+export default function memoize(fn, hasher = v => v) {
     var memo = Object.create(null);
     var queues = Object.create(null);
-    hasher = hasher || identity;
     var _fn = wrapAsync(fn);
     var memoized = initialParams(function memoized(args, callback) {
         var key = hasher.apply(null, args);
diff --git a/lib/some.js b/lib/some.js
index d574d02..d0d9d9e 100644
--- a/lib/some.js
+++ b/lib/some.js
@@ -1,6 +1,5 @@
 import createTester from './internal/createTester';
 import doParallel from './internal/doParallel';
-import identity from './internal/identity';
 
 /**
  * Returns `true` if at least one element in the `coll` satisfies an async test.
@@ -32,4 +31,4 @@ import identity from './internal/identity';
  *     // if result is true then at least one of the files exists
  * });
  */
-export default doParallel(createTester(Boolean, identity));
+export default doParallel(createTester(Boolean, res => res));
diff --git a/lib/someLimit.js b/lib/someLimit.js
index f234828..a5906aa 100644
--- a/lib/someLimit.js
+++ b/lib/someLimit.js
@@ -1,6 +1,5 @@
 import createTester from './internal/createTester';
 import doParallelLimit from './internal/doParallelLimit';
-import identity from './internal/identity';
 
 /**
  * The same as [`some`]{@link module:Collections.some} but runs a maximum of `limit` async operations at a time.
@@ -23,4 +22,4 @@ import identity from './internal/identity';
  * Result will be either `true` or `false` depending on the values of the async
  * tests. Invoked with (err, result).
  */
-export default doParallelLimit(createTester(Boolean, identity));
+export default doParallelLimit(createTester(Boolean, res => res));