diff options
author | Alexander Early <alexander.early@gmail.com> | 2017-04-08 21:27:44 -0700 |
---|---|---|
committer | Alexander Early <alexander.early@gmail.com> | 2017-04-08 21:27:44 -0700 |
commit | a21a58298aff375ff40f173faa53da3e7dc1fc29 (patch) | |
tree | c7ce347aa7c04dcbe9ae7d1da9d91774f14365a4 | |
parent | 7c17e23176663a44d36c59e4489803b43ff572d1 (diff) | |
download | async-a21a58298aff375ff40f173faa53da3e7dc1fc29.tar.gz |
tweak retry tests to be more descriptive when they failqueue-tests
-rw-r--r-- | mocha_test/retry.js | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/mocha_test/retry.js b/mocha_test/retry.js index d3a5d22..6185f3c 100644 --- a/mocha_test/retry.js +++ b/mocha_test/retry.js @@ -66,11 +66,10 @@ describe("retry", function () { callCount++; callback(error + callCount, erroredResult + callCount); // respond with indexed values } - var start = new Date().getTime(); + var start = Date.now(); async.retry({ times: times, interval: interval}, fn, function(err, result){ - var now = new Date().getTime(); - var duration = now - start; - assert(duration >= (interval * (times -1)), 'did not include interval'); + var duration = Date.now() - start; + expect(duration).to.be.above(interval * (times - 1) - 1); assert.equal(callCount, 3, "did not retry the correct number of times"); assert.equal(err, error + times, "Incorrect error was returned"); assert.equal(result, erroredResult + times, "Incorrect result was returned"); @@ -88,11 +87,10 @@ describe("retry", function () { callCount++; callback(error + callCount, erroredResult + callCount); // respond with indexed values } - var start = new Date().getTime(); + var start = Date.now(); async.retry({ times: times, interval: intervalFunc}, fn, function(err, result){ - var now = new Date().getTime(); - var duration = now - start; - assert(duration >= 300, 'did not include custom interval'); + var duration = Date.now() - start; + expect(duration).to.be.above(299); assert.equal(callCount, 3, "did not retry the correct number of times"); assert.equal(err, error + times, "Incorrect error was returned"); assert.equal(result, erroredResult + times, "Incorrect result was returned"); @@ -127,7 +125,7 @@ describe("retry", function () { it('retry does not precompute the intervals (#1226)', function(done) { var callTimes = []; function intervalFunc() { - callTimes.push(new Date().getTime()); + callTimes.push(Date.now()); return 100; }; function fn(callback) { @@ -226,11 +224,10 @@ describe("retry", function () { function errorTest(err) { return err && err !== special; } - var start = new Date().getTime(); + var start = Date.now(); async.retry({ interval: interval, errorFilter: errorTest }, fn, function(err, result){ - var now = new Date().getTime(); - var duration = now - start; - assert(duration >= (interval * (specialCount - 1)), 'did not include interval'); + var duration = Date.now() - start; + expect(duration).to.be.above(interval * (specialCount - 1) - 1); assert.equal(callCount, specialCount, "did not retry the correct number of times"); assert.equal(err, special, "Incorrect error was returned"); assert.equal(result, erroredResult + specialCount, "Incorrect result was returned"); |