Short circuit loops completely for some,every,detect when ready [fixes #1293]

2 files changed, 54 insertions, 1 deletions

diff --git a/mocha_test/detect.js b/mocha_test/detect.js
index f308485..b1ebf24 100644
--- a/mocha_test/detect.js
+++ b/mocha_test/detect.js
@@ -1,5 +1,6 @@
 var async = require('../lib');
 var expect = require('chai').expect;
+var _ = require('lodash');
 
 describe("detect", function () {
 
@@ -134,6 +135,31 @@ describe("detect", function () {
         });
     });
 
+    it('detectSeries doesn\'t cause stack overflow (#1293)', function(done) {
+        var arr = _.range(10000);
+        let calls = 0;
+        async.detectSeries(arr, function(data, cb) {
+            calls += 1;
+            async.setImmediate(_.partial(cb, null, true));
+        }, function(err) {
+            expect(err).to.equal(null);
+            expect(calls).to.equal(1);
+            done();
+        });
+    });
+
+    it('detectLimit doesn\'t cause stack overflow (#1293)', function(done) {
+        var arr = _.range(10000);
+        let calls = 0;
+        async.detectLimit(arr, 100, function(data, cb) {
+            calls += 1;
+            async.setImmediate(_.partial(cb, null, true));
+        }, function(err) {
+            expect(err).to.equal(null);
+            expect(calls).to.equal(100);
+            done();
+        });
+    });
 
     it('find alias', function(){
         expect(async.find).to.equal(async.detect);
diff --git a/mocha_test/some.js b/mocha_test/some.js
index 0a5a8da..989fecb 100644
--- a/mocha_test/some.js
+++ b/mocha_test/some.js
@@ -1,5 +1,6 @@
 var async = require('../lib');
 var expect = require('chai').expect;
+var _ = require('lodash');
 
 describe("some", function () {
 
@@ -83,7 +84,6 @@ describe("some", function () {
         });
     });
 
-
     it('someLimit short-circuit', function(done){
         var calls = 0;
         async.someLimit([3,1,2], 1, function(x, callback){
@@ -97,6 +97,33 @@ describe("some", function () {
         });
     });
 
+
+    it('someSeries doesn\'t cause stack overflow (#1293)', function(done) {
+        var arr = _.range(10000);
+        let calls = 0;
+        async.someSeries(arr, function(data, cb) {
+            calls += 1;
+            async.setImmediate(_.partial(cb, null, true));
+        }, function(err) {
+            expect(err).to.equal(null);
+            expect(calls).to.equal(1);
+            done();
+        });
+    });
+
+    it('someLimit doesn\'t cause stack overflow (#1293)', function(done) {
+        var arr = _.range(10000);
+        let calls = 0;
+        async.someLimit(arr, 100, function(data, cb) {
+            calls += 1;
+            async.setImmediate(_.partial(cb, null, true));
+        }, function(err) {
+            expect(err).to.equal(null);
+            expect(calls).to.equal(100);
+            done();
+        });
+    });
+
     it('any alias', function(){
         expect(async.any).to.equal(async.some);
     });