diff options
55 files changed, 61 insertions, 61 deletions
@@ -34,6 +34,7 @@ "prefer-arrow-callback": 2, "arrow-spacing": 2, "object-shorthand": 2, + "prefer-destructuring": 2, "no-eq-null": 0, "no-unused-expressions": 0, "no-loop-func": 2, diff --git a/lib/auto.js b/lib/auto.js index adfdfa1..b06e3c5 100644 --- a/lib/auto.js +++ b/lib/auto.js @@ -191,7 +191,7 @@ export default function (tasks, concurrency, callback) { return } if (result.length < 2) { - result = result[0]; + [result] = result; } if (err) { var safeResults = {}; diff --git a/lib/eachOf.js b/lib/eachOf.js index 5dbeb81..7d9ebd0 100644 --- a/lib/eachOf.js +++ b/lib/eachOf.js @@ -12,7 +12,7 @@ function eachOfArrayLike(coll, iteratee, callback) { callback = once(callback || noop); var index = 0, completed = 0, - length = coll.length, + {length} = coll, canceled = false; if (length === 0) { callback(null); diff --git a/lib/groupByLimit.js b/lib/groupByLimit.js index aebe088..816bcc6 100644 --- a/lib/groupByLimit.js +++ b/lib/groupByLimit.js @@ -31,12 +31,12 @@ export default function(coll, limit, iteratee, callback) { }, (err, mapResults) => { var result = {}; // from MDN, handle object having an `hasOwnProperty` prop - var hasOwnProperty = Object.prototype.hasOwnProperty; + var {hasOwnProperty} = Object.prototype; for (var i = 0; i < mapResults.length; i++) { if (mapResults[i]) { - var key = mapResults[i].key; - var val = mapResults[i].val; + var {key} = mapResults[i]; + var {val} = mapResults[i]; if (hasOwnProperty.call(result, key)) { result[key].push(val); diff --git a/lib/internal/DoublyLinkedList.js b/lib/internal/DoublyLinkedList.js index 259ac0d..4444bcb 100644 --- a/lib/internal/DoublyLinkedList.js +++ b/lib/internal/DoublyLinkedList.js @@ -73,7 +73,7 @@ export default class DLL { remove (testFn) { var curr = this.head; while(curr) { - var next = curr.next; + var {next} = curr; if (testFn(curr)) { this.removeLink(curr); } diff --git a/lib/internal/parallel.js b/lib/internal/parallel.js index 703947c..8abf0d1 100644 --- a/lib/internal/parallel.js +++ b/lib/internal/parallel.js @@ -9,7 +9,7 @@ export default function _parallel(eachfn, tasks, callback) { eachfn(tasks, (task, key, taskCb) => { wrapAsync(task)((err, ...result) => { if (result.length < 2) { - result = result[0]; + [result] = result; } results[key] = result; taskCb(err); diff --git a/lib/reflect.js b/lib/reflect.js index b1cbdc6..acd3043 100644 --- a/lib/reflect.js +++ b/lib/reflect.js @@ -49,7 +49,7 @@ export default function reflect(fn) { } var value = cbArgs; if (cbArgs.length <= 1) { - value = cbArgs[0] + [value] = cbArgs } reflectCallback(null, { value }); }); diff --git a/lib/tryEach.js b/lib/tryEach.js index e4a5f03..1b40531 100644 --- a/lib/tryEach.js +++ b/lib/tryEach.js @@ -46,7 +46,7 @@ export default function tryEach(tasks, callback) { eachSeries(tasks, (task, taskCb) => { wrapAsync(task)((err, ...args) => { if (args.length < 2) { - result = args[0]; + [result] = args; } else { result = args; } diff --git a/perf/benchmark.js b/perf/benchmark.js index 7f5736c..12f0eac 100755 --- a/perf/benchmark.js +++ b/perf/benchmark.js @@ -2,8 +2,7 @@ var _ = require("lodash"); var Benchmark = require("benchmark"); -var exec = require("child_process").exec; -var execSync = require("child_process").execSync; +var {exec, execSync} = require("child_process"); var fs = require("fs"); var path = require("path"); var mkdirp = require("mkdirp"); diff --git a/support/build.test.js b/support/build.test.js index 178c623..02f11ce 100644 --- a/support/build.test.js +++ b/support/build.test.js @@ -1,10 +1,10 @@ // Smoke test for the CJS build var methods = ["each", "waterfall", "queue", "eachSeries", "forEachOf"]; -var expect = require('chai').expect; -var rollup = require('rollup').rollup; +var {expect} = require('chai'); +var {rollup} = require('rollup'); var rollupPluginNodeResolve = require('rollup-plugin-node-resolve'); var fs = require('fs'); -var exec = require('child_process').exec; +var {exec} = require('child_process'); describe("async main", () => { var async; diff --git a/support/jsdoc/jsdoc-custom.js b/support/jsdoc/jsdoc-custom.js index e8a7454..c861f12 100644 --- a/support/jsdoc/jsdoc-custom.js +++ b/support/jsdoc/jsdoc-custom.js @@ -116,7 +116,7 @@ $(() => { }); function fixOldHash() { - var hash = window.location.hash; + var {hash} = window.location; if (hash) { var hashMatches = hash.match(/^#\.(\w+)$/); if (hashMatches) { diff --git a/test/apply.js b/test/apply.js index 8c32177..0183f50 100644 --- a/test/apply.js +++ b/test/apply.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('concat', () => { it('apply', (done) => { diff --git a/test/applyEach.js b/test/applyEach.js index 96c7a77..ee70305 100644 --- a/test/applyEach.js +++ b/test/applyEach.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('applyEach', () => { diff --git a/test/asyncFunctions.js b/test/asyncFunctions.js index 3b759e1..894b32b 100644 --- a/test/asyncFunctions.js +++ b/test/asyncFunctions.js @@ -1,4 +1,4 @@ -var isAsync = require('../lib/internal/wrapAsync').isAsync; +var {isAsync} = require('../lib/internal/wrapAsync'); function supportsAsync() { var supported; diff --git a/test/asyncify.js b/test/asyncify.js index 14f35ee..225f6d4 100644 --- a/test/asyncify.js +++ b/test/asyncify.js @@ -1,6 +1,6 @@ var async = require('../lib'); var assert = require('assert'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('asyncify', () => { @@ -146,12 +146,12 @@ describe('asyncify', () => { }); describe('es6-promise', function() { - var Promise = require('es6-promise').Promise; + var {Promise} = require('es6-promise'); promisifiedTests.call(this, Promise); }); describe('rsvp', function() { - var Promise = require('rsvp').Promise; + var {Promise} = require('rsvp'); promisifiedTests.call(this, Promise); }); diff --git a/test/auto.js b/test/auto.js index 95aad09..3dc364d 100644 --- a/test/auto.js +++ b/test/auto.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var _ = require('lodash'); describe('auto', () => { diff --git a/test/autoInject.js b/test/autoInject.js index fe98e27..5a35282 100644 --- a/test/autoInject.js +++ b/test/autoInject.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('autoInject', () => { diff --git a/test/cargo.js b/test/cargo.js index ace4c93..fc377fe 100644 --- a/test/cargo.js +++ b/test/cargo.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('cargo', () => { diff --git a/test/compose.js b/test/compose.js index 0517a20..39892c0 100644 --- a/test/compose.js +++ b/test/compose.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('compose', () => { context('all functions succeed', () => { diff --git a/test/concat.js b/test/concat.js index b1384fc..cc97374 100644 --- a/test/concat.js +++ b/test/concat.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('concat', function() { diff --git a/test/consoleFunctions.js b/test/consoleFunctions.js index 7beeb26..c35d419 100644 --- a/test/consoleFunctions.js +++ b/test/consoleFunctions.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('console functions', () => { diff --git a/test/constant.js b/test/constant.js index 342e515..c78681c 100644 --- a/test/constant.js +++ b/test/constant.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('constant', () => { diff --git a/test/detect.js b/test/detect.js index 4bda08f..f6a5416 100644 --- a/test/detect.js +++ b/test/detect.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var _ = require('lodash'); describe("detect", () => { diff --git a/test/during.js b/test/during.js index fccb636..60b58ed 100644 --- a/test/during.js +++ b/test/during.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('during', () => { diff --git a/test/each.js b/test/each.js index 404ad33..d05457b 100644 --- a/test/each.js +++ b/test/each.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe("each", () => { diff --git a/test/eachOf.js b/test/eachOf.js index 39c36cf..871e0ae 100644 --- a/test/eachOf.js +++ b/test/eachOf.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); var _ = require('lodash'); diff --git a/test/ensureAsync.js b/test/ensureAsync.js index bbfc053..b4fb311 100644 --- a/test/ensureAsync.js +++ b/test/ensureAsync.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('ensureAsync', () => { diff --git a/test/es2017/asyncFunctions.js b/test/es2017/asyncFunctions.js index 23fa2e6..dddce22 100644 --- a/test/es2017/asyncFunctions.js +++ b/test/es2017/asyncFunctions.js @@ -1,5 +1,5 @@ var async = require('../../lib'); -const expect = require('chai').expect; +const {expect} = require('chai'); const assert = require('assert'); diff --git a/test/every.js b/test/every.js index 559084d..629246c 100644 --- a/test/every.js +++ b/test/every.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var _ = require('lodash'); describe("every", () => { diff --git a/test/filter.js b/test/filter.js index ee835cf..c636aa1 100644 --- a/test/filter.js +++ b/test/filter.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); function filterIteratee(x, callback) { setTimeout(() => { diff --git a/test/forever.js b/test/forever.js index ac12d3e..6ef3b4b 100644 --- a/test/forever.js +++ b/test/forever.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('forever', () => { context('function is asynchronous', () => { diff --git a/test/groupBy.js b/test/groupBy.js index dab125b..0fcf53b 100644 --- a/test/groupBy.js +++ b/test/groupBy.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('groupBy', function() { diff --git a/test/linked_list.js b/test/linked_list.js index ac29f1a..1bb004a 100644 --- a/test/linked_list.js +++ b/test/linked_list.js @@ -1,5 +1,5 @@ var DLL = require('../lib/internal/DoublyLinkedList').default; -var expect = require('chai').expect; +var {expect} = require('chai'); describe('DoublyLinkedList', () => { it('toArray', () => { diff --git a/test/map.js b/test/map.js index c104ab9..484e654 100644 --- a/test/map.js +++ b/test/map.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe("map", () => { diff --git a/test/mapValues.js b/test/mapValues.js index 83cc126..9f49840 100644 --- a/test/mapValues.js +++ b/test/mapValues.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('mapValues', () => { var obj = {a: 1, b: 2, c: 3}; diff --git a/test/memoize.js b/test/memoize.js index 7db26d3..88b6c64 100644 --- a/test/memoize.js +++ b/test/memoize.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe("memoize", () => { diff --git a/test/nextTick.js b/test/nextTick.js index 71af1a0..32ab06e 100644 --- a/test/nextTick.js +++ b/test/nextTick.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe("nextTick", () => { diff --git a/test/parallel.js b/test/parallel.js index 1fadaa8..d53a8c6 100644 --- a/test/parallel.js +++ b/test/parallel.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); var getFunctionsObject = require('./support/get_function_object'); diff --git a/test/priorityQueue.js b/test/priorityQueue.js index c3d5b70..2d9d4a5 100644 --- a/test/priorityQueue.js +++ b/test/priorityQueue.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('priorityQueue', () => { diff --git a/test/queue.js b/test/queue.js index 66a3f23..3eeeac8 100644 --- a/test/queue.js +++ b/test/queue.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); diff --git a/test/reduce.js b/test/reduce.js index 2e0f06c..1184b52 100644 --- a/test/reduce.js +++ b/test/reduce.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('reduce', () => { diff --git a/test/retry.js b/test/retry.js index 4b18149..7369f8a 100644 --- a/test/retry.js +++ b/test/retry.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); var _ = require('lodash'); diff --git a/test/retryable.js b/test/retryable.js index fe04db0..e18afdc 100644 --- a/test/retryable.js +++ b/test/retryable.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('retryable', () => { diff --git a/test/seq.js b/test/seq.js index 1f7d3f9..cbb7634 100644 --- a/test/seq.js +++ b/test/seq.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('seq', () => { diff --git a/test/series.js b/test/series.js index 8ee5374..a7c7d93 100644 --- a/test/series.js +++ b/test/series.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); var getFunctionsObject = require('./support/get_function_object'); diff --git a/test/setImmediate.js b/test/setImmediate.js index 6e4a400..1d8a06b 100644 --- a/test/setImmediate.js +++ b/test/setImmediate.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe("setImmediate", () => { diff --git a/test/some.js b/test/some.js index 5b54ec3..676797a 100644 --- a/test/some.js +++ b/test/some.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var _ = require('lodash'); describe("some", () => { diff --git a/test/sortBy.js b/test/sortBy.js index 1d2de82..8f4afe3 100644 --- a/test/sortBy.js +++ b/test/sortBy.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('sortBy', () => { diff --git a/test/timeout.js b/test/timeout.js index 81e90fc..e5596ac 100644 --- a/test/timeout.js +++ b/test/timeout.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('timeout', () => { diff --git a/test/times.js b/test/times.js index ac7d49c..f1c7f0a 100644 --- a/test/times.js +++ b/test/times.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('times', () => { diff --git a/test/transform.js b/test/transform.js index e8ab5d5..7a1c2e7 100644 --- a/test/transform.js +++ b/test/transform.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); describe('transform', () => { diff --git a/test/tryEach.js b/test/tryEach.js index 6ac6523..6cc257e 100644 --- a/test/tryEach.js +++ b/test/tryEach.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('tryEach', () => { diff --git a/test/until.js b/test/until.js index 9ea0605..ea39945 100644 --- a/test/until.js +++ b/test/until.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('until', () => { diff --git a/test/waterfall.js b/test/waterfall.js index 4736093..9c6d2e3 100644 --- a/test/waterfall.js +++ b/test/waterfall.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe("waterfall", () => { diff --git a/test/whilst.js b/test/whilst.js index 844e559..8348504 100644 --- a/test/whilst.js +++ b/test/whilst.js @@ -1,5 +1,5 @@ var async = require('../lib'); -var expect = require('chai').expect; +var {expect} = require('chai'); var assert = require('assert'); describe('whilst', () => { |