Bug 333637: assembleCmdLine needs to quote an empty-string argument. TheNSPR_HEAD_20080120

patch is contributed by Aleksey Sanin <aleksey@aleksey.com>.  r=wtc

1 files changed, 5 insertions, 2 deletions

diff --git a/pr/src/md/windows/ntmisc.c b/pr/src/md/windows/ntmisc.c
index 7cb5b3cb..67c970f3 100644
--- a/pr/src/md/windows/ntmisc.c
+++ b/pr/src/md/windows/ntmisc.c
@@ -147,8 +147,11 @@ static int assembleCmdLine(char *const *argv, char **cmdLine)
         numBackslashes = 0;
         argNeedQuotes = 0;
 
-        /* If the argument contains white space, it needs to be quoted. */
-        if (strpbrk(*arg, " \f\n\r\t\v")) {
+        /*
+         * If the argument is empty or contains white space, it needs to
+         * be quoted.
+         */
+        if (**arg == '\0' || strpbrk(*arg, " \f\n\r\t\v")) {
             argNeedQuotes = 1;
         }