summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornelsonb%netscape.com <devnull@localhost>2005-04-23 02:12:00 +0000
committernelsonb%netscape.com <devnull@localhost>2005-04-23 02:12:00 +0000
commitf731c3ac29a3716106c29e4fa98dee3196e97a4d (patch)
tree9400fcd52769e630499d07164bc99db130722d0d
parent086b5c02c109288c77902388116be2bae5a1c603 (diff)
downloadnss-hg-f731c3ac29a3716106c29e4fa98dee3196e97a4d.tar.gz
Prevent crash in certutil -C when incoming request has no attributes.
Bug 291542. r=julien.pierre
-rw-r--r--security/nss/cmd/certutil/certutil.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/security/nss/cmd/certutil/certutil.c b/security/nss/cmd/certutil/certutil.c
index b26b5b7ca..6d4eab56b 100644
--- a/security/nss/cmd/certutil/certutil.c
+++ b/security/nss/cmd/certutil/certutil.c
@@ -2184,7 +2184,10 @@ CreateCert(
}
if (certReq->attributes != NULL &&
- SECOID_FindOIDTag(&(*certReq->attributes)->attrType)
+ certReq->attributes[0] != NULL &&
+ certReq->attributes[0]->attrType.data != NULL &&
+ certReq->attributes[0]->attrType.len > 0 &&
+ SECOID_FindOIDTag(&certReq->attributes[0]->attrType)
== SEC_OID_PKCS9_EXTENSION_REQUEST) {
rv = CERT_GetCertificateRequestExtensions(certReq, &CRexts);
if (rv != SECSuccess)