Commenting out two types of stacks related to ocsp client memory leaks. The types: leaks that PKIX_Shutdown has resolved; leaks created by unknown error condition in libpkix library. The last one is under investigation.

1 files changed, 31 insertions, 22 deletions

diff --git a/security/nss/tests/memleak/ignored b/security/nss/tests/memleak/ignored
index 04261b205..52f9bbb6a 100644
--- a/security/nss/tests/memleak/ignored
+++ b/security/nss/tests/memleak/ignored
@@ -102,28 +102,37 @@ ocspclnt/main/NSS_Init/SECMOD_LoadModule/SECMOD_LoadModule/SECMOD_LoadPKCS11Modu
 */main/*/*/STAN_LoadDefaultNSS3TrustDomain/NSSTrustDomain_Create/NSSArena_Create/nssArena_Create/arena_add_pointer/nssPointerTracker_initialize/call_once/**
 
 #393174
-ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_HashTable_Add/pkix_pl_PrimHashTable_Add/PKIX_PL_Malloc/**
-ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Malloc/**
-ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PKIX_PL_Malloc/**
-ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PR_NewLock/**
-ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/pkix_EscASCII_to_UTF16/PKIX_PL_Malloc/**
-ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PKIX_PL_Malloc/**
-ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PR_NewLock/**
-ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/pkix_pl_Socket_CreateClient/PR_NewTCPSocket/PR_Socket/pt_SetMethods/_PR_Getfd/**
-ocspclnt/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/pkix_pl_Socket_CreateClient/PR_NewTCPSocket/PR_Socket/pt_SetMethods/_PR_Getfd/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_HashTable_Add/pkix_pl_PrimHashTable_Add/PKIX_PL_Malloc/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PKIX_PL_Malloc/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PR_NewLock/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/pkix_pl_Socket_CreateClient/PR_NewTCPSocket/PR_Socket/pt_SetMethods/_PR_Getfd/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/pkix_EscASCII_to_UTF16/PKIX_PL_Malloc/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Malloc/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PKIX_PL_Malloc/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PR_NewLock/**
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_HashTable_Add/pkix_pl_PrimHashTable_Add/PKIX_PL_Malloc
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Malloc
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PKIX_PL_Malloc
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/pkix_EscASCII_to_UTF16/PKIX_PL_Malloc
-ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PKIX_PL_Malloc
+
+# Memory allocated by these stacks should be freed at PKIX_Shutdown time, 
+# when httpClientCache object get freed. We should not see these stacks 
+# anymore. The exception is only the socket created by 
+# pkix_HttpCertStore_FindSocketConnection. Possible that it was not freed
+# due to some error condition. 
+#ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_HashTable_Add/pkix_pl_PrimHashTable_Add/PKIX_PL_Malloc/**
+#ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PKIX_PL_Malloc/**
+#ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PR_NewLock/**
+#ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/pkix_pl_Socket_CreateClient/PR_NewTCPSocket/PR_Socket/pt_SetMethods/_PR_Getfd/**
+#ocspclnt/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/pkix_pl_Socket_CreateClient/PR_NewTCPSocket/PR_Socket/pt_SetMethods/_PR_Getfd/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_HashTable_Add/pkix_pl_PrimHashTable_Add/PKIX_PL_Malloc/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PKIX_PL_Malloc/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PR_NewLock/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/pkix_pl_Socket_CreateClient/PR_NewTCPSocket/PR_Socket/pt_SetMethods/_PR_Getfd/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_HashTable_Add/pkix_pl_PrimHashTable_Add/PKIX_PL_Malloc
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/pkix_pl_Socket_CreateByHostAndPort/PKIX_PL_Object_Alloc/PKIX_PL_Malloc
+
+# This stacks were found because of some error condition. I'd like to find
+# and understand what happened, so commenting them out.
+#ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Malloc/**
+#ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PKIX_PL_Malloc/**
+#ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PR_NewLock/**
+#ocspclnt/main/get_cert_status/CERT_CheckOCSPStatus/ocsp_GetOCSPStatusFromNetwork/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/pkix_EscASCII_to_UTF16/PKIX_PL_Malloc/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/pkix_EscASCII_to_UTF16/PKIX_PL_Malloc/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Malloc/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PKIX_PL_Malloc/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseFromRequest/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_pl_HttpDefaultClient_RequestCreate/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PR_NewLock/**
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Malloc
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/PKIX_PL_Object_Alloc/PKIX_PL_Malloc
+#ocspclnt/main/CERT_CheckOCSPStatus/ocsp_GetEncodedOCSPResponseForSingleCert/ocsp_GetEncodedOCSPResponseFromRequest/fetchOcspHttpClientV1/pkix_pl_HttpDefaultClient_RequestCreateFcn/pkix_HttpCertStore_FindSocketConnection/PKIX_PL_Sprintf/PKIX_PL_String_Create/pkix_EscASCII_to_UTF16/PKIX_PL_Malloc
 
 #393181
 ocspclnt/main/CERT_SetOCSPDefaultResponder/PORT_Strdup/**