summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorkaie%kuix.de <devnull@localhost>2008-02-18 10:55:13 +0000
committerkaie%kuix.de <devnull@localhost>2008-02-18 10:55:13 +0000
commita7361444649503061d4084db1c2d39b50574c2ba (patch)
tree8cd7b636a44171b60e74a53d0a17203c62926f69
parent5ca7c8bff4f89be8a80fe31aff8ba8231d0b3fcf (diff)
downloadnss-hg-a7361444649503061d4084db1c2d39b50574c2ba.tar.gz
Bug 375019, Potential leak of certRequest
Add-on patch by Alexei Volkov r=kengert
-rw-r--r--security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c b/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c
index f523a0a88..d71cbc1d8 100644
--- a/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c
+++ b/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c
@@ -374,6 +374,8 @@ pkix_pl_OcspRequest_Create(
cid->certID, cert->nssCert, time,
addServiceLocatorExtension, nssSignerCert);
+ ocspRequest->decoded = certRequest;
+
if (certRequest == NULL) {
PKIX_ERROR(PKIX_UNABLETOCREATECERTOCSPREQUEST);
}
@@ -385,8 +387,6 @@ pkix_pl_OcspRequest_Create(
PKIX_ERROR(PKIX_UNABLETOADDACCEPTABLERESPONSESTOREQUEST);
}
- ocspRequest->decoded = certRequest;
-
encoding = CERT_EncodeOCSPRequest(NULL, certRequest, NULL);
ocspRequest->encoded = encoding;