397832 - libpkix leaks memory if a macro calls a function that returns an error. attachment 316504. r=nelson.

1 files changed, 4 insertions, 4 deletions

diff --git a/security/nss/lib/libpkix/pkix/top/pkix_policychecker.c b/security/nss/lib/libpkix/pkix/top/pkix_policychecker.c
index 633125c79..162f4763d 100755
--- a/security/nss/lib/libpkix/pkix/top/pkix_policychecker.c
+++ b/security/nss/lib/libpkix/pkix/top/pkix_policychecker.c
@@ -895,11 +895,11 @@ pkix_PolicyChecker_MakeMutableCopy(
         }
 
         *pMutableCopy = newList;
-
+        newList = NULL;
+        
 cleanup:
-        if (PKIX_ERROR_RECEIVED) {
-                PKIX_DECREF(newList);
-        }
+        PKIX_DECREF(newList);
+        PKIX_DECREF(object);
 
         PKIX_RETURN(CERTCHAINCHECKER);
 }