Added a comment to note a question I had while reviewing the code.

1 files changed, 6 insertions, 0 deletions

diff --git a/security/nss/cmd/dbck/dbck.c b/security/nss/cmd/dbck/dbck.c
index f6e13c461..b906b84a8 100644
--- a/security/nss/cmd/dbck/dbck.c
+++ b/security/nss/cmd/dbck/dbck.c
@@ -1489,6 +1489,12 @@ findNewestSubjectForEmail(CERTCertDBHandle *handle, int subjectNum,
 	CERT_DestroyCertificate(cert);
     }
 
+    /*
+     * XXX Should we make sure that subjectEntry1->emailAddr is not
+     * a null pointer or an empty string before going into the next
+     * two for loops, which pass it to PORT_Strcmp?
+     */
+
     /*  Loop over the remaining subjects.  */
     for (i=subjectNum+1; i<subjects.numEntries; i++) {
 	subjectEntry2 = (certDBEntrySubject*)&subjects.entries[i];