summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWan-Teh Chang <wtc@google.com>2014-01-03 14:28:06 -0800
committerWan-Teh Chang <wtc@google.com>2014-01-03 14:28:06 -0800
commite94e2447f11c37dd4d72a4f9e07d64079cda67f1 (patch)
tree3599401418ad24de9c37d401a94d31ededc02ce6
parentea49db5d7985f0973cf01d40a62bd39033a4d19e (diff)
downloadnss-hg-e94e2447f11c37dd4d72a4f9e07d64079cda67f1.tar.gz
Bug 946984: pkix_CrlChecker_CheckExternal and pkix_CrlChecker_CheckLocal
should set their pReasonCode output argument. r=ryan.sleevi.
-rw-r--r--lib/libpkix/pkix/checker/pkix_crlchecker.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/libpkix/pkix/checker/pkix_crlchecker.c b/lib/libpkix/pkix/checker/pkix_crlchecker.c
index 63bccd565..c77ac8ef1 100644
--- a/lib/libpkix/pkix/checker/pkix_crlchecker.c
+++ b/lib/libpkix/pkix/checker/pkix_crlchecker.c
@@ -201,7 +201,6 @@ pkix_CrlChecker_CheckLocal(
PKIX_CertStore_CheckRevokationByCrlCallback storeCheckRevocationFn;
PKIX_CertStore *certStore = NULL;
pkix_CrlChecker *state = NULL;
- PKIX_UInt32 reasonCode = 0;
PKIX_UInt32 crlStoreIndex = 0;
PKIX_UInt32 numCrlStores = 0;
PKIX_Boolean storeIsLocal = PKIX_FALSE;
@@ -242,7 +241,7 @@ pkix_CrlChecker_CheckLocal(
chainVerificationState ? date : NULL,
/* crl downloading is not done. */
PKIX_FALSE,
- &reasonCode, &revStatus, plContext),
+ pReasonCode, &revStatus, plContext),
PKIX_CERTSTORECRLCHECKFAILED);
if (revStatus == PKIX_RevStatus_Revoked) {
break;
@@ -307,7 +306,6 @@ pkix_CrlChecker_CheckExternal(
PKIX_CRLSelector *crlSelector = NULL;
PKIX_PL_X500Name *issuerName = NULL;
pkix_CrlChecker *state = NULL;
- PKIX_UInt32 reasonCode = 0;
PKIX_UInt32 crlStoreIndex = 0;
PKIX_UInt32 numCrlStores = 0;
PKIX_Boolean storeIsLocal = PKIX_FALSE;
@@ -410,7 +408,7 @@ pkix_CrlChecker_CheckExternal(
(*storeCheckRevocationFn)(certStore, cert, issuer, date,
/* done with crl downloading */
PKIX_TRUE,
- &reasonCode, &revStatus, plContext),
+ pReasonCode, &revStatus, plContext),
PKIX_CERTSTORECRLCHECKFAILED);
if (revStatus != PKIX_RevStatus_NoInfo) {
break;