diff options
| author | Tim Taubert <ttaubert@mozilla.com> | 2016-11-21 08:58:43 +0100 |
|---|---|---|
| committer | Tim Taubert <ttaubert@mozilla.com> | 2016-11-21 08:58:43 +0100 |
| commit | 5eb8f874bbd4026b238db1554dccf8b4eafc0761 (patch) | |
| tree | d77b2c1bad12d53ecf94a51cec65b8de686430bb | |
| parent | 5d8d034fa295a3f9f7efbed6be8f2002935fb84c (diff) | |
| download | nss-hg-5eb8f874bbd4026b238db1554dccf8b4eafc0761.tar.gz | |
Bug 1318962 - ssl3_SendCertificateVerify() might not properly unlock r=franziskus
Differential Revision: https://nss-review.dev.mozaws.net/D87
| -rw-r--r-- | lib/ssl/ssl3con.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/ssl/ssl3con.c b/lib/ssl/ssl3con.c index ffb238d00..35641976a 100644 --- a/lib/ssl/ssl3con.c +++ b/lib/ssl/ssl3con.c @@ -6504,14 +6504,13 @@ ssl3_SendCertificateVerify(sslSocket *ss, SECKEYPrivateKey *privKey) hashAlg, &hashes); if (rv != SECSuccess) { ssl_MapLowLevelError(SSL_ERROR_DIGEST_FAILURE); - goto done; } } else { rv = ssl3_ComputeHandshakeHashes(ss, ss->ssl3.pwSpec, &hashes, 0); } ssl_ReleaseSpecReadLock(ss); if (rv != SECSuccess) { - goto done; /* err code was set by ssl3_ComputeHandshakeHashes */ + goto done; /* err code was set by ssl3_ComputeHandshakeHash(es) */ } isTLS12 = (PRBool)(ss->version == SSL_LIBRARY_VERSION_TLS_1_2); |