Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan

3 files changed, 14 insertions, 5 deletions

diff --git a/lib/mozpkix/include/pkix/Time.h b/lib/mozpkix/include/pkix/Time.h
index e997682b3..24c84d430 100644
--- a/lib/mozpkix/include/pkix/Time.h
+++ b/lib/mozpkix/include/pkix/Time.h
@@ -49,7 +49,10 @@ public:
   // This will succeed, leaving the time uninitialized:
   //    Time x(Time::uninitialized);
   enum Uninitialized { uninitialized };
-  explicit Time(Uninitialized) { }
+  explicit Time(Uninitialized)
+    : elapsedSecondsAD{}
+  {
+  }
 
   bool operator==(const Time& other) const
   {
diff --git a/lib/mozpkix/lib/pkixbuild.cpp b/lib/mozpkix/lib/pkixbuild.cpp
index db65d6021..94f01d33a 100644
--- a/lib/mozpkix/lib/pkixbuild.cpp
+++ b/lib/mozpkix/lib/pkixbuild.cpp
@@ -47,11 +47,14 @@ TrustDomain::IssuerChecker::~IssuerChecker() { }
 class PathBuildingStep final : public TrustDomain::IssuerChecker
 {
 public:
-  PathBuildingStep(TrustDomain& aTrustDomain, const BackCert& aSubject,
-                   Time aTime, KeyPurposeId aRequiredEKUIfPresent,
+  PathBuildingStep(TrustDomain& aTrustDomain,
+                   const BackCert& aSubject,
+                   Time aTime,
+                   KeyPurposeId aRequiredEKUIfPresent,
                    const CertPolicyId& aRequiredPolicy,
                    /*optional*/ const Input* aStapledOCSPResponse,
-                   unsigned int aSubCACount, Result aDeferredSubjectError,
+                   unsigned int aSubCACount,
+                   Result aDeferredSubjectError,
                    unsigned int& aBuildForwardCallBudget)
     : trustDomain(aTrustDomain)
     , subject(aSubject)
@@ -61,6 +64,7 @@ public:
     , stapledOCSPResponse(aStapledOCSPResponse)
     , subCACount(aSubCACount)
     , deferredSubjectError(aDeferredSubjectError)
+    , subjectSignaturePublicKeyAlg{ static_cast<der::PublicKeyAlgorithm>(0) }
     , result(Result::FATAL_ERROR_LIBRARY_FAILURE)
     , resultWasSet(false)
     , buildForwardCallBudget(aBuildForwardCallBudget)
diff --git a/lib/mozpkix/lib/pkixutil.h b/lib/mozpkix/lib/pkixutil.h
index c22ffbefe..3bde8f792 100644
--- a/lib/mozpkix/lib/pkixutil.h
+++ b/lib/mozpkix/lib/pkixutil.h
@@ -42,11 +42,13 @@ class BackCert final
 {
 public:
   // certDER and childCert must be valid for the lifetime of BackCert.
-  BackCert(Input aCertDER, EndEntityOrCA aEndEntityOrCA,
+  BackCert(Input aCertDER,
+           EndEntityOrCA aEndEntityOrCA,
            const BackCert* aChildCert)
     : der(aCertDER)
     , endEntityOrCA(aEndEntityOrCA)
     , childCert(aChildCert)
+    , version{ static_cast<der::Version>(0) }
   {
   }