diff options
| author | Jeff Walden <jwalden@mit.edu> | 2020-05-21 20:08:26 +0000 |
|---|---|---|
| committer | Jeff Walden <jwalden@mit.edu> | 2020-05-21 20:08:26 +0000 |
| commit | 16a0ab4ec0fa665e63015d8df19ec9b0beaa0037 (patch) | |
| tree | 0ad6efb5cab91887aeb9589739ee750650464789 | |
| parent | 667ead212e5ff6b9d2d2da412802513af7a4df1b (diff) | |
| download | nss-hg-16a0ab4ec0fa665e63015d8df19ec9b0beaa0037.tar.gz | |
Bug 1639033 - Use unsigned int for various count variables in mplogic.c to eliminate signed-unsigned comparison warnings. r=kjacobs
Depends on D75844
Differential Revision: https://phabricator.services.mozilla.com/D75845
| -rw-r--r-- | lib/freebl/mpi/mplogic.c | 10 | ||||
| -rw-r--r-- | lib/freebl/mpi/mplogic.h | 6 |
2 files changed, 7 insertions, 9 deletions
diff --git a/lib/freebl/mpi/mplogic.c b/lib/freebl/mpi/mplogic.c index 89fd03ae8..31fc56d34 100644 --- a/lib/freebl/mpi/mplogic.c +++ b/lib/freebl/mpi/mplogic.c @@ -222,10 +222,9 @@ mpl_lsh(const mp_int *a, mp_int *b, mp_digit d) /* {{{ mpl_num_set(a, num) */ mp_err -mpl_num_set(mp_int *a, int *num) +mpl_num_set(mp_int *a, unsigned int *num) { - unsigned int ix; - int db, nset = 0; + unsigned int ix, db, nset = 0; mp_digit cur; unsigned char reg; @@ -253,10 +252,9 @@ mpl_num_set(mp_int *a, int *num) /* {{{ mpl_num_clear(a, num) */ mp_err -mpl_num_clear(mp_int *a, int *num) +mpl_num_clear(mp_int *a, unsigned int *num) { - unsigned int ix; - int db, nset = 0; + unsigned int ix, db, nset = 0; mp_digit cur; unsigned char reg; diff --git a/lib/freebl/mpi/mplogic.h b/lib/freebl/mpi/mplogic.h index 6a0f67c50..71b755139 100644 --- a/lib/freebl/mpi/mplogic.h +++ b/lib/freebl/mpi/mplogic.h @@ -39,9 +39,9 @@ mp_err mpl_lsh(const mp_int *a, mp_int *b, mp_digit d); /* left shift */ /* Bit count and parity */ -mp_err mpl_num_set(mp_int *a, int *num); /* count set bits */ -mp_err mpl_num_clear(mp_int *a, int *num); /* count clear bits */ -mp_err mpl_parity(mp_int *a); /* determine parity */ +mp_err mpl_num_set(mp_int *a, unsigned int *num); /* count set bits */ +mp_err mpl_num_clear(mp_int *a, unsigned int *num); /* count clear bits */ +mp_err mpl_parity(mp_int *a); /* determine parity */ /* Get & Set the value of a bit */ |