Bug 1784191 - Cast the result of GetProcAddress. r=bbeurdouche,nss-reviewers

clang trunk recently added a check for incompatible function pointers,
and now is not happy with a FARPROC being given as a
PRThreadPrivateDTOR, because that's not the same signature. But FARPROC
is the "normal" return type from GetProcAddress, but OTOH, it's not the
actual type signature for PR_Free.

Differential Revision: https://phabricator.services.mozilla.com/D154337

1 files changed, 1 insertions, 1 deletions

diff --git a/lib/base/error.c b/lib/base/error.c
index 2ef032933..6cbe785c3 100644
--- a/lib/base/error.c
+++ b/lib/base/error.c
@@ -86,7 +86,7 @@ error_once_function(void)
 #if defined(__MINGW32__)
     HMODULE nss3 = GetModuleHandleW(L"nss3");
     if (nss3) {
-        FARPROC freePtr = GetProcAddress(nss3, "PR_Free");
+        PRThreadPrivateDTOR freePtr = (PRThreadPrivateDTOR)GetProcAddress(nss3, "PR_Free");
         if (freePtr) {
             return PR_NewThreadPrivateIndex(&error_stack_index, freePtr);
         }