Bug 1439350, NSS 3.31 introduced a shutdown leak, after executing PK11_ListCerts(PK11CertListAll) with p11-kit-trust.so, r=rrelyea

1 files changed, 2 insertions, 0 deletions

diff --git a/lib/pki/pkibase.c b/lib/pki/pkibase.c
index 4082a37bd..f58a262cf 100644
--- a/lib/pki/pkibase.c
+++ b/lib/pki/pkibase.c
@@ -923,9 +923,11 @@ nssPKIObjectCollection_AddInstanceAsObject(
         return PR_FAILURE;
     }
     if (!node->haveObject) {
+        nssPKIObject *original = node->object;
         node->object = (*collection->createObject)(node->object);
         if (!node->object) {
             /*remove bogus object from list*/
+            nssPKIObject_Destroy(original);
             nssPKIObjectCollection_RemoveNode(collection, node);
             return PR_FAILURE;
         }