Bug 1281724 - Fix leak in crlutil's crlgen.c r=franziskus

1 files changed, 12 insertions, 5 deletions

diff --git a/cmd/crlutil/crlgen.c b/cmd/crlutil/crlgen.c
index bc8802137..1f9dc4b43 100644
--- a/cmd/crlutil/crlgen.c
+++ b/cmd/crlutil/crlgen.c
@@ -67,16 +67,23 @@ static SECStatus
 crlgen_RmEntry(CRLGENGeneratorData *crlGenData, SECItem *certId)
 {
     CRLGENEntryData *data = NULL;
+    SECStatus rv = SECSuccess;
 
-    if (!crlGenData->entryDataHashTable)
+    if (!crlGenData->entryDataHashTable) {
         return SECSuccess;
+    }
+
     data = crlgen_FindEntry(crlGenData, certId);
-    if (!data)
-        return SECSuccess;
-    if (PL_HashTableRemove(crlGenData->entryDataHashTable, certId))
+    if (!data) {
         return SECSuccess;
+    }
+
+    if (!PL_HashTableRemove(crlGenData->entryDataHashTable, certId)) {
+        rv = SECFailure;
+    }
+
     destroyEntryData(data);
-    return SECFailure;
+    return rv;
 }
 
 /* Stores CRLGENEntryData in hashtable according to certId