summaryrefslogtreecommitdiff
path: root/lib/certhigh
diff options
context:
space:
mode:
authorKai Engert <kaie@kuix.de>2013-10-29 20:46:26 +0100
committerKai Engert <kaie@kuix.de>2013-10-29 20:46:26 +0100
commitf24e70539b7cae9f90105f7f5e8786c8af269068 (patch)
treefe78b309322c04422c2d658c2fe87685078764de /lib/certhigh
parentb38a2c695f442e2e4db2fe0c00e7103759a105e3 (diff)
downloadnss-hg-f24e70539b7cae9f90105f7f5e8786c8af269068.tar.gz
Bug 932020 - CERT_CacheOCSPResponseFromSideChannel fails to set error code in some cases when returning SECFailure, r=wtc
Diffstat (limited to 'lib/certhigh')
-rw-r--r--lib/certhigh/ocsp.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/certhigh/ocsp.c b/lib/certhigh/ocsp.c
index 3ec6b1311..e674f5d98 100644
--- a/lib/certhigh/ocsp.c
+++ b/lib/certhigh/ocsp.c
@@ -5169,8 +5169,9 @@ CERT_CacheOCSPResponseFromSideChannel(CERTCertDBHandle *handle,
encodedResponse,
&decodedResponse,
&singleResponse);
- /* Cache any valid singleResponse, regardless of status. */
- if (rv == SECSuccess && singleResponse) {
+ if (rv == SECSuccess) {
+ rvOcsp = ocsp_SingleResponseCertHasGoodStatus(singleResponse, time);
+ /* Cache any valid singleResponse, regardless of status. */
ocsp_CacheSingleResponse(certID, singleResponse, &certIDWasConsumed);
}
if (decodedResponse) {