diff options
| author | Franziskus Kiefer <franziskuskiefer@gmail.com> | 2016-07-07 16:16:28 +0200 |
|---|---|---|
| committer | Franziskus Kiefer <franziskuskiefer@gmail.com> | 2016-07-07 16:16:28 +0200 |
| commit | a19dbbd6b407e9a41c0a53bd05d040c8c28e444a (patch) | |
| tree | ba1ee83e1ada5baf2438fa21ecf62fdf0500453e /lib/freebl/rsa.c | |
| parent | bcb327a9785915f9bd7d0977f6e7662e30167f68 (diff) | |
| download | nss-hg-a19dbbd6b407e9a41c0a53bd05d040c8c28e444a.tar.gz | |
Bug 1284789 - fixing some scan-build issues, r=ttaubert
Diffstat (limited to 'lib/freebl/rsa.c')
| -rw-r--r-- | lib/freebl/rsa.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/freebl/rsa.c b/lib/freebl/rsa.c index e08dc4a3a..443ef25ec 100644 --- a/lib/freebl/rsa.c +++ b/lib/freebl/rsa.c @@ -553,7 +553,6 @@ rsa_get_primes_from_exponents(mp_int *e, mp_int *d, mp_int *p, mp_int *q, if (err != MP_OKAY) { if (err == MP_NO) { /* No, then we still have the wrong phi */ - err = MP_OKAY; continue; } goto cleanup; @@ -1259,7 +1258,8 @@ get_blinding_params(RSAPrivateKey *key, mp_int *n, unsigned int modLen, /* Put this at head of queue of usable params. */ PZ_Lock(blindingParamsList.lock); - holdingLock = PR_TRUE; + holdingLock = PR_TRUE; + (void)holdingLock; /* initialize RSABlindingParamsStr */ bp->counter = RSA_BLINDING_PARAMS_MAX_REUSE; bp->next = rsabp->bp; @@ -1285,6 +1285,7 @@ get_blinding_params(RSAPrivateKey *key, mp_int *n, unsigned int modLen, PR_WaitCondVar( blindingParamsList.cVar, PR_INTERVAL_NO_TIMEOUT ); PZ_Unlock(blindingParamsList.lock); holdingLock = PR_FALSE; + (void)holdingLock; } while (1); cleanup: @@ -1304,7 +1305,6 @@ cleanup: } if (holdingLock) { PZ_Unlock(blindingParamsList.lock); - holdingLock = PR_FALSE; } if (err) { MP_TO_SEC_ERROR(err); |