Bug 1447825 - Check sslBuffer_Append in ssl_CallCustomExtensionSenders r=mt

Coverity caught that one use of sslBuffer_Append doesn't check the return,
which is abnormal. Since cleanup is the same either way, it's a matter for
OOM propagation. This adds the check in a minimal way.

1 files changed, 5 insertions, 1 deletions

diff --git a/lib/ssl/ssl3ext.c b/lib/ssl/ssl3ext.c
index 5a5077998..28c2611b1 100644
--- a/lib/ssl/ssl3ext.c
+++ b/lib/ssl/ssl3ext.c
@@ -681,7 +681,11 @@ ssl_CallCustomExtensionSenders(sslSocket *ss, sslBuffer *buf,
         }
     }
 
-    sslBuffer_Append(buf, tail.buf, tail.len);
+    rv = sslBuffer_Append(buf, tail.buf, tail.len);
+    if (rv != SECSuccess) {
+        goto loser; /* Code already set. */
+    }
+
     sslBuffer_Clear(&tail);
     return SECSuccess;