diff options
| author | kaie%kuix.de <devnull@localhost> | 2011-05-07 18:30:45 +0000 |
|---|---|---|
| committer | kaie%kuix.de <devnull@localhost> | 2011-05-07 18:30:45 +0000 |
| commit | 3ea0cedab35182ef9ccf2b9e626800bdd4182a32 (patch) | |
| tree | 989782fedc9baebd643e8a0b96de5357f6901592 /security/nss/cmd | |
| parent | 8d87cbbc48d36271c52258560a28f46ba036bd85 (diff) | |
| download | nss-hg-3ea0cedab35182ef9ccf2b9e626800bdd4182a32.tar.gz | |
Bug 650276 - SECU_DerSignDataCRL improperly initializes sd because it uses sizeof instead of sizeof*, Patch by Ludovic Hirlimann, r=bsmith, r=wtc
Diffstat (limited to 'security/nss/cmd')
| -rw-r--r-- | security/nss/cmd/lib/secutil.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/security/nss/cmd/lib/secutil.c b/security/nss/cmd/lib/secutil.c index 05f4ea0ad..2a7d1052a 100644 --- a/security/nss/cmd/lib/secutil.c +++ b/security/nss/cmd/lib/secutil.c @@ -3980,15 +3980,13 @@ SECU_DerSignDataCRL(PRArenaPool *arena, CERTSignedData *sd, if (rv) goto loser; /* Fill out SignedData object */ - PORT_Memset(sd, 0, sizeof(sd)); + PORT_Memset(sd, 0, sizeof(*sd)); sd->data.data = buf; sd->data.len = len; sd->signature.data = it.data; sd->signature.len = it.len << 3; /* convert to bit string */ - if (!sd->signatureAlgorithm.parameters.data) { - rv = SECOID_SetAlgorithmID(arena, &sd->signatureAlgorithm, algID, 0); - if (rv) goto loser; - } + rv = SECOID_SetAlgorithmID(arena, &sd->signatureAlgorithm, algID, 0); + if (rv) goto loser; return rv; |