diff options
| author | nelson%bolyard.com <devnull@localhost> | 2009-07-15 22:38:23 +0000 |
|---|---|---|
| committer | nelson%bolyard.com <devnull@localhost> | 2009-07-15 22:38:23 +0000 |
| commit | d349a42dbd7057282ff43a427acfa637fd35253d (patch) | |
| tree | 2905d7d37ae8b318d04ecc590cbf12488d0c2689 /security/nss/lib/libpkix/pkix_pl_nss | |
| parent | 8760e8b0c897347767a910fcbb1ea110297ab671 (diff) | |
| download | nss-hg-d349a42dbd7057282ff43a427acfa637fd35253d.tar.gz | |
Bug 504405: pkix_pl_CrlDp_Create will fail on alloc success because of a missing !
Bug 504408: pkix_pl_CrlDp_Create will always fail if dp->distPointType != generalName
Bugs found by Coverity. Patches by Timeless <timeless@bemail.org>, r=nelson
Diffstat (limited to 'security/nss/lib/libpkix/pkix_pl_nss')
| -rw-r--r-- | security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_crldp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_crldp.c b/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_crldp.c index 3e88768a9..60cdd79d2 100644 --- a/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_crldp.c +++ b/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_crldp.c @@ -152,7 +152,7 @@ pkix_pl_CrlDp_Create( issuerName = certIssuerName; } rdnArena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE); - if (rdnArena) { + if (!rdnArena) { PKIX_ERROR(PKIX_PORTARENAALLOCFAILED); } issuerNameCopy = (CERTName *)PORT_ArenaZNew(rdnArena, CERTName*); @@ -164,7 +164,7 @@ pkix_pl_CrlDp_Create( PKIX_ERROR(PKIX_ALLOCERROR); } rv = CERT_AddRDN(issuerNameCopy, (CERTRDN*)relName); - if (rv = SECFailure) { + if (rv == SECFailure) { PKIX_ERROR(PKIX_ALLOCERROR); } dpl->distPointType = relativeDistinguishedName; |