Clean up compilier warnings on Solaris and Linux, most particularly:

1) Implicit declaration of function.
2) Possibly unitialized variables.

These warnings have indicated some real problems in the code, so many changes
are not just to silence the warnings, but to fix the problems. Others were
inocuous, but the warnings were silenced to reduce the noise.

2 files changed, 3 insertions, 2 deletions

diff --git a/security/nss/lib/pki1/atav.c b/security/nss/lib/pki1/atav.c
index 5d87efaf6..cd89bc7d6 100644
--- a/security/nss/lib/pki1/atav.c
+++ b/security/nss/lib/pki1/atav.c
@@ -1745,7 +1745,8 @@ nssATAV_Compare
     return PR_SUCCESS;
   }
 
-  return nsslibc_compare(atav1->value, atav2->value, len1, equalp);
+  *equalp = nsslibc_memequal(atav1->value, atav2->value, len1, &status);
+  return status;
 }
 
 
diff --git a/security/nss/lib/pki1/oid.c b/security/nss/lib/pki1/oid.c
index 2631682d4..9bddf33ee 100644
--- a/security/nss/lib/pki1/oid.c
+++ b/security/nss/lib/pki1/oid.c
@@ -324,7 +324,7 @@ oid_hash_compare
 
   PRUint32 size = (i1->size < i2->size) ? i1->size : i2->size;
 
-  rv = (PRIntn)nsslibc_memcmp(i1->data, i2->data, size, (PRStatus *)NULL);
+  rv = (PRIntn)nsslibc_memequal(i1->data, i2->data, size, (PRStatus *)NULL);
   if( 0 == rv ) {
     rv = i1->size - i2->size;
   }