summaryrefslogtreecommitdiff
path: root/lib/pk11wrap/pk11slot.c
diff options
context:
space:
mode:
Diffstat (limited to 'lib/pk11wrap/pk11slot.c')
-rw-r--r--lib/pk11wrap/pk11slot.c18
1 files changed, 8 insertions, 10 deletions
diff --git a/lib/pk11wrap/pk11slot.c b/lib/pk11wrap/pk11slot.c
index 1f6597b5e..044956fe4 100644
--- a/lib/pk11wrap/pk11slot.c
+++ b/lib/pk11wrap/pk11slot.c
@@ -555,10 +555,10 @@ PK11_FindSlotsByNames(const char *dllName, const char* slotName,
break;
}
if ((PR_FALSE == presentOnly || PK11_IsPresent(tmpSlot)) &&
- ( (!tokenName) || (tmpSlot->token_name &&
- (0==PORT_Strcmp(tmpSlot->token_name, tokenName)))) &&
- ( (!slotName) || (tmpSlot->slot_name &&
- (0==PORT_Strcmp(tmpSlot->slot_name, slotName)))) ) {
+ ( (!tokenName) ||
+ (0==PORT_Strcmp(tmpSlot->token_name, tokenName)) ) &&
+ ( (!slotName) ||
+ (0==PORT_Strcmp(tmpSlot->slot_name, slotName)) ) ) {
if (tmpSlot) {
PK11_AddSlotToList(slotList, tmpSlot, PR_TRUE);
slotcount++;
@@ -1105,7 +1105,6 @@ PK11_InitToken(PK11SlotInfo *slot, PRBool loadCerts)
{
CK_TOKEN_INFO tokenInfo;
CK_RV crv;
- char *tmp;
SECStatus rv;
PRStatus status;
@@ -1139,8 +1138,8 @@ PK11_InitToken(PK11SlotInfo *slot, PRBool loadCerts)
if (slot->isActiveCard) {
slot->protectedAuthPath = PR_FALSE;
}
- tmp = PK11_MakeString(NULL,slot->token_name,
- (char *)tokenInfo.label, sizeof(tokenInfo.label));
+ (void)PK11_MakeString(NULL,slot->token_name,
+ (char *)tokenInfo.label, sizeof(tokenInfo.label));
slot->minPassword = tokenInfo.ulMinPinLen;
slot->maxPassword = tokenInfo.ulMaxPinLen;
PORT_Memcpy(slot->serial,tokenInfo.serialNumber,sizeof(slot->serial));
@@ -1349,7 +1348,6 @@ void
PK11_InitSlot(SECMODModule *mod, CK_SLOT_ID slotID, PK11SlotInfo *slot)
{
SECStatus rv;
- char *tmp;
CK_SLOT_INFO slotInfo;
slot->functionList = mod->functionList;
@@ -1371,7 +1369,7 @@ PK11_InitSlot(SECMODModule *mod, CK_SLOT_ID slotID, PK11SlotInfo *slot)
* works because modules keep implicit references
* from their slots, and won't unload and disappear
* until all their slots have been freed */
- tmp = PK11_MakeString(NULL,slot->slot_name,
+ (void)PK11_MakeString(NULL,slot->slot_name,
(char *)slotInfo.slotDescription, sizeof(slotInfo.slotDescription));
slot->isHW = (PRBool)((slotInfo.flags & CKF_HW_SLOT) == CKF_HW_SLOT);
#define ACTIVE_CARD "ActivCard SA"
@@ -2052,7 +2050,7 @@ PK11_GetBestSlotMultipleWithAttributes(CK_MECHANISM_TYPE *type,
PK11SlotInfo *slot = NULL;
PRBool freeit = PR_FALSE;
PRBool listNeedLogin = PR_FALSE;
- int i;
+ unsigned int i;
SECStatus rv;
list = PK11_GetSlotList(type[0]);