| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
| |
This script was used to provide module-specific compiler flags.
Now that we use GNU make, these flags can be handled by make itslef.
|
| | |
|
| | |
|
| |
|
|
| |
This commit removes support for gprof-based profiling (the -p option to ocamlopt). It follows a discussion on the core developers' list, which indicated that removing gprof support was a reasonable thing to do. The rationale is that there are better easy-to-use profilers out there now, such as perf for Linux and Instruments on macOS; and the gprof support has always been patchy across targets. We save a whole build of the runtime and simplify some other parts of the codebase by removing it.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Before this change, check-typo would run on manual/Makefile for
example, while this file lives within a pruned directory so it
ought to be ignored by the tool.
Note: the check-typo code seems to assume that the only pruned things
are directory, it prints "pruned directory ..." when something is
pruned. I haven't changed this part of the logic; but note that normal
./check-typo invocation will only check pruning for directories.
|
| | |
|
| | |
|
| |\
| |
| | |
documentation: precedence table for the standard library.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
This will be very useful for an upcoming PR implementing a different
unboxing check, which change the result for some of the tests. Without
the present change, the diff in test results was unreadable, which
is problematic for development and for code review.
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
typo.long-line can still be explicitly set in .gitattributes (and
typo.long-line typo.very-long-line=may will still issue unused if no
lines are more than 80 columns)
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this patch, check-typo is directed by a single git attribute,
ocaml-typo, which is used as a key to set a value:
ocaml-typo=long-line,missing-header
(the value here is `long-line,missing-header`, and the code splits the
comma later)
This model is very fragile because .gitattributes does not allow to
give attribute keys a collecting/aggregating semantic: each new
setting of the key removes the previous setting, instead of adding to
them. For example,
testsuite/tests/** ocaml-typo=missing-header
testsuite/tests/win-unicode/*.ml ocaml-typo=utf8
and
testsuite/tests/win-unicode/*.ml ocaml-typo=utf8
testsuite/tests/** ocaml-typo=missing-header
are not equivalent, and instead of using either one we would introduce
redundancy for robustness:
testsuite/tests/** ocaml-typo=missing-header
testsuite/tests/win-unicode/*.ml ocaml-typo=missing-header,utf8
With this patch, we switch to a model where each ocaml-typo setting is
its own attribute, of the form `typo.<<attribute>>`. The lines above
would be written, in either order:
testsuite/tests/** typo.missing-header
testsuite/tests/win-unicode/*.ml typo.utf8
Not only does this approach make our .gitattributes more robust, it
allows for a more fine-grained treatment of the "unused-prop"
marker. This was used as an attribute to say: don't make it in an
error if the given typo-rule is in fact respected (by default, opting
out of a typo-rule gives an error if the typo-rule is respected). But
because of the single-key nature of ocaml-typo, unused-prop would
range over all settings, not just one of them. For example
emacs/caml.el ocaml-typo=long-line,unused-prop,missing-header
seems to suggest that 'unused-prop' only qualifies the 'long-line'
rule, but in fact it also ranges over 'missing-header'. In contrast,
with this patch, we write the following:
emacs/caml.el typo.long-line=may typo.missing-header
the `=may` value setting is used to make an exception to a typo-rule
optional.
Interestingly, most .gitattributes lines worked without extra error
when I turned each unused-prop in a =may setting over the rule just
before, instead of all rules: our checking is now more precise than
before, better capturing the intent of the .gitattributes author.
As I had to rewrite parts of the check-typo code for this, I took the
opportunity to rename a couple variables speaking about SVN (now long
defunct) into more meaningful names:
- `$is_svn` => `$path_in_index`
- `$svnrules` => `$attr_rules`
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* add a release checklist
Currently this list isn't publicly available, it sits in various
different versions on @damiendoligez's filesystems. He sent me a copy
when I took care of some of the recent releases. The present
presentation is a result of significant cleanups and changes to the
checklist -- in particular, some mistakes may have jumped in.
This is not a scripted process, it is very informal and it is likely
that there are some mistakes/omissions in the list. Yet, it sounds
better to have it somewhere in the source repository than not have it
around at all. It was certainly helpful to me, and it probably would
be to other release-help volunteers.
(The list is put in tools/ because there isn't a clearly better place
for it. This choice was suggested by Damien.)
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
This subdirectory was used to store experimental patches on some older
version-control system where branching (or discussing branches?) was
inconvenient. It doesn't make much sense anymore now, and getting rid
of it simplifies a couple places that had to grow around it.
Suggested-by: Nicolás Ojeda Bär
(no change entry needed)
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This patch is used during the bootstrap CI job.
Moreover, the patch should be exempted from the long-line check-typo rule.
|
| |
|
|
| |
Without the leading slash, these apply in multiple places.
|
| |
|
|
|
| |
Automatically runs tools/check-typo and rejects the commit if they don't
pass.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Update .gitattributes to ensure standard scripts are checked out with LF
line-endings on Windows.
Renamed the various detection scripts to begin has- both for readability
and to limit the number of scripts which need to be explicitly
mentioned in .gitattributes.
|
| |
|
|
| |
ocamldoc/odoc_index.html doesn't require a copyright header.
|
| |
|
|
|
| |
Using continuation characters makes less sense for these tests (the
previous .reference files were permitted to have long-line).
|
| |
|
|
|
|
| |
Patch files should be marked as either LF or binary to prevent
Windows checkouts mangling them. Patch files necessarily don't include
headers and have whitespace at EOL.
|
| |
|
|
|
| |
Assembly stubs were moved out of testsuite/tests and so lost the
inherited missing-header ocaml-typo attribute.
|
| |
|
|
|
| |
The utf8 rule allows UTF-8 sequences anywhere in a file and line-length
calculations take this into account.
|
| |
|
|
| |
It contains UTF-8 characters in directory names.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
All three builds on AppVeyor updated so that the build takes place and
has PREFIX set to a directory which includes 2+ bytes UTF-8 sequences
and UTF-16 surrogate characters.
|
| |
|
|
|
| |
This is only to allow for a few specific instances, so for the time
being implemented for long-long and not very-long-line.
|
