summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Leech <cleech@redhat.com>2019-10-30 13:39:41 -0700
committerChris Leech <cleech@redhat.com>2019-10-31 15:48:08 -0700
commit30dfe8b18e48fbd7950138feeea2a16b8baa5d77 (patch)
tree28fdbe4841ae925a0982c643bbdf8358036b70bb
parentc612009a36477b50ceeecf50839c3764bcd8b03d (diff)
downloadopen-iscsi-30dfe8b18e48fbd7950138feeea2a16b8baa5d77.tar.gz
Uninitialized scalar variable: Using uninitialized value number when calling acl_text_to_number
This was triggering from acl_text_to_number callsites, but the issue to me looks like the unneeded reading of the parameter num. The variable number is always going to be overwritten after this with the output of strtoul.
-rw-r--r--usr/auth.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/usr/auth.c b/usr/auth.c
index 1ffb258..5c819c2 100644
--- a/usr/auth.c
+++ b/usr/auth.c
@@ -259,7 +259,7 @@ static int
acl_text_to_number(const char *text, unsigned long *num)
{
char *end;
- unsigned long number = *num;
+ unsigned long number;
if (text[0] == '0' && (text[1] == 'x' || text[1] == 'X'))
number = strtoul(text + 2, &end, 16);