summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Preparing for version 2.1.02.1.0Lee Duncan2019-11-143-2/+41
| | | | | | | | | | | Updated Changelog and two include files. Note that this bumps the minor version number from 0 to 1, and starts the "patch" version number over again at 0. See https://semver.org for information on semantic versioning.
* Fix version strings in ChangeLogLee Duncan2019-11-121-6/+6
| | | | | Some places list version number with "2.0-NUMBER", and some as "2.0.NUMBER". The latter is correct.
* Merge pull request #178 from open-iscsi/coverity_scanChris Leech2019-11-0417-54/+65
|\ | | | | first batch of changes to address Coverity scan issues
| * Uninitialized scalar value rcChris Leech2019-10-311-1/+1
| |
| * Resource leak: Variable raw going out of scope leaks the storage it points to.Chris Leech2019-10-311-0/+1
| |
| * Out-of-bounds read: Overrunning array of 8 2-byte elementsChris Leech2019-10-311-1/+1
| | | | | | | | | | This loop is executing 16 times (sizeof(struct ipv6_addr)) but then consumes 16-bits at a time (and moves ptr ahead two bytes).
| * Resource leak: Handle variable fd going out of scope leaks the handle.Chris Leech2019-10-311-0/+1
| |
| * fwparam_pcc mulitple resource leaksChris Leech2019-10-311-2/+1
| | | | | | | | | | Resource Leak: Variable mac_file going out of scope leaks the storage it points to. Resource Leak: Handle variable mac_fd going out of scope leaks the storage it points to.
| * iscsistart -b probably never worked with PPC OF parsing?Chris Leech2019-10-311-1/+0
| | | | | | | | | | | | Picked up by Coverity as a resource leak on the allocated context, callers are not expected allocation here (and the function would need to take a **boot_context if they were)
| * iscsi-iname remove unneeded temp bufferChris Leech2019-10-311-6/+1
| |
| * iscsi-iname: verify prefix length is at most 210 charactersChris Leech2019-10-311-0/+9
| | | | | | | | Don't know who might be trying to make really long IQNs ¯\_(ツ)_/¯
| * iscsi-iname: change default IQN prefixChris Leech2019-10-312-2/+2
| | | | | | | | | | We don't actually control the open-iscsi.org domain anymore, so change the prefix to reflect the use of open-iscsi.com
| * Out-of-bounds read: Overrunning array of 4 bytes at byte offset 7 by ↵Chris Leech2019-10-311-2/+2
| | | | | | | | dereferencing pointer
| * Resource leak: Handle variable fd going out of scope leaks the handle.Chris Leech2019-10-311-0/+1
| |
| * Resource leak: Handle variable fd going out of scope leaks the handle.Chris Leech2019-10-311-0/+2
| | | | | | | | | | | | This is comming up in places where the error handling assumes that on a failure there is no file descriptor to worry about. I don't think we need to keep fd around when indicating a connection error.
| * Resource leak: Variable matched_ses going out of scope leaks the storage it ↵Chris Leech2019-10-311-2/+2
| | | | | | | | points to.
| * Resource leak: Variable chap_info going out of scope leaks the storage it ↵Chris Leech2019-10-311-1/+1
| | | | | | | | points to.
| * Resource leak: Handle variable sockfd going out of scope leaks the handle.Chris Leech2019-10-311-1/+3
| |
| * Uninitialized scalar variable: Using uninitialized value number when calling ↵Chris Leech2019-10-311-1/+1
| | | | | | | | | | | | | | | | | | acl_text_to_number This was triggering from acl_text_to_number callsites, but the issue to me looks like the unneeded reading of the parameter num. The variable number is always going to be overwritten after this with the output of strtoul.
| * Uninitialized pointer read: Using uninitialized value ifaces.nextChris Leech2019-10-311-20/+11
| | | | | | | | | | | | | | | | On iscsi_context_new failure in main, this was jumping to out without the ifaces list head being initialized. Run through this file making use of LIST_HEAD for static initialization where possible.
| * Uninitialized scalar variableChris Leech2019-10-311-1/+1
| |
| * Buffer not null terminated: Calling strncpy with a maximum size argument on ↵Chris Leech2019-10-311-3/+3
| | | | | | | | destination array
| * Resource leak: Variable startup_cmd going out of scope leaks the storage it ↵Chris Leech2019-10-311-0/+2
| | | | | | | | point to.
| * Out-of-bounds access: Overrunning array value_listChris Leech2019-10-311-1/+3
| |
| * Buffer not null terminated: Calling strncpy with a maximum size argument on ↵Chris Leech2019-10-311-1/+1
| | | | | | | | destination array might leave the destination string unterminated
| * Out-of-bounds write: Overrunning array link_targetChris Leech2019-10-311-3/+3
| |
| * Resource leak: Variable rec going out of scope leaks the storage it points toChris Leech2019-10-311-1/+2
| |
| * Out-of-bounds-write: Overrunning array link_targetChris Leech2019-10-311-1/+1
| |
| * Resource leak: returning without freeing netdevChris Leech2019-10-311-2/+4
| |
| * fix Coverity scanChris Leech2019-10-231-1/+5
|/ | | | | | | Here I thought I was all carefull about it before pushing the config. I guess a notification_email is required, I was hoping that could all be managed on the repo setting in Coverity. I'll put myself down.
* Merge pull request #176 from open-iscsi/coverity_scanChris Leech2019-10-231-0/+29
|\ | | | | setup Travis-CI builds and Coverity scans
| * setup Travis-CI builds and Coverity scansChris Leech2019-10-231-0/+29
|/ | | | | | | | | | Configure Travis-CI for automated build tests. Hopefully we can extend this to basic functional as well. Also sets up Coverity scanning from the Travis build. Synopsys gives Open Source projects a limited number of free Coverity scans each day, so this is currently configured to only scan when code is pushed to a "coverity_scan" branch.
* Merge pull request #174 from gonzoleeman/fix-session-display-errorLee Duncan2019-10-101-0/+1
|\ | | | | Initialize timeout for printing specific session info.
| * Initialize timeout for printing specific session info.Lee Duncan2019-09-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When printing session info from iscsiadm, the following worked: > # iscsiadm -m session -r N -- print session info for session N > # iscsiadm -m session -s -- print session stats for all sessions But this did not: > # iscsiadm -m session -r N -s -- print session stats for session N Which is the same as the simple "-s" form if there is just one session. To fix this error, initialize the timeout to "none" (-1) when sending our request to iscsi for session stats, as do other requests.
* | Merge pull request #170 from cleech/chap_exChris Leech2019-10-107-538/+126
|\ \ | |/ |/| RFC: CHAP SHA1, SHA3-256 via OpenSSL's libcrypto
| * CHAP SHA-1, SHA-256, SHA3-256 via OpenSSL's libcryptoChris Leech2019-10-107-538/+126
|/ | | | | | | | | | | | | | Extended CHAP authentication modes using newer hash digest functions than MD5. SHA-256 and SHA3-256 should be usable in FIPS-140 environments for some time. These CHAP algorithms have been registered with IANA for this purpose. https://www.iana.org/assignments/ppp-numbers/ppp-numbers.xhtml#ppp-numbers-9 Makes OpenSSL libcrypto use a requirement, replacing the in tree MD5 implementation as well (and removing the unused SHA1 code). Signed-off-by: Chris Leech <cleech@redhat.com>
* Preparing for version 2.0.8782.0.878Lee Duncan2019-09-123-2/+49
| | | | Updated Changelog and two include files.
* Merge pull request #172 from JohnAZoidberg/install-systemdLee Duncan2019-09-041-0/+8
|\ | | | | Add make target to install systemd units
| * Add target to install systemd unitsDaniel Schaefer2019-08-291-0/+8
|/
* Remove redundant Requires= from iscsi.serviceLee Duncan2019-08-151-1/+0
|
* Merge pull request #171 from gonzoleeman/fix-iscsi-iscsid-service-dependencyLee Duncan2019-08-141-0/+1
|\ | | | | The iscsi login/logout service requires iscsid.
| * The iscsi login/logout service requires iscsid.Lee Duncan2019-08-131-0/+1
|/ | | | | | The iscsi.service systemd unit file, which controls iscsi logins and logouts, should be stopped if the iscsid service file is stopped.
* Merge pull request #168 from lxbsz/bzChris Leech2019-07-035-66/+105
|\ | | | | rec update: disable the idbm_lock in read/write when updating the rec
| * rec update: disable the idbm_lock in read/write when updating the recXiubo Li2019-06-185-66/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | The iscsiadm is getting a file lock while writing out records, and updates are a read-modify-write operation and currently only the write is locked. So the parallel requests are reading in the pre-update record and then overwriting each other with the writes. Fixing RHBZ#1624670 Signed-off-by: Xiubo Li <xiubli@redhat.com>
* | Merge pull request #169 from njavali/iscsiuio-bug-fixesLee Duncan2019-07-024-21/+21
|\ \ | |/ |/| iscsiuio bug fix
| * iscsiuio: update version to 0.7.8.6Nilesh Javali2019-06-273-6/+21
| | | | | | | | Signed-off-by: Nilesh Javali <njavali@marvell.com>
| * iscsiuio: allow processing of iscsid requests in DHCP failure conditionNilesh Javali2019-06-271-15/+0
| | | | | | | | | | | | | | | | | | | | | | In the event of DHCP failure, killing of enable_nic_thread did not process any iscsid requests leading to error, iscsistart: Could not broadcast to uIP after 5 tries and login failure to next active path. Do not kill enable_nic_thread and allow further processing of iscsid requests and performing login to next active path. Signed-off-by: Nilesh Javali <njavali@marvell.com>
* | Handle systemd disablement correctly in iscsiuioLee Duncan2019-06-052-1/+12
| | | | | | | | | | | | | | | | | | | | | | Commit c1870ae6dddb7bc2dbdc750df68edbbe1a80763f added systemd support to iscsiuio, but it was not integrated with the autoconf script there, so this commit rectifies that. Now one can build without systemd support, from the top, using: $ make OPTFLAGS="... -DNO_SYSTEMD ... which now works for both iscsid and iscsiuio.
* | Merge pull request #164 from gonzoleeman/make-iscsid-systemd-optionalLee Duncan2019-05-173-0/+13
|\ \ | | | | | | Make iscsid systemd usage optional
| * | Make iscsid systemd usage optionalLee Duncan2019-05-143-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | You can compile without system now by using something like: make OPTFLAGS="-DNO_SYSTEMD ..." NO_SYSTEMD=1 This will skip systemd code for iscsid and iscsiuio.
View Lorry Controller Status