From 467946a945cc0f2432274a66e916959d5a5c3772 Mon Sep 17 00:00:00 2001 From: Lee Duncan Date: Tue, 9 Oct 2018 11:10:42 -0700 Subject: When reopen_max=0 retry reopening forever. Commit b9afe4709900 added a configuration variable for session reconnect called reopen_max that defaults to 32. This changes the behavior of iscsid on startup if it finds any session information left over from previous invocations. Adding the option of setting the retry count to zero to imply previous behavior allows those that are counting on this behavior to continue. But, make no mistake, it is recommended not to retry forever, as it leaves iscsid stuck in "iscsi_sysfs_for_each_session()" in iscsid.c:main(), so iscsid never fully gets up and running. --- etc/iscsid.conf | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'etc') diff --git a/etc/iscsid.conf b/etc/iscsid.conf index dec3857..00ce546 100644 --- a/etc/iscsid.conf +++ b/etc/iscsid.conf @@ -294,9 +294,10 @@ discovery.sendtargets.iscsi.MaxRecvDataSegmentLength = 32768 node.session.nr_sessions = 1 # When iscsid starts up it recovers existing sesssions, if possible. -# If the target has gone away when this occurs, this value -# limits the number of retries to re-login. -# Retries are done every 2 seconds. +# If the target for a session has gone away when this occurs, this +# configuration value limits the number of retries to re-login, which +# are done every 2 seconds. A value of 0 implies to retry forever, +# which is not recommended. node.session.reopen_max = 32 #************ -- cgit v1.2.1