From 598c3a5e3885080ced0d7c40fde00f1d5cdbb32b Mon Sep 17 00:00:00 2001 From: Damien Miller Date: Fri, 26 Jun 2020 16:07:12 +1000 Subject: document a PAM spec problem in a frustrated comment --- auth-pam.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'auth-pam.c') diff --git a/auth-pam.c b/auth-pam.c index 5a3ba09b..83238215 100644 --- a/auth-pam.c +++ b/auth-pam.c @@ -375,7 +375,11 @@ import_environments(struct sshbuf *b) error("PAM: pam_putenv: %s", pam_strerror(sshpam_handle, r)); } - /* XXX leak env? */ + /* + * XXX this possibly leaks env because it is not documented + * what pam_putenv() does with it. Does it copy it? Does it + * take ownweship? We don't know, so it's safest just to leak. + */ } #endif } -- cgit v1.2.1