diff options
| author | Geoff Thorpe <geoff@openssl.org> | 2003-06-06 17:54:22 +0000 |
|---|---|---|
| committer | Geoff Thorpe <geoff@openssl.org> | 2003-06-06 17:54:22 +0000 |
| commit | fd509d6da52e8cb34dc2a2cdc122fb20227cdee8 (patch) | |
| tree | 557e05c3a9e91b0150d9ad8a79e544a10e72fea5 | |
| parent | 7fd79b985892988927cb0c8fb97a23dc68ec6b28 (diff) | |
| download | openssl-new-fd509d6da52e8cb34dc2a2cdc122fb20227cdee8.tar.gz | |
This memset() in the ubsec ENGINE is a bug. Zeroing out the result array
should not be necessary in any case, but more importantly the result and
input BIGNUMs could be the same, in which case this is clearly a problem.
Submitted by: Jonathan Hersch
Reviewed by: Joe Orton
Approved by: Geoff Thorpe
| -rw-r--r-- | crypto/engine/hw_ubsec.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/crypto/engine/hw_ubsec.c b/crypto/engine/hw_ubsec.c index e649e6391d..e273839b07 100644 --- a/crypto/engine/hw_ubsec.c +++ b/crypto/engine/hw_ubsec.c @@ -513,7 +513,6 @@ static int ubsec_mod_exp(BIGNUM *r, BIGNUM *a, const BIGNUM *p, ENGINEerr(ENGINE_F_UBSEC_MOD_EXP, ENGINE_R_BN_EXPAND_FAIL); goto err; } - memset(r->d, 0, BN_num_bytes(m)); if ((fd = p_UBSEC_ubsec_open(UBSEC_KEY_DEVICE_NAME)) <= 0) { |