diff options
| author | DK <dmitrykos@neutroncode.com> | 2016-11-13 14:48:15 +0200 |
|---|---|---|
| committer | Rich Salz <rsalz@openssl.org> | 2016-11-13 15:43:05 -0500 |
| commit | 349d1cfddcfa33d352240582a3803f2eba39d9a0 (patch) | |
| tree | 8e0aeb46efc1331208bcd5f14df216bd0b6a008e | |
| parent | af5883fec95eb8c79c379b09885440a0d88b2d38 (diff) | |
| download | openssl-new-349d1cfddcfa33d352240582a3803f2eba39d9a0.tar.gz | |
Fixed deadlock in CRYPTO_THREAD_run_once for Windows
Fixed deadlock in CRYPTO_THREAD_run_once() if call to init() is causing
a recursive call to CRYPTO_THREAD_run_once() again that is causing a hot
deadloop inside do { } while (result == ONCE_ININIT); section.
CLA: trivial
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1913)
| -rw-r--r-- | crypto/threads_win.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/threads_win.c b/crypto/threads_win.c index 4e0de908ee..5347c9e46b 100644 --- a/crypto/threads_win.c +++ b/crypto/threads_win.c @@ -78,8 +78,8 @@ int CRYPTO_THREAD_run_once(CRYPTO_ONCE *once, void (*init)(void)) do { result = InterlockedCompareExchange(lock, ONCE_ININIT, ONCE_UNINITED); if (result == ONCE_UNINITED) { - init(); *lock = ONCE_DONE; + init(); return 1; } } while (result == ONCE_ININIT); |