diff options
| author | Zuul <zuul@review.opendev.org> | 2022-11-23 06:34:34 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2022-11-23 06:34:34 +0000 |
| commit | 0483a533216c85314a0f3102d6600d12647f0c11 (patch) | |
| tree | 7c7b76c15677bb8b2c5193f5cd1c84390f5eaa08 | |
| parent | 4ecd1089f15c10f05b8fb29128ac526ff0292465 (diff) | |
| parent | c3cdc8f2d6063648d42c256f400ea836b5923a7b (diff) | |
| download | designate-0483a533216c85314a0f3102d6600d12647f0c11.tar.gz | |
Merge "Fix configuration leak in unit tests"
| -rw-r--r-- | designate/tests/unit/agent/backends/test_bind9.py | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/designate/tests/unit/agent/backends/test_bind9.py b/designate/tests/unit/agent/backends/test_bind9.py index f080b565..40f0ea9e 100644 --- a/designate/tests/unit/agent/backends/test_bind9.py +++ b/designate/tests/unit/agent/backends/test_bind9.py @@ -95,12 +95,15 @@ class Bind9AgentBackendTestCase(designate.tests.TestCase): @mock.patch('designate.utils.execute') @mock.patch.object(dns.zone.Zone, 'to_file') def test_sync_zone(self, mock_to_file, mock_execute): + FAKE_STATE_PATH = '/tmp/fake/state/path' + self.CONF.set_override('state_path', FAKE_STATE_PATH) + zone = backends.create_dnspy_zone('example.org') self.backend._sync_zone(zone) mock_to_file.assert_called_once_with( - '/var/lib/designate/zones/example.org.zone', relativize=False + FAKE_STATE_PATH + '/zones/example.org.zone', relativize=False ) mock_execute.assert_called_once_with( @@ -110,16 +113,19 @@ class Bind9AgentBackendTestCase(designate.tests.TestCase): @mock.patch('designate.utils.execute') @mock.patch.object(dns.zone.Zone, 'to_file') def test_sync_zone_with_new_zone(self, mock_to_file, mock_execute): + FAKE_STATE_PATH = '/tmp/fake/state/path' + self.CONF.set_override('state_path', FAKE_STATE_PATH) + zone = backends.create_dnspy_zone('example.org') self.backend._sync_zone(zone, new_zone_flag=True) mock_to_file.assert_called_once_with( - '/var/lib/designate/zones/example.org.zone', relativize=False + FAKE_STATE_PATH + '/zones/example.org.zone', relativize=False ) mock_execute.assert_called_once_with( 'rndc', '-s', '127.0.0.1', '-p', '953', 'addzone', 'example.org { type master; ' - 'file "/var/lib/designate/zones/example.org.zone"; };' + 'file "' + FAKE_STATE_PATH + '/zones/example.org.zone"; };' ) |