diff options
author | Zuul <zuul@review.opendev.org> | 2022-05-13 00:35:11 +0000 |
---|---|---|
committer | Gerrit Code Review <review@openstack.org> | 2022-05-13 00:35:11 +0000 |
commit | 51331758a3bc8800802c0e18c6ca0f9d262fc698 (patch) | |
tree | 05165251237cdec3a904c3d05c8e11e7a3706958 | |
parent | 5b40d3d908ca674a8bc112397f008ebce0e0661c (diff) | |
parent | a8e74f4fb35b267132a63437c05c7d8750dae735 (diff) | |
download | designate-51331758a3bc8800802c0e18c6ca0f9d262fc698.tar.gz |
Merge "Fix set-quotas for non-project scoped tokens" into stable/yoga
-rw-r--r-- | designate/api/v2/controllers/quotas.py | 10 | ||||
-rw-r--r-- | releasenotes/notes/Require-all-projects-for-set-quotas-with-non-project-scoped-tokens-ffe3082db3dbb55b.yaml | 6 |
2 files changed, 16 insertions, 0 deletions
diff --git a/designate/api/v2/controllers/quotas.py b/designate/api/v2/controllers/quotas.py index 7d0a74de..9fbc6d3a 100644 --- a/designate/api/v2/controllers/quotas.py +++ b/designate/api/v2/controllers/quotas.py @@ -19,6 +19,7 @@ import pecan from designate.api.v2.controllers import rest from designate.common import keystone +from designate import exceptions from designate.objects.adapters import DesignateAdapter from designate.objects import QuotaList @@ -63,6 +64,15 @@ class QuotasController(rest.RestController): quotas = DesignateAdapter.parse('API_v2', body, QuotaList()) + # The get_quotas lookup will always return the default quotas + # if the context does not have a project_id (system scoped token) and + # the all_tenants boolean is false. Let's require all_tenants for + # contexts with no project ID. + if context.project_id is None and not context.all_tenants: + raise exceptions.MissingProjectID( + "The all-projects flag must be used when using non-project " + "scoped tokens.") + for quota in quotas: self.central_api.set_quota(context, tenant_id, quota.resource, quota.hard_limit) diff --git a/releasenotes/notes/Require-all-projects-for-set-quotas-with-non-project-scoped-tokens-ffe3082db3dbb55b.yaml b/releasenotes/notes/Require-all-projects-for-set-quotas-with-non-project-scoped-tokens-ffe3082db3dbb55b.yaml new file mode 100644 index 00000000..eaf17979 --- /dev/null +++ b/releasenotes/notes/Require-all-projects-for-set-quotas-with-non-project-scoped-tokens-ffe3082db3dbb55b.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + Fixed an issue where set-quotas will always return the default quotas if + it was called with a non-project scoped token and the all-projects flag + was not set. |