summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Update zones masters using pool target masters.stein-eolstable/steinJorge Niedbalski2021-04-234-0/+135
| | | | | | | | | | | | | | | | | | | | | This change enforces the update of the zone masters for all zones that belongs to a particular pool, using the pool's defined target(s) masters and forcing a update_zone call. This change also, moves the backend base class update_zone method as an abstract method, allowing to each backend implementation to create its own update logic. For the case of bind9 its extended to allow running a rndc modzone with the new given masters for the zone fixing the behavior exposed on LP: #1879798. Fixes-Bug: #1879798 Change-Id: I9dddd4130a0cbb29311eeb52e077e216c8c03f3a Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com> Signed-off-by: Nicolas Bock <nicolas.bock@canonical.com> (cherry picked from commit 3756fc51e71aaf0ba7cfb9155ca5d1de26ab78bc)
* Adding distributed locking to centralErik Olof Gunnar Andersson2021-02-255-2/+194
| | | | | | | | | | | | | The current locking implementation is limited to the running process. This introduces distributed locking that will help prevent race conditions when there are many instances of designate-central running. Closes-Bug: #1871332 Change-Id: I98f7f80ce365cdee33528f9964c03274f62a795a Signed-off-by: Nicolas Bock <nicolas.bock@canonical.com> (cherry picked from commit f6090d885c8ebe00a89307a1e2f5621de75dcda8)
* Fix pdns4 devstack plugin and drop lower-constraintsNicolas Bock2021-02-224-199/+3
| | | | | | | | | | | | | | | | | | | | | This change drops the lower-constraints test. (cherry picked from commit d08dd621c988fe13b9844c5c44e143907aa74d0c) And fixes the pdns4 devstack plugin. We no longer need to deal with xenial or older distro versions, so we can assume that we can always install pdns4 from the distro directly and don't need the distro version check any longer. Drop a config option that was removed in pdns 4.2.x. Use mysql credentials correctly. (cherry picked from commit 6f17fe10bb37d71944e16a422606ccf0f78c6771) Change-Id: I90af3a092296f943509833608f25522b6f8e9ab6 Depends-On: I36799ee9d4db20104377e2772c86229b8083448d Signed-off-by: Nicolas Bock <nicolas.bock@canonical.com>
* Merge "Update vagrant config" into stable/steinZuul2021-02-032-2/+23
|\
| * Update vagrant configGraham Hayes2020-01-162-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | * Move to bionic * Add openSUSE Leap 15 * * Update Bind devstack backend plugin to work on Leap * Remove port mapping * Rmove the .gitconfig copy into the VM Change-Id: I99d228f850e03045febf196f12eef5927f7605b9 Signed-off-by: Graham Hayes <gr@ham.ie> (cherry picked from commit 3734f2a13f094fe86c354c87e102543f9b1fa006)
* | [stable-only] Cap bandit and fix lowwer-constraintsElod Illes2021-01-154-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bandit 1.6.3 [1] release has dropped support for py2 [2] but the release is faulty and pip still picks it up for py2 [3][4], so cap to 1.6.2 when using py2. With the new pip dependency resolver (introduced in pip 20.3) the lower-constraints job started to fail. Problem is here with the 'install_command' in tox.ini, which uses both the upper- and lower- constraints files, causing the job to fail. This patch adds separate install_command without the upper constraints, so that only the lower-constraints.txt is used. [1] https://github.com/PyCQA/bandit/releases/tag/1.6.3 [2] https://github.com/PyCQA/bandit/pull/615 [3] https://github.com/PyCQA/bandit/issues/663 [4] https://github.com/PyCQA/bandit/issues/665 Change-Id: If8738f5005e60cf46ed93edbefa272bc2611b53f
* | Make greande jobs n-v for EM and oldest stablestein-em8.0.1Ghanshyam Mann2020-06-251-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in ML thread[1], we are going to make grenade jobs as non voting for all EM stable and oldest stable. grenade jobs are failing not and it might take time to fix those if we are able to fix. Once it jobs are working depends on project team, they can bring them back to voting or keep non-voting. If those jobs are failing consistently and no one is fixing them then removing those n-v jobs in future also fine. Also pin designate-tempest-plugin to the latest tag that still supports python2. [1] http://lists.openstack.org/pipermail/openstack-discuss/2020-June/015499.html StableOnly Change-Id: I8eb1a244ac9d79c9915c222af5afd298bdb04997
* | Use Tempest 'all' tox envGhanshyam2020-02-094-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tempest recently moved tox default to py3 including all-plugin env. -https://review.opendev.org/#/c/703011/ This will fail the py2 jobs which are using all-plugin tox env. Because tox all-plugin env var enable the sitepackages=True. Py2 jobs install the tempest plugins on py2 and all-plugin tox try to find the installed plugins on py3 which cause no test to run and fail the job. tox all-plugin has been deprecated since long and not supposed to use for plugins who already in migrated to separate repo in queens cycle. Enable designate-tempest-plugin and using tox 'all' env to fix the issue. Change-Id: Ib1a2be90c0b3dbacc6daf52f0fc6f326ab47fc98 Closes-Bug: 1862240
* | Use stable branch scenario jobDr. Jens Harbott2020-01-201-1/+1
|/ | | | | | | We need to use neutron-tempest-plugin-designate-scenario from the matching stable branch. Change-Id: If57d79e0ac70189f0e387830e5a2473eb472eb12
* fix get the name servers for a zone not validate zone_idzhouhenglc2019-10-101-0/+2
| | | | | | | | now the api of get /v2/zones/{zone_id}/nameservers not validate zone_id, if set zone_id contain spaces, will trigger DBError and return 500. Change-Id: Ia3e07c42dc548207aa7ff9efcc35a215c9660e54 (cherry picked from commit 0ba52bfb62cb64992a06b64c44f3e6a9dcadc193)
* Fixing 404 linkAlexandra Settle2019-08-131-16/+1
| | | | | | | | | Did not specify between 2.8 and 2.7, went with generic documentation link for ease of future use. Change-Id: I43c5f71c9b335055ee8691566eb662fdb27eeba8 backport: stein rocky (cherry picked from commit c53b1684a81ad1ee5a76967930b853de89fc907a)
* Improve log message for better understandingTakahito Hirose2019-07-301-3/+4
| | | | | | | | | | | | Sometimes designate central could not update the Pool configuration. Very limited information is logged into the designate central logs through which we can not find the root cause of failure. This patch adds some more information into the log for better understanding. Change-Id: I26d36c15406436bb3b733d44c490a14e5ece39a6 Closes-Bug: 1835407 (cherry picked from commit e70af61dac1794ecd858c875c44d6b2ab0d59206)
* Clean up zone lockingErik Olof Gunnar Andersson2019-06-191-18/+13
| | | | | | | | | | | | | | | Updated the decorator to log something more appropriate when locking during zone creation. The existing implementation would log 'zone-None', this changes it to 'create-new-zone'. We also add a try/finally catch statement to make sure the lock is always released when done. * Changed lock name to be more appropriate when creating new zones. * Implement try/finally pattern to make sure lock is always released. Change-Id: I0c7b45d3125ff1e007d44064a7653c1b2b07c770 (cherry picked from commit 6f13191a6c939d4f38955f8cb0a67f305b463bd1)
* Merge "Allow pdns4 backend to select tsigkey" into stable/steinZuul2019-05-204-0/+42
|\
| * Allow pdns4 backend to select tsigkeyGraham Hayes2019-03-224-0/+42
| | | | | | | | | | | | | | | | | | Allow a new config item in pools.yaml to set the pdns tsigkey to use for AFXR queries. Change-Id: Ibb4fb604957286c6edfe85f72321f199eb3167a7 Closes-Bug: #1820089 Signed-off-by: Graham Hayes <gr@ham.ie>
* | Merge "Added missing service_statuses metadata" into stable/steinZuul2019-05-201-0/+2
|\ \
| * | Added missing service_statuses metadataErik Olof Gunnar Andersson2019-04-021-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to I307a8f7dd8b8a83effa447a846db3288efa32dba Adding the same constraint to the sql metadata. Change-Id: Iadb2660d306c8920c2202ae6bffec2ef621af36c
* | | Clean fix for bandit exclusions changeAdam Harwell2019-05-141-1/+1
| | | | | | | | | | | | | | | | | | Don't mangle requirements, just fix the glob. Change-Id: I4b57336a103c75df877ff65e645b3b05b3c79a49
* | | Merge "Fix DBDeadLock error resulting into 500" into stable/steinZuul2019-05-082-1/+27
|\ \ \
| * | | Fix DBDeadLock error resulting into 500Takahito Hirose2019-04-082-1/+27
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When user requests the record registration request continuously, sometimes designate hits DBDeadLock resuting into 500 InternalServerError. We get below error: 2019-02-21 21:30:39.925 49752 ERROR designate.api.middleware RemoteError: Remote error: DBDeadlock (pymysql.err.InternalError) (1213, u'Deadlock found when trying to get lock; try restarting transaction') [SQL: u'UPDATE records SET version=(records.version + %(version_1)s), updated_at=%(updated_at)s, data=%(data)s, hash=%(hash)s, status=%(status)s, action=%(action)s, serial=%(serial)s WHERE records.id = %(id_1)s'] [parameters: {'status': 'PENDING', 'hash': '39795ee18c6e3c9ad1c0190c6a3d8d4f', 'updated_at': datetime.datetime(2019, 2, 21, 12, 30, 39, 909846), u'version_1': 1, u'id_1': '7a655eeda4d446cdaa81caf19ab55fcc', 'action': 'UPDATE', 'serial': 1550752338, 'data': u'ns2.example.jp. domain.example.com. 1550752338 3552 600 86400 3600'}] In the process of record registeration, designate first tried to update the reocrd and then update the zone status. Updating the zone_status and registering the record process[1] and after synced update record_status and zone_status process[2] are in reverse order. So If user request the registering record many time and same time, Designate will get the DBDeadLock, when these processes run the same time. We observed that changing the order of the operations solves this issue. [1] https://github.com/openstack/designate/blob/master/designate/central/service.py#L1292-L1320 [2] https://github.com/openstack/designate/blob/master/designate/central/service.py#L2310-L2322 1. transaction [1]-1 updating zone status process <- run ---> table_name-zone 2. transaction [2]-1 updating record status process <- run ---> table_name-record 3. transaction [1]-2 registering record process <- run and wait ---> table_name-record 4. transaction [2]-2 updating zone process <-deadlock! ---> table_name-zone Change-Id: Icd6e690ac84a2fe0db0f4a8a513de47f7916f5ea Related-Bug: #1785459 (cherry picked from commit f828654a3d40476cac7eb24a09a36e9978c2d708)
* | | OpenDev Migration PatchOpenDev Sysadmins2019-04-195-19/+19
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
* | Replace openstack.org git:// URLs with https://Ian Wienand2019-03-244-6/+6
|/ | | | | | | | | | | | | | | | | This is a mechanically generated change to replace openstack.org git:// URLs with https:// equivalents. This is in aid of a planned future move of the git hosting infrastructure to a self-hosted instance of gitea (https://gitea.io), which does not support the git wire protocol at this stage. This update should result in no functional change. For more information see the thread at http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html Change-Id: I8c023b811f781c0e3055c85dda4004a369853df8
* Update UPPER_CONSTRAINTS_FILE for stable/steinOpenStack Release Bot2019-03-211-3/+3
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/stein branch, tests will continue to use the upper-constraints list on master. Change-Id: I542a349c1f72acdff8b3ea5f3c5a4e4043cb0c1a
* Update .gitreview for stable/steinOpenStack Release Bot2019-03-211-0/+1
| | | | Change-Id: Ic401cbc5f4cf6871277868abe34bbf0da7fe8b97
* Allow non localhost connections to pdns api8.0.0.0rc18.0.0Graham Hayes2019-03-131-0/+1
| | | | | | | | | | | | | PowerDNS 4.1.0 changed the default value of `webserver-allow-from` from `0.0.0.0/0` to `127.0.0.1` which blocked designate-worker and pool-manager from connecting to the API [1] Updated the allowed list of IPs to include the service host. 1 - https://doc.powerdns.com/authoritative/settings.html#setting-webserver-allow-from Change-Id: I655ba3264507ba0f4fc30ba8a7c3b35d216a9acd Signed-off-by: Graham Hayes <gr@ham.ie>
* Merge "Use oslo_serialization instead of the json module directly"Zuul2019-03-126-19/+21
|\
| * Use oslo_serialization instead of the json module directlyErik Olof Gunnar Andersson2019-01-186-19/+21
| | | | | | | | | | | | | | | | | | * Always use oslo jsonutils. * Consistently import jsonutils as-is. * Use dump_as_bytes instead of dumps. https://wiki.openstack.org/wiki/Python3#Serialization:_base64.2C_JSON.2C_etc. Change-Id: Ia58b2a6a8740fa7f0796b05e14e812d5240c7acc
* | Modernized RPC impl and fixed service testsErik Olof Gunnar Andersson2019-03-096-71/+85
| | | | | | | | | | | | | | | | - Fixed mdns service tests. - Properly clean up NOTIFICATION_TRANSPORT. - Modernized RPC implementation. Change-Id: Ic577388ce49cbe49ce16d81c0fa5a5b2506cc07f
* | Merge "Set worker model to be the default"Zuul2019-03-084-43/+155
|\ \
| * | Set worker model to be the defaultGraham Hayes2019-03-064-43/+155
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We will create new grenade gate that ensure upgrading procedures from pool-manager-->worker and pool-manager-->pool-manager by setting $DESIGNATE_ENABLED_WORKER_MODEL variable. Co-Authored-By: Hieu LE <hieulq@vn.fujitsu.com> Co-Authored-By: Nguyen Van Trung <trungnv@vn.fujitsu.com> Change-Id: I5e220738a18422a28a3384db1ab671ea111ac9b2 Signed-off-by: Graham Hayes <gr@ham.ie>
* | | Merge "Make unit-testing more robust"Zuul2019-03-074-77/+53
|\ \ \
| * | | Make unit-testing more robustErik Olof Gunnar Andersson2019-02-194-77/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Cleaned up producer tests. * Fixed a mutable argument. * Removed unused rpc timeout override for devstack. * Set retry interval to 0 in pool manager tests. Change-Id: I4105d192e9de8b95c792969c7432cf6d5d9fb9fb
* | | | Merge "Setup designate with default zones quota"Zuul2019-03-071-1/+1
|\ \ \ \ | |_|/ / |/| | |
| * | | Setup designate with default zones quotaPavlo Shchelokovskyy2019-02-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we need to test with default values to ensure validity of designate-tempest-plugin for deployments with default config values. Change-Id: Ifbcf8614fdcab5a97139234025ed0decf2e91f8e Depends-On: https://review.openstack.org/638412/
* | | | Add devstack VENV build supporthamzah alqtaishat2019-02-253-7/+16
|/ / / | | | | | | | | | Change-Id: I7bccb19b9d629ccddac1dc2808f8a8b89ed5c7a7
* | | Merge "Drop python3.5 job after switching to Bionic"Zuul2019-02-201-8/+1
|\ \ \ | |/ / |/| |
| * | Drop python3.5 job after switching to BionicJens Harbott2018-12-151-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Devstack switched to running on Bionic by default, so our default job has python3.6 available and we drop the py35 variant. Change-Id: I9207378637540046b0e5cb24268fda6ea6396079 Depends-On: https://review.openstack.org/610977 Depends-On: https://review.openstack.org/618169
* | | Merge "nit: remove downgrade methods and add release note"Zuul2019-01-183-30/+6
|\ \ \
| * | | nit: remove downgrade methods and add release noteGraham Hayes2019-01-173-30/+6
| | |/ | |/| | | | | | | Change-Id: I381a15e233683e2a37c90a4cb443774479265f69
* | | Merge "Fix the child search logic during zone deletion."Zuul2019-01-171-1/+3
|\ \ \ | |/ / |/| |
| * | Fix the child search logic during zone deletion.Dmitry Galkin2019-01-041-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch uses elevated context to look up the child zones when a (parent) zone is deleted. If policy allows deleting a zone with non-admin role - the search will not find the child zones in another tenant and therefore parent zone gets deleted. Change-Id: Id1a8228f287a8f8e02462017cd062607ff4bebf8 Closes-Bug: 1809906
* | | Merge "Add designate-status command for upgrade checks"Zuul2019-01-049-0/+232
|\ \ \ | |/ / |/| |
| * | Add designate-status command for upgrade checksBen Nemec2018-12-079-0/+232
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This checks for duplicate entries in the service_statuses table which will be an error after change I307a8f7dd8b8a83effa447a846db3288efa32dba. Related-Bug: 1768824 Story: 2003657 Task: 26127 Change-Id: Ie0350b034f0eb03749138aadd0951d30073214c0 Co-authored-by: Doug Hellmann <doug@doughellmann.com>
* | | Merge "Fix test failures for new dnspython module"Zuul2019-01-042-12/+20
|\ \ \ | | |/ | |/|
| * | Fix test failures for new dnspython moduleJens Harbott2018-12-142-12/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | Release dnspython==1.16.0 has fixed a bug which didn't apply the zone default TTL to records without an explicit TTL. Since there doesn't seem to be a way to accomodate both the old and new behaviour in our tests, set an explicit TTL for all our sample records. Change-Id: I2d4cd55b69da696a9d4b25213969248a4c2e6119
* | | Merge "Add blueprint in README.rst"Zuul2018-12-141-0/+1
|\ \ \
| * | | Add blueprint in README.rsttaoguo2018-11-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | add blueprint int readme.rst Change-Id: I0fb02b5af9212fa31d78c028992c7b971d0792c8
* | | | Imported Translations from ZanataOpenStack Proposal Bot2018-12-051-4/+4
| |/ / |/| | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I63154423204632d0f0d6b756ad9d3cc7a90a894f
* | | Change openstack-dev to openstack-discussZhongShengping2018-12-041-1/+1
| | | | | | | | | | | | | | | | | | Mailinglists have been updated. Openstack-discuss replaces openstack-dev. Change-Id: I429898c6f3a65a3287aa33a401911f3d1dcfc65a
* | | Fix the record_types for CAA and NAPTRRocky2018-11-271-2/+2
| | | | | | | | | | | | | | | | | | Co-Authored-By: Jake Yip <jake.yip@unimelb.edu.au> Change-Id: Ie064cb1212e960700ef24fa3ae7bde18e56eeedc