summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Switch CentOS jobs over to CentOS 9 Stream" into stable/wallabystable/wallabyZuul2023-05-021-4/+9
|\
| * Switch CentOS jobs over to CentOS 9 StreamMichael Johnson2023-02-271-4/+11
| | | | | | | | | | | | | | | | | | | | | | Since Devstack is dropping CentOS 8 Stream[1], we need to move our jobs over to CentOS 9 Stream. Now that there is a "devstack-single-node-centos-9-stream" nodeset we can remove our local CentOS 9 Stream nodeset. [1] http://lists.openstack.org/pipermail/openstack-discuss/2022-April/028321.html Change-Id: I1c8dfec7bd2b5f80b12d7229e47ef8ff70bd283b (cherry picked from commit 970175de37e7d14835c1027f9c889142ba3df7bc)
* | Merge "Use ids when removing sink managed records" into stable/wallabyZuul2023-04-203-13/+111
|\ \
| * | Use ids when removing sink managed recordsErik Olof Gunnar Andersson2023-04-143-13/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | If the record status changes during the removal process, the current implementation will fail. Closes-Bug: 2015762 Change-Id: Iebe609e5f365d03e99f2a4580671175b4642763c (cherry picked from commit 2cb42ac9f6e5273ad64e697919b62e029466078f)
* | | Merge "Fix FIPS job - nslookup_target" into stable/wallabyZuul2023-04-201-0/+2
|\ \ \
| * | | Fix FIPS job - nslookup_targetMichael Johnson2022-08-021-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch sets a zuul variable "nslookup_target" to 'opendev.org' to fix the FIPS jobs due to a new zuul-job change[1]. [1] https://review.opendev.org/c/zuul/zuul-jobs/+/844704 Change-Id: Ic6b3a3c6d2f5b648f00813191c30d03132e31503 (cherry picked from commit 9ac645806613710ab03da7e1841537d1d28a6e8f)
* | | | Merge "Use ids when removing ptr records" into stable/wallabyZuul2023-04-201-9/+17
|\ \ \ \ | |_|/ / |/| | |
| * | | Use ids when removing ptr recordsErik Olof Gunnar Andersson2023-04-131-9/+17
| | |/ | |/| | | | | | | | | | | | | | | | | | | If the record status changes during the removal process, the current implementation will fail. Change-Id: I02b5d7499440154160c89ed63a2f70652fe72145 (cherry picked from commit b3161ece234b5e2ee7658060aaa936af625bef38)
* | | Removed unsupported test B309 from banditErik Olof Gunnar Andersson2023-04-131-1/+1
|/ / | | | | | | | | | | | | | | B309 was removed with this patch and breaks the CI. https://github.com/PyCQA/bandit/commit/130a467434ff6b8f9bbd83100e409bc1fcb6f407 Change-Id: I15864a76c8913f151154e2398ae86aea71883498 (cherry picked from commit 758956d5b9321c72d63cbf3d8a1987d5dc6e6bb3)
* | Pin designate-tempest-plugin for stable/wallaby jobsGhanshyam Mann2023-01-271-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | As stable/wallaby are in EM phase, and QA team pinning Tempest 29.0.0 for stable/wallaby (depends-on). To have compatible designate-tempest-plugin version with Tempest 29.0.0 for stable/wallaby testing, we need to use designate-tempest-plugin 0.16.0 version. Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/871793 Change-Id: Ifce2d7382704a3c87c310fbc733b1ecd0d872a00
* | CI: Move queue configuration into project-templateDr. Jens Harbott2022-10-231-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | With this it can be reused by the other designate repos and we can reduce the replication everywhere. Conflicts: .zuul.yaml Change-Id: I1fe73145e4a4699939244bc857600efa264f2340 (cherry picked from commit c907cfa1e68249c21e8cad9f58ff3dc3d9cea6df) (cherry picked from commit 96d788c6733b3e3f78fab96ebc5e0aae2203842a) (cherry picked from commit 5f921b78896e68e473ab0c139d534f02a4105840) (cherry picked from commit 019b1ae9cb54f06f7b754024687e9f0fdfad9534)
* | Merge "Check zone_id in notification_handler to avoid UUID format issue." ↵Zuul2022-09-162-0/+11
|\ \ | | | | | | | | | into stable/wallaby
| * | Check zone_id in notification_handler to avoid UUID format issue.junbo2022-09-142-0/+11
| | | | | | | | | | | | | | | | | | Closes-Bug: #1977826 Change-Id: I81a4883fd48653c3b0d60ac07210fc0de55ac12a (cherry picked from commit 42dac06e0cdef9eccabc7085d0ff9da47563b318)
* | | Fix Redis connection over TLSMichael Johnson2022-09-141-0/+7
|/ / | | | | | | | | | | | | | | | | | | When Designate is configured to use Redis for coordination over a TLS connection, it will fail to connect with "ssl.SSLError: ('timed out',)". This is caused by eventlet raising ssl.SSLError instead of the expected socket timeout the core libraries return. This patch monkey-patches eventlet to return the proper exception. Closes-Bug: #1989020 Change-Id: I5bd1c10d863212683752e05bb450e6f531ff7e72 (cherry picked from commit 93dee6a3ff44fb7470b3008e8fbbaf99822bbe82)
* | Fix designate-manage pool update MissingProjectIDMichael Johnson2022-08-182-2/+6
|/ | | | | | | | | | | | | | This patch fixes a bug where adding an additional pool to designate using the "designate-manage pool update" command may fail with an exception: designate.exceptions.MissingProjectID: A project ID must be specified when not using a project scoped token. There was an extra check added as part of the scoped token work that a project ID must be provided when creating pools. This was incorrect as pools are still valid with a None project ID as they are a system resource and not tied to a specific project. This patch removes that check, but retains the RBAC check for and "admin" token. Closes-Bug: #1986733 Change-Id: I7345d7ef505420767209ba037e3c8930a282d03f (cherry picked from commit a03c4657c2bf957fef035807ef7df732f7a1c994)
* Minmum TTL value is zerodkehn2022-07-132-17/+41
| | | | | | | | | | | According to IETF https://tools.ietf.org/html/rfc2181#section-8 the definition of the ttl value is unsigned and can have a minimum value of 0. This path changes the minimum value of 1 to allow for 0 in recordset creats and updates. Unit test have also been modified accordingly. Closes-Bug: #1926429 Change-Id: I9b08e25a007bea598442da377dc227538f6e35f7
* Fix misleading release note for RBAC changes.wallaby-em12.1.0Michael Johnson2022-06-071-2/+2
| | | | | | | | Due to parallel development paths, the release note added for the fixes to the secure-RBAC patches implied it was adding a new feature when in fact the feature already existed. Change-Id: Ia9a904403a2336cc9cd4645d918fc0ff64d5e871
* Update zuul queue configurationMichael Johnson2022-06-071-4/+2
| | | | | | | | | Zuul is changing how queues are declared[1]. This patch updates Designate for the new way to define the queue. [1] https://lists.zuul-ci.org/pipermail/zuul-discuss/2022-May/001801.html Change-Id: I94324104a7ed89e757d48bb250d8b1132026ce46 (cherry picked from commit fe9fb45c21a7be2f88600e1f29fd37f56244cc1a)
* Merge "Minimum TTL value allowed is zero" into stable/wallabyZuul2022-06-064-7/+15
|\
| * Minimum TTL value allowed is zerodekehn2022-06-014-7/+15
| | | | | | | | | | | | | | | | | | | | | | According to ITEF https://tools.ietf.org/html/rfc2181#section-8 the definition of the ttl value is unsigned integer and can have a minimum value of 0. This patch changes the minimum value of 1 to allow for 0. Unit test have also been modified accordingly. Closes-Bug: #1926429 Change-Id: I7876b4c1e2c800b654ca750211ee2e58f3ea4309 (cherry picked from commit 6ac659d241c65c245d8a090768ac7559c32a13f1)
* | Merge "Clarifies the zone import error message" into stable/wallabyZuul2022-06-062-0/+112
|\ \
| * | Clarifies the zone import error messagedekehn2022-06-042-0/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch defines the situation where the import_zone exception handler produces the message 'An undefined error occurred' to the exception during the zone import where an underlying exception occurred from the rpc dispatcher at the same time as a duplicate zone exception. Kiall Mac Innes explains this in https://opendev.org/openstack/designate/commit/2c9460505d07d0e46765a552b637e5a3296b667b the problem here is in the way the _import_zone was written where https://github.com/openstack/designate/commit/9b809a11b3068552274340606eb76d2217411b85 was written with threading.local, so it only works if it stays within the same thread. Since _import_zone is created on a separate thread, the necessity to add the decorator @rpc_expected_exceptions() at the top. Closes-bug: #1950118 Closes-bug: #1964323 Change-Id: If7d50cbd4fa0ce86e0ddf03068da36acd7d72cb4 (cherry picked from commit d705c5d6b861f319096afdd3ad50a2100651b064)
* | | Merge "Checks for invalid denylist regex patterns" into stable/wallabyZuul2022-06-044-2/+85
|\ \ \ | |/ / |/| |
| * | Checks for invalid denylist regex patternsdekehn2022-06-024-2/+85
| |/ | | | | | | | | | | | | | | | | Adds new field check method DenyListFields to validate the pattern string. in addition, check for a zero length string as well. Closes-Bug: #1934252 Change-Id: I2b69025fc11125bb73a4e0f8c0dedad951399cbf
* | Merge "Fix duplicate zone when creating ptr records" into stable/wallabyZuul2022-06-043-18/+56
|\ \
| * | Fix duplicate zone when creating ptr recordsErik Olof Gunnar Andersson2022-06-033-18/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a race-condition when creating multiple PTR records under the same zone. There is a brief window when creating two identical zones can cause an error. This adds a fallback that should prevent the error. I also added a threaded test that caught multiple additional bugs in this code. - Wrong find_recordset used caused the wrong exception to be thrown. - The transaction workflow would break error handling. Change-Id: Ia1194ab838c52d5d91cb1d26c4556c73b4f3a745 (cherry picked from commit 0c7d218ba103e8260322e40f76a49a8c92556bfe)
* | | Merge "Fixed incorrect message when zone import failed due to quota" into ↵Zuul2022-06-044-17/+45
|\ \ \ | | | | | | | | | | | | stable/wallaby
| * | | Fixed incorrect message when zone import failed due to quotaErik Olof Gunnar Andersson2022-06-034-17/+45
| | | | | | | | | | | | | | | | | | | | | | | | Closes-Bug: #1960764 Change-Id: Ib91e49081855e5f4ec9f46a060d1587dcfeaac29 (cherry picked from commit 7e543c2d22516254cbaab111e9dad87a408ab80d)
* | | | Merge "Cleanup scheduler" into stable/wallabyZuul2022-06-046-55/+54
|\ \ \ \
| * | | | Cleanup schedulerErik Olof Gunnar Andersson2022-06-036-55/+54
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch is not changing any functionality, but instead it is aimed at cleaning up the scheduler code. It also removes the use of reserved keywords in the scheduler code. Change-Id: I93cede3371f1ec650adf3b00bf8250457a38f96c (cherry picked from commit 44383504519d94730fe712e7d8e300bbc5e21892)
* | | | Merge "Fix incorrect 404 error on floating IP create" into stable/wallabyZuul2022-06-041-2/+6
|\ \ \ \
| * | | | Fix incorrect 404 error on floating IP createMichael Johnson2022-06-031-2/+6
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is a case when creating a floating IP could return a 404 error instead of the expected floating IP payload. This fix is extracted from a non-backportable fix that was applied on yoga a newer branches[1]. [1] https://review.opendev.org/c/openstack/designate/+/830549 Change-Id: I53c2a0faf93be19eca259100fe6c3961ef4e7938 (cherry picked from commit 5237ce97da7b4c71723155c2276afdfe6af7dc9e)
* | | | Merge "Fix set-quotas for non-project scoped tokens" into stable/wallabyZuul2022-06-042-0/+16
|\ \ \ \ | |/ / / |/| | |
| * | | Fix set-quotas for non-project scoped tokensMichael Johnson2022-05-312-0/+16
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Previously, if set-quotas was called with a non-project scoped token and the all-projects flag was not set, the quotas would be updated but the result returned would always be the default quota values. This patch changes the API to require the all-projects flag when set-quota is called and the token is not project scoped. Closes-Bug: #1966128 Change-Id: I55ca76ef7c2cbeb5fdae1aed1dcbe58b7acddc34 (cherry picked from commit 158e017be489eea5402ef258ea260183067bf1ca)
* | | Merge "Fixed incorrect quota exception message" into stable/wallabyZuul2022-06-032-2/+2
|\ \ \ | |_|/ |/| |
| * | Fixed incorrect quota exception messageErik Olof Gunnar Andersson2022-05-312-2/+2
| |/ | | | | | | | | Change-Id: I38efa22bb8b0de6fd9a70339e8044fea70080004 (cherry picked from commit 291558c380232b726be0253fdee1f88902522beb)
* | Merge "Fix a typo in the tsigkey policy file" into stable/wallabyZuul2022-06-031-6/+6
|\ \
| * | Fix a typo in the tsigkey policy fileMichael Johnson2022-05-311-6/+6
| |/ | | | | | | | | | | | | This patch fixes a typo in the deprecated reason string variable name. Change-Id: I06cf5b5cbe5544327e30971115f3bf98214293f6
* | Merge "Simplify create zone import implementation" into stable/wallabyZuul2022-06-031-60/+48
|\ \
| * | Simplify create zone import implementationErik Olof Gunnar Andersson2022-06-021-60/+48
| |/ | | | | | | | | | | | | Removed unnecessarily complex threading code. Change-Id: If00b37e72dabd1bc66a78d9a832c3847c12f6692 (cherry picked from commit eed5042c41f8cd557dd3b53b28e17d520178af64)
* | Merge "Add proper quota error messages" into stable/wallabyZuul2022-06-032-57/+114
|\ \
| * | Add proper quota error messagesErik Olof Gunnar Andersson2022-06-012-57/+114
| |/ | | | | | | | | | | | | | | | | This patch adds a message to OverQuota containing information on the actual quota reached and fixes a minor visual bug with QuotaResourceUnknown. Change-Id: Ibd01f6ad3046ca29eec02032e9115183f89a6a4b (cherry picked from commit 907a029625a7f95369ca5a2f5173efefdb04d28f)
* | Merge "Modernize PTR implementation in Central" into stable/wallabyZuul2022-06-033-197/+187
|\ \
| * | Modernize PTR implementation in CentralErik Olof Gunnar Andersson2022-06-023-197/+187
| |/ | | | | | | | | | | | | | | | | | | | | | | | | Updated the PTR (floating ips) code to behave closer to how we handle this type of operations in designate.api.v2. This should resolve some issues (e.g. race conditions) with the older floating ips code. Additional changes. - Fixed minor typos in documentation. - Updated wording where it makes sense to use project instead of tenant. Change-Id: I897d7da185c2dd246b80d1a598e9e8a5c667304e (cherry picked from commit 7ec7adc44a9914ad9492014ca0edec2341fb5de0)
* | Merge "Allow email subadresses to be used within mail url of CAA records" ↵Zuul2022-06-033-1/+18
|\ \ | | | | | | | | | into stable/wallaby
| * | Allow email subadresses to be used within mail url of CAA recordsChristian Rohmann2022-06-023-1/+18
| |/ | | | | | | | | | | | | | | | | | | | | This patch allows for +subaddress to be used for the local part of mail urls used for CAA records. While there are more characters allowed in email addresses, using subadresses for incoming email to role accounts is quite common. Closes-Bug: 1958533 Change-Id: Id265fa1dfa5c0703d8e95b5de1334d4ca716fbc0 (cherry picked from commit 1cef20edbc462fab75a919fc0de796c2d6edb30b)
* | Merge "Fix delete zone transfer request with scoped token" into stable/wallabyZuul2022-06-032-0/+7
|\ \
| * | Fix delete zone transfer request with scoped tokenMichael Johnson2022-06-012-0/+7
| |/ | | | | | | | | | | | | | | This patch fixes an issue were deleting a zone transfer request with a scoped token may fail. Change-Id: I4522796ac056630c63798830e8f8d92628f14a37 (cherry picked from commit 6f847aeb5a309eb6e70dee58057fef01886573f6)
* | Merge "Fix dns.query.tcp/udp not always handling ipv6 properly" into ↵Zuul2022-06-0310-266/+213
|\ \ | | | | | | | | | stable/wallaby
| * | Fix dns.query.tcp/udp not always handling ipv6 properlyErik Olof Gunnar Andersson2022-06-0210-266/+213
| |/ | | | | | | | | | | | | | | | | | | | | Created a new generic send_dns_msg that properly handles both ip and hostnames and fully supports ipv4 and ipv6. Also, moved all usage of dns.query.tcp/udp to a central location. Change-Id: I403ed6716b3ceffa1910269adf0e352f75e9dd5b (cherry picked from commit acd930d3429aa30bea449f5fc7246581b0d2eb25)