summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.opendev.org>2021-04-19 14:29:39 +0000
committerGerrit Code Review <review@openstack.org>2021-04-19 14:29:39 +0000
commit9181439680347c4f0bddd9a700d45d7dcd6f7969 (patch)
treebd6af75dc135d544406365f5fd6283a6ad048ba2
parentd845b4040530a5e72d3cdfa43b11801c381c0ccc (diff)
parent59328b2543417aafd37e145f323434f853276662 (diff)
downloadheat-9181439680347c4f0bddd9a700d45d7dcd6f7969.tar.gz
Merge "Assume interface detach called for port not found" into stable/victoria
-rw-r--r--heat/engine/clients/os/nova.py2
-rw-r--r--heat/tests/openstack/nova/test_server.py2
2 files changed, 2 insertions, 2 deletions
diff --git a/heat/engine/clients/os/nova.py b/heat/engine/clients/os/nova.py
index cd19b2ea5..c0f280bbf 100644
--- a/heat/engine/clients/os/nova.py
+++ b/heat/engine/clients/os/nova.py
@@ -793,7 +793,7 @@ echo -e '%s\tALL=(ALL)\tNOPASSWD: ALL' >> /etc/sudoers
server = self.fetch_server(server_id)
if server:
server.interface_detach(port_id)
- return True
+ return True
def interface_attach(self, server_id, port_id=None, net_id=None, fip=None,
security_groups=None):
diff --git a/heat/tests/openstack/nova/test_server.py b/heat/tests/openstack/nova/test_server.py
index f4aec2a81..47ab98963 100644
--- a/heat/tests/openstack/nova/test_server.py
+++ b/heat/tests/openstack/nova/test_server.py
@@ -5073,7 +5073,7 @@ class ServerInternalPortTest(ServersTest):
server.client().servers.get.return_value = nova_server
server.prepare_for_replace()
- check_detach.assert_not_called()
+ self.assertEqual(3, check_detach.call_count)
self.assertEqual(0, self.port_delete.call_count)
def test_prepare_ports_for_replace_error_state(self):