summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* stable-only: Pin bandit to 1.7.420.0.0.0rc220.0.0stable/2023.1Takashi Kajinami2023-03-132-5/+3
| | | | | | | | bandit 1.7.5 introduced the new lint rule with which current heat code is not compliant. This pins bandit so that any new lint rule does not affect pep8 job in stable branches. Change-Id: Ie552e6398c10797e4df4afe757760c48ca7f80af
* Merge "Fix unit tests with python-novaclient 18.3.0" into stable/2023.1Zuul2023-03-101-11/+41
|\
| * Fix unit tests with python-novaclient 18.3.0Takashi Kajinami2023-03-091-11/+41
| | | | | | | | | | | | | | | | | | | | python-novaclient 18.3.0 replaced usage of kwargs by explicit arguments and that broke some assertions of arguments. story: 2010638 task: 47613 Change-Id: I039d1e672611b7b523ce61df072c60d161851eed (cherry picked from commit 513dfd116e5177cb43a0fb78471ad1992f16210d)
* | Disable B113 rule of banditTakashi Kajinami2023-03-101-2/+4
| | | | | | | | | | | | | | | | | | | | | | The new release of bandit just came out which introduced the new rule, with which unfortunately heat is not compliant now. This disables the rule temporally so that we can avoid adapting our stable branches to new lint rules by backporting this. Change-Id: I4a27049d40760ad8da6fda24e1195e26ef9c6c17 (cherry picked from commit 4fcbe943385d01b2e9c34db2a7c5738edb4c169d)
* | Update TOX_CONSTRAINTS_FILE for stable/2023.1OpenStack Release Bot2023-03-071-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/2023.1 branch, tests will continue to use the upper-constraints list on master. Change-Id: I253d07729777dac493eace5f23eee7b30a378dd5
* | Update .gitreview for stable/2023.1OpenStack Release Bot2023-03-071-0/+1
|/ | | | Change-Id: I47e53e344572a9a67ce1f324694779fb28a2e94c
* Merge "Return HTTPBadRequest from circular dependency"20.0.0.0rc1Zuul2023-03-072-1/+49
|\
| * Return HTTPBadRequest from circular dependencyTobias Urdin2023-02-272-1/+49
| | | | | | | | | | | | | | | | | | | | | | We don't map the CircularDependencyException to a 400 Bad Request in the fault middleware so users can never get an understand of what is wrong in their template. They are today instead present with a 500 internal server error without details which doesn't help them. Change-Id: Idc8713b4c29e2534dd7059e4566ac3b777f418e5
* | Merge "Move CircularDependencyException to common"Zuul2023-03-075-15/+14
|\ \ | |/
| * Move CircularDependencyException to commonTobias Urdin2023-02-275-15/+14
| | | | | | | | | | | | | | | | Moves the exception from inside the engine code to the common code so that we can use it in the API fault middleware. Change-Id: I017b95153c358829501f6a5740918cdb005fb32f
* | Merge "fix heat update senlin cluster"Zuul2023-03-062-6/+6
|\ \
| * | fix heat update senlin clusterBui Doan Dang2023-03-062-6/+6
| | | | | | | | | | | | | | | | | | | | | story: 2010578 task: 47331 Change-Id: I3706d662ec56e3548eb991556be7bd0f82f49e05
* | | Merge "Fix parsing of live data from OS::Nova::Server"Zuul2023-03-061-1/+11
|\ \ \
| * | | Fix parsing of live data from OS::Nova::ServerPavlo Shchelokovskyy2023-03-061-1/+11
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | depending on compute API version, flavor in the instance representation may not have "id" field, but "original_name" instead. Story: 2009753 Task: 44211 Change-Id: Ieeae2f36f5e59e01f57a2f8e66a983ec3d99ec63
* | | Merge "Skip basic scenario test"Zuul2023-03-061-1/+2
|\ \ \ | |/ /
| * | Skip basic scenario testTakashi Kajinami2023-03-061-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test is very frequently failing now. The test case creates a stack with an instance but the stack can't be deleted within timeout because of the known libvirt bug in Ubuntu Jammy. Because the release deadline is already over, we'll disable this test so that we can merge some changes now. We'll revisit this (and the other test cases we disabled) later. Related-Bug: #1998274 Story: 2010631 Task: 47589 Change-Id: I87c4b1e7a911fd78e327393b1af200667e89c999
* | | Merge "Added a unit test for get_environment_hidden_param"Zuul2023-03-021-0/+50
|\ \ \
| * | | Added a unit test for get_environment_hidden_paramChengen Du2023-02-161-0/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A unit test for verifying that hidden parameters should be masked in the get stack environment API Story: 2010555 Task: 47229 Change-Id: I44ef26849ebb450a5643907a0ef47166cfd9b1cb
* | | | Merge "Update release note of task 47052"Zuul2023-03-011-1/+3
|\ \ \ \ | |_|_|/ |/| | |
| * | | Update release note of task 47052Takashi Kajinami2023-02-151-1/+3
| |/ / | | | | | | | | | | | | | | | | | | The previous content is not very accurate because the fix is made in API layer instead of the CLI command. Change-Id: I0abbd535aacc03446ada0fa806dfdfdaa4522afe
* | | Fix setting the tempest virtual env constraints env varGhanshyam Mann2023-02-213-2/+37
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Heat upgrade script set the env var TOX_CONSTRAINTS_FILE/UPPER_CONSTRAINTS_FILE which are used to use the constraints during Tempest virtual env installation. Those env var are set to non-master constraint when we need to use non-master constraints but when we need to use the master constraints we do not set/reset them point to master constraints. This create the issue when this grenade script install the tempest with stable constraints but with master Tempest and as there is mismatch of constraints now with fasteners of stable branches. Below is failure of heat greande job on stable/yoga - https://zuul.opendev.org/t/openstack/build/3aaec4d59bb84068bb4d4428ea747cbd/log/controller/logs/grenade.sh_log.txt#3245 Similar way, role should set stable constraints only for the stable EM branch not for all otherwise it fail when constraints/requirements are bumped. - https://zuul.opendev.org/t/openstack/build/74f86b8097f44c35acaffdcfe41d9693 We should set/reset those constraint env var to master constraints if configuration tell to use the master constraints. Closes-Bug: #2003993 Change-Id: I024cd134577338fc1075e7742df7f006dc914646
* | Fix unit tests for python-barbicanclient 5.5.0Michael Johnson2023-02-161-0/+2
|/ | | | | | | | | | | | | | | Version 5.5.0 of python-barbicanclient adds microversion support, which causes it to call keystoneauth1.discover.get_version_data to get the microversion information from the server. Adding additional mock.patch for keystoneauth1.discover fixes the breaking unit tests. This is a gate fix for the python-barbicanclient upper-constraints bump[1]. [1] https://review.opendev.org/c/openstack/requirements/+/873906 Co-Authored-By: Grzegorz Grasza <xek@redhat.com> Change-Id: Ic1c26d255ff0690e327b3cb6c622d3617e02df5f
* Fix an assert statementTakashi Natsume2023-02-121-2/+1
| | | | | | | | | | Fix an assert statement in heat/tests/aws/test_eip.py. Change-Id: I3ae3e8d3132f8e100067fb86460b7c3f3ae35d07 Story: 2010265 Task: 46164 Signed-off-by: Takashi Natsume <takanattie@gmail.com>
* Merge "Deploy healthcheck middleware as app instead of filter"Zuul2023-02-012-22/+79
|\
| * Deploy healthcheck middleware as app instead of filterTakashi Kajinami2022-06-062-22/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the healthcheck middleware as a filter is deprecated and the middleware should be used as an application[1]. [1] 6feaa13610c450c8486f969703768db5319b4846 This change updates definition and usage of the healthcheck middleware accordingly to avoid the following deprecation warning. DeprecationWarning: Using function/method 'Healthcheck.factory()' is deprecated: The healthcheck middleware must now be configured as an application, not as a filter. This also refactors composite definitions based on flavor by the new pipeline factory. Story: 2009071 Task: 42881 Change-Id: I75386dc4a7dc14b3c753dfff01f147ef8233bf94
* | Merge "Honor 'hidden' parameter in 'stack environment show' command"Zuul2023-01-273-2/+17
|\ \
| * | Honor 'hidden' parameter in 'stack environment show' commandChengen Du2023-01-113-2/+17
| | | | | | | | | | | | | | | | | | | | | Related-Bug: #1999665 Story: 2010484 Task: 47052 Change-Id: Ifc51ff6a4deab05002ccded59383416f9a586aa0
* | | Merge "Use new get_rpc_client API from oslo.messaging"Zuul2023-01-272-3/+3
|\ \ \
| * | | Use new get_rpc_client API from oslo.messagingTobias Urdin2023-01-192-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the new API that is consistent with the existing API instead of instantiating the client class directly. This was introduced in release 14.1.0 here [1] and added into oslo.messaging here [2] [1] https://review.opendev.org/c/openstack/requirements/+/869340 [2] https://review.opendev.org/c/openstack/oslo.messaging/+/862419 Change-Id: Ia48de36e3cb97378785bb4946b1a387c0da1ff81
* | | | Merge "Explicitly pass error kwarg in nested StackValidationFailed"Zuul2023-01-251-1/+1
|\ \ \ \
| * | | | Explicitly pass error kwarg in nested StackValidationFailedTobias Urdin2022-12-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the issue when a nested stack is serialized in oslo.messaging and deserialization fails because we pass a kwarg as an arg when we generate the exception remotely. Story: #2010115 Task: #45695 Change-Id: Id75398d2ed2d4fab467df51057c4167cd77bb32f
* | | | | Merge "Replace deprecated Query.as_scalar()"Zuul2023-01-242-2/+2
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Replace deprecated Query.as_scalar()ramishra2022-09-062-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This has been deprecated since SQLAlchemy 1.4. Change-Id: Id3edcc188bb44d9752fe1bd7625308c5abed4d9c
* | | | | Merge "Decode UTF-8 body data in SwiftSignal"Zuul2023-01-192-54/+59
|\ \ \ \ \
| * | | | | Decode UTF-8 body data in SwiftSignalZane Bitter2023-01-192-54/+59
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ie12c2df93f846629a7c8b7c6415cebc31eaba1bc Story: #2010485 Task: 47053
* | | | | Merge "Switch to 2023.1 Python3 unit tests and generic template name"Zuul2023-01-111-2/+2
|\ \ \ \ \ | |_|_|/ / |/| | | |
| * | | | Switch to 2023.1 Python3 unit tests and generic template nameOpenStack Release Bot2022-09-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for antelope. Also, updating the template name to generic one. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: I1df5bb05ea5ba40bea88ae0fe4cd8e8221429579
* | | | | Skip test_stack_update_with_replacing_userdataTakashi Kajinami2022-12-233-7/+10
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test case is frequently failing because of a known libvirt issue in Ubuntu Jammy. We already disabled one functional test case, but will disable this test case as well, to reduce failure rate of CI runs and unblock gate. The existing skip for a different test case[1] is re-implemented using the proper configuration knob. This also fixes tox.ini to adapt to new tox 4.0. - Update how passenv is defined because space-separated list is no longer allowed. Also the values are not case sensitive. - skipdist=True breaks installation so is removed. [1] https://review.opendev.org/c/openstack/heat/+/866545 Co-Authored-By: Rabi Mishra <ramishra@redhat.com> Related-Bug: #1998274 Story: 2010487 Task: 47056 Change-Id: I915dc83ccde6b6b8497642857292f9974fd84e98
* | | | Merge "Skip test_cancel_update_server_with_port"Zuul2022-12-061-0/+3
|\ \ \ \
| * | | | Skip test_cancel_update_server_with_portTakashi Kajinami2022-12-051-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently this test consistently fails because detaching an interface does not progress, which is likely to be a libvirt issue. This change disables the test case to temporally unblock CI. Related-Bug: #1998274 Story: 2010458 Task: 46978 Change-Id: I7d9a1b2239a8406d12f3482062f4efd1d3e55d78
* | | | | Ignore resource_data decryption errorsramishra2022-11-151-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the auth_encryption_key changes We can possibly ignore these errors when deleting stacks. Task: 42056 Change-Id: I326e415db194a5b9c67acd038d7d2d993293ecb3
* | | | | Don't load all resources for policy checkramishra2022-11-152-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We only need the resource types for the check. Let's avoid loading all resources. Change-Id: Iaf5650b2ae972064292cfe0d17f98b5635c51bad
* | | | | Imported Translations from ZanataOpenStack Proposal Bot2022-11-1311-375/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I5db9cc7f9a13db05a7d0ab0320e53bfdf4b419d9
* | | | | Merge "Retry to detach volume if nova returned error 409"Zuul2022-11-112-5/+31
|\ \ \ \ \
| * | | | | Retry to detach volume if nova returned error 409Mitya_Eremeev2022-10-122-5/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During volume detachment an instance can be in error state or locked. Nova returns error 409. Instance can be unlocked or fixed a bit later, but heat doesn't retry to detach volume. The patch makes heat to retry detachments untill stack update timeout. story: 2010355 Change-Id: I9a08b938401cd71eddd0eb80782d10392f92bf45
* | | | | | Merge "Improve map_merge logging"Zuul2022-11-091-1/+3
|\ \ \ \ \ \
| * | | | | | Improve map_merge loggingBrendan Shephard2022-11-031-1/+3
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Templates can be complex and contain multiple instances of map_merges. Debugging this can be complex, so this change aims to improve the mapping and help users determine where the problem has occured. With this change, instead of just saying an error occured, we will now return the object that the error occurred with and a note about it's type. This will allow for quick identification of what the problem was. Change-Id: I1c4da88029bbf1a3cfb58f5e21da28ec2912f924
* | | | | | Update stestr args for inclusive languageBrendan Shephard2022-11-091-1/+1
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stestr has removed whitelist / blacklist. This change updates the devstack upgrade tests to ensure we use the new include-list instead. https://github.com/mtreinish/stestr/commit/9ffeb470fb4eaed484152d35411668db19a64ace Change-Id: Ia0df9b3468fee9382c42c8bd6a35b76ed7f2b4e5
* | | | | Set cache_ok to avoid further SAWarningTakashi Kajinami2022-11-011-0/+2
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change fixes the one remaining usage without the flag which was missed by the previous attempt[1]. [1] 14d2d859ef4eb3d21bf6e419a77c2f3185d5cf77 Change-Id: Ic0b34b11d669851e47cae670f5299f934f396257
* | | | Merge "Allow deleting user_creds when can't be decrypted"Zuul2022-10-041-2/+4
|\ \ \ \