1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
|
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import collections
import mock
import six
from heat.common import exception
from heat.engine.clients.os import cinder as c_plugin
from heat.engine import stack
from heat.engine import template
from heat.tests import common
from heat.tests import utils
volume_type_template = {
'heat_template_version': '2013-05-23',
'resources': {
'my_volume_type': {
'type': 'OS::Cinder::VolumeType',
'properties': {
'name': 'volumeBackend',
'metadata': {'volume_backend_name': 'lvmdriver'}
}
}
}
}
class CinderVolumeTypeTest(common.HeatTestCase):
def setUp(self):
super(CinderVolumeTypeTest, self).setUp()
self.ctx = utils.dummy_context()
self.patchobject(c_plugin.CinderClientPlugin, 'has_extension',
return_value=True)
self.stack = stack.Stack(
self.ctx, 'cinder_volume_type_test_stack',
template.Template(volume_type_template)
)
self.my_volume_type = self.stack['my_volume_type']
cinder = mock.MagicMock()
self.cinderclient = mock.MagicMock()
self.my_volume_type.client = cinder
cinder.return_value = self.cinderclient
self.volume_types = self.cinderclient.volume_types
self.volume_type_access = self.cinderclient.volume_type_access
keystoneclient = self.stack.clients.client_plugin('keystone').client()
keystoneclient.client = mock.MagicMock()
keystoneclient.client.projects = mock.MagicMock()
self.project_list = mock.MagicMock()
keystoneclient.client.projects.get = self.project_list
def _test_handle_create(self, is_public=True, projects=None):
value = mock.MagicMock()
volume_type_id = '927202df-1afb-497f-8368-9c2d2f26e5db'
value.id = volume_type_id
self.volume_types.create.return_value = value
tmpl = self.stack.t.t
props = tmpl['resources']['my_volume_type']['properties'].copy()
props['is_public'] = is_public
if projects:
props['projects'] = projects
project = collections.namedtuple('Project', ['id'])
stub_projects = [project(p) for p in projects]
self.project_list.side_effect = [p for p in stub_projects]
self.my_volume_type.t = self.my_volume_type.t.freeze(properties=props)
self.my_volume_type.reparse()
self.my_volume_type.handle_create()
self.volume_types.create.assert_called_once_with(
name='volumeBackend', is_public=is_public, description=None)
value.set_keys.assert_called_once_with(
{'volume_backend_name': 'lvmdriver'})
self.assertEqual(volume_type_id, self.my_volume_type.resource_id)
if projects:
calls = []
for p in projects:
calls.append(mock.call(volume_type_id, p))
self.volume_type_access.add_project_access.assert_has_calls(calls)
def test_volume_type_handle_create_public(self):
self._test_handle_create()
def test_volume_type_handle_create_not_public(self):
self._test_handle_create(is_public=False)
def test_volume_type_with_projects(self):
self.cinderclient.volume_api_version = 2
self._test_handle_create(projects=['id1', 'id2'])
def _test_update(self, update_args, is_update_metadata=False):
if is_update_metadata:
value = mock.MagicMock()
self.volume_types.get.return_value = value
value.get_keys.return_value = {'volume_backend_name': 'lvmdriver'}
else:
volume_type_id = '927202df-1afb-497f-8368-9c2d2f26e5db'
self.my_volume_type.resource_id = volume_type_id
self.my_volume_type.handle_update(json_snippet=None,
tmpl_diff=None,
prop_diff=update_args)
if is_update_metadata:
value.unset_keys.assert_called_once_with(
{'volume_backend_name': 'lvmdriver'})
value.set_keys.assert_called_once_with(
update_args['metadata'])
else:
self.volume_types.update.assert_called_once_with(
volume_type_id, **update_args)
def test_volume_type_handle_update_description(self):
update_args = {'description': 'update'}
self._test_update(update_args)
def test_volume_type_handle_update_name(self):
update_args = {'name': 'update'}
self._test_update(update_args)
def test_volume_type_handle_update_is_public(self):
prop_diff = {'is_public': True, "projects": []}
self.patchobject(self.volume_type_access, 'list')
volume_type_id = '927202df-1afb-497f-8368-9c2d2f26e5db'
self.my_volume_type.resource_id = volume_type_id
self.my_volume_type.handle_update(json_snippet=None,
tmpl_diff=None,
prop_diff=prop_diff)
self.volume_types.update.assert_called_once_with(
volume_type_id, is_public=True)
self.volume_type_access.list.assert_not_called()
def test_volume_type_handle_update_metadata(self):
new_keys = {'volume_backend_name': 'lvmdriver',
'capabilities:replication': 'True'}
prop_diff = {'metadata': new_keys}
self._test_update(prop_diff, is_update_metadata=True)
def test_volume_type_update_projects(self):
self.my_volume_type.resource_id = '8aeaa446459a4d3196bc573fc252800b'
prop_diff = {'projects': ['id2', 'id3'], 'is_public': False}
class Access(object):
def __init__(self, idx, project):
self.volume_type_id = idx
self.project_id = project
info = {'volume_type_id': idx, 'project_id': project}
self.to_dict = mock.Mock(return_value=info)
old_access = [Access(self.my_volume_type.resource_id, 'id1'),
Access(self.my_volume_type.resource_id, 'id2')]
self.patchobject(self.volume_type_access, 'list',
return_value=old_access)
self.patchobject(self.volume_type_access, 'remove_project_access')
project = collections.namedtuple('Project', ['id'])
self.project_list.return_value = project('id3')
self.my_volume_type.handle_update(json_snippet=None,
tmpl_diff=None,
prop_diff=prop_diff)
self.volume_type_access.remove_project_access.assert_called_once_with(
self.my_volume_type.resource_id, 'id1')
self.project_list.assert_called_once_with('id3')
self.volume_type_access.add_project_access.assert_called_once_with(
self.my_volume_type.resource_id, 'id3')
def test_validate_projects_when_public(self):
tmpl = self.stack.t.t
props = tmpl['resources']['my_volume_type']['properties'].copy()
props['is_public'] = True
props['projects'] = ['id1']
self.my_volume_type.t = self.my_volume_type.t.freeze(properties=props)
self.my_volume_type.reparse()
self.cinderclient.volume_api_version = 2
self.stub_KeystoneProjectConstraint()
ex = self.assertRaises(exception.StackValidationFailed,
self.my_volume_type.validate)
expected = ('Can not specify property "projects" '
'if the volume type is public.')
self.assertEqual(expected, six.text_type(ex))
def test_validate_projects_when_private(self):
tmpl = self.stack.t.t
props = tmpl['resources']['my_volume_type']['properties'].copy()
props['is_public'] = False
props['projects'] = ['id1']
self.my_volume_type.t = self.my_volume_type.t.freeze(properties=props)
self.my_volume_type.reparse()
self.cinderclient.volume_api_version = 2
self.stub_KeystoneProjectConstraint()
self.assertIsNone(self.my_volume_type.validate())
def test_volume_type_get_live_state_public(self):
self.my_volume_type.resource_id = '1234'
volume_type = mock.Mock()
volume_type.to_dict.return_value = {'name': 'test',
'is_public': True,
'description': 'test1',
'metadata': {'one': 'two'}}
self.volume_types.get.return_value = volume_type
volume_type.get_keys.return_value = {'one': 'two'}
volume_type_access = mock.MagicMock()
self.cinderclient.volume_type_access = volume_type_access
reality = self.my_volume_type.get_live_state(
self.my_volume_type.properties)
expected = {
'name': 'test',
'is_public': True,
'description': 'test1',
'projects': [],
'metadata': {'one': 'two'}
}
self.assertEqual(set(expected.keys()), set(reality.keys()))
for key in reality:
self.assertEqual(expected[key], reality[key])
self.assertEqual(0, volume_type_access.list.call_count)
def test_volume_type_get_live_state_not_public(self):
self.my_volume_type.resource_id = '1234'
volume_type = mock.Mock()
volume_type.to_dict.return_value = {'name': 'test',
'is_public': False,
'description': 'test1',
'metadata': {'one': 'two'}}
self.volume_types.get.return_value = volume_type
volume_type.get_keys.return_value = {'one': 'two'}
volume_type_access = mock.MagicMock()
class Access(object):
def __init__(self, idx, project, info):
self.volumetype_id = idx
self.project_id = project
self.to_dict = mock.Mock(return_value=info)
volume_type_access.list.return_value = [
Access('1234', '1', {'volumetype_id': '1234', 'project_id': '1'}),
Access('1234', '2', {'volumetype_id': '1234', 'project_id': '2'})]
self.cinderclient.volume_type_access = volume_type_access
reality = self.my_volume_type.get_live_state(
self.my_volume_type.properties)
expected = {
'name': 'test',
'is_public': False,
'description': 'test1',
'metadata': {'one': 'two'},
'projects': ['1', '2']
}
self.assertEqual(expected, reality)
volume_type_access.list.assert_called_once_with('1234')
|