summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2014-01-31 12:04:50 +0000
committerGerrit Code Review <review@openstack.org>2014-01-31 12:04:50 +0000
commit6508afd6f9254025ebdcb7c6d9d09b82c724a026 (patch)
treed63c2796a4bf77291dac4216cac541d5f252efae
parent5520d657df4e511040862ae1d4f94d9f2278ed77 (diff)
parentce8611c3dc053c331170a9e6cc9813f9d6e4c756 (diff)
downloadhorizon-6508afd6f9254025ebdcb7c6d9d09b82c724a026.tar.gz
Merge "Bad workflow-steps check: has_required_fields" into stable/havana
-rw-r--r--horizon/workflows/base.py10
1 files changed, 2 insertions, 8 deletions
diff --git a/horizon/workflows/base.py b/horizon/workflows/base.py
index 0c8c2004b..1e5968a4c 100644
--- a/horizon/workflows/base.py
+++ b/horizon/workflows/base.py
@@ -447,14 +447,8 @@ class Step(object):
self.action.add_error(message)
def has_required_fields(self):
- """
- Returns True if action contains any required fields
- """
- for key in self.contributes:
- field = self.action.fields.get(key, None)
- if (field and field.required):
- return True
- return False
+ """Returns True if action contains any required fields."""
+ return any(field.required for field in self.action.fields.values())
class WorkflowMetaclass(type):