diff options
author | Jenkins <jenkins@review.openstack.org> | 2014-02-01 03:05:45 +0000 |
---|---|---|
committer | Gerrit Code Review <review@openstack.org> | 2014-02-01 03:05:45 +0000 |
commit | 96bd650e3304618b790e5f3fcdfc4d92fd4b146c (patch) | |
tree | 9a6d745088d792ffc6c99a30f7139d72610b2f09 | |
parent | 5b970a5842ebdb40c6cdd06c0762b54120fd4ff7 (diff) | |
parent | 970b165d5fef31c56f5914b921665bdf6882d2e2 (diff) | |
download | horizon-96bd650e3304618b790e5f3fcdfc4d92fd4b146c.tar.gz |
Merge "Fix inappropriate logouts on load-balanced Horizon" into stable/havana
-rw-r--r-- | horizon/middleware.py | 7 | ||||
-rw-r--r-- | horizon/test/tests/middleware.py | 5 |
2 files changed, 6 insertions, 6 deletions
diff --git a/horizon/middleware.py b/horizon/middleware.py index 6cd9d420a..565124137 100644 --- a/horizon/middleware.py +++ b/horizon/middleware.py @@ -21,9 +21,9 @@ Middleware provided and used by Horizon. """ -import datetime import json import logging +import time from django.conf import settings # noqa from django.contrib.auth import REDIRECT_FIELD_NAME # noqa @@ -61,11 +61,12 @@ class HorizonMiddleware(object): timeout = 1800 last_activity = request.session.get('last_activity', None) - timestamp = datetime.datetime.now() + timestamp = int(time.time()) request.horizon = {'dashboard': None, 'panel': None, 'async_messages': []} - if last_activity and (timestamp - last_activity).seconds > timeout: + if (isinstance(last_activity, int) + and (timestamp - last_activity) > timeout): request.session.pop('last_activity') response = HttpResponseRedirect( '%s?next=%s' % (settings.LOGOUT_URL, request.path)) diff --git a/horizon/test/tests/middleware.py b/horizon/test/tests/middleware.py index d480fa10d..53ae5b19b 100644 --- a/horizon/test/tests/middleware.py +++ b/horizon/test/tests/middleware.py @@ -15,7 +15,7 @@ # License for the specific language governing permissions and limitations # under the License. -import datetime +import time from django.conf import settings # noqa @@ -43,8 +43,7 @@ class MiddlewareTests(test.TestCase): timeout = settings.SESSION_TIMEOUT except AttributeError: timeout = 1800 - request.session['last_activity'] =\ - datetime.datetime.now() - datetime.timedelta(seconds=timeout + 10) + request.session['last_activity'] = int(time.time()) - (timeout + 10) mw = middleware.HorizonMiddleware() resp = mw.process_request(request) self.assertEqual(resp.status_code, 302) |