summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRikimaru Honjo <honjo.rikimaru@ntt-tx.co.jp>2020-01-15 10:48:14 +0000
committerRikimaru Honjo <honjo.rikimaru@ntt-tx.co.jp>2020-01-29 05:10:32 +0000
commite058e381607e93439a59f47c36e6a9b7cf61cc71 (patch)
treeed1796241767f126760a7198d48d8af8d41129ed
parente2ecdaf01a16c30049f67c8329c2ca4009eb5b18 (diff)
downloadhorizon-e058e381607e93439a59f47c36e6a9b7cf61cc71.tar.gz
Allow to evacuate without specifying a target host
When the evacuate is run without specifying a target host, horizon sets an empty string for target host. But the evacuate api doesn't allow an empty string. As a result, nova returns "HTTP 400 Bad request". So this patch sets None as the target host when it isn't specified. Change-Id: Ia865a6c02e206fa49efc3095e8d3488f5638d0e3 Closes-Bug: 1793694 (cherry picked from commit f9e0f8a976b82088ef095a69cd1fa892cddde3ba)
-rw-r--r--openstack_dashboard/dashboards/admin/hypervisors/compute/forms.py5
1 files changed, 5 insertions, 0 deletions
diff --git a/openstack_dashboard/dashboards/admin/hypervisors/compute/forms.py b/openstack_dashboard/dashboards/admin/hypervisors/compute/forms.py
index 2e9a6434b..8082e8268 100644
--- a/openstack_dashboard/dashboards/admin/hypervisors/compute/forms.py
+++ b/openstack_dashboard/dashboards/admin/hypervisors/compute/forms.py
@@ -57,6 +57,11 @@ class EvacuateHostForm(forms.SelfHandlingForm):
current_host = data['current_host']
target_host = data['target_host']
on_shared_storage = data['on_shared_storage']
+ # The target_host value will be an empty string when the target
+ # host wasn't specified. But the evacuate api doesn't allow
+ # an empty string. So set None as the target_host value.
+ if not target_host:
+ target_host = None
api.nova.evacuate_host(request, current_host,
target_host, on_shared_storage)