diff options
| author | manchandavishal <manchandavishal143@gmail.com> | 2023-01-06 11:54:54 +0530 |
|---|---|---|
| committer | Vishal Manchanda <manchandavishal143@gmail.com> | 2023-01-12 09:42:28 +0000 |
| commit | 4db7e436d02bf7aa35469beaf9415e0da8cecb87 (patch) | |
| tree | f07ff9581db69299943f053ef7f6af388b6e8bf1 | |
| parent | a7f95784785408afdd2273de7aef33cee31793e1 (diff) | |
| download | horizon-4db7e436d02bf7aa35469beaf9415e0da8cecb87.tar.gz | |
Pin tox<4 for stable branches testing
horizon npm jobs start failing due to some recent changes in tox4.
As discussed on open-discuss ML, it is decided to keep testing the
stable branch with the tox version that they release with and not
with the tox 4. This patch set the 'ensure_tox_version' to use 4,
which will tell zuul to install tox<4 if it's not present.
For more info. please refer [1].
[1] https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031668.html
Change-Id: I3652d87d817030bcd3855d26bfa41b8b7061d08e
| -rw-r--r-- | .zuul.d/nodejs-jobs.yaml | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/.zuul.d/nodejs-jobs.yaml b/.zuul.d/nodejs-jobs.yaml index f9f56b2f0..bdfe83eb7 100644 --- a/.zuul.d/nodejs-jobs.yaml +++ b/.zuul.d/nodejs-jobs.yaml @@ -6,6 +6,10 @@ vars: node_version: 14 tox_constraints_file: "{{ ansible_user_dir }}/{{ zuul.projects['opendev.org/openstack/requirements'].src_dir }}/upper-constraints.txt" + # NOTE: This is stable branch (<=stable/zed) job and new tox 4 + # require some changes in tox.ini to be compatible with it. Let's + # pin tox <4 for stable branches testing (<=stable/zed). + ensure_tox_version: '<4' nodeset: ubuntu-focal pre-run: playbooks/horizon-nodejs/pre.yaml required-projects: @@ -20,6 +24,10 @@ vars: node_version: 14 tox_constraints_file: "{{ ansible_user_dir }}/{{ zuul.projects['opendev.org/openstack/requirements'].src_dir }}/upper-constraints.txt" + # NOTE: This is stable branch (<=stable/zed) job and new tox 4 + # require some changes in tox.ini to be compatible with it. Let's + # pin tox <4 for stable branches testing (<=stable/zed). + ensure_tox_version: '<4' pre-run: playbooks/horizon-nodejs/pre.yaml nodeset: ubuntu-focal required-projects: |