summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix success_url parameter issue for Edit Snapshotwallaby-em19.4.0manchandavishal2022-10-291-11/+1
| | | | | | | | | | | | | | The "success_url" param is used when updating the project snapshot [1] and it lacks sanitizing the input URL that allows an attacker to redirect the user to another website. This patch update 'Updateview' class to not use the "sucess_url" method. Closes-bug: #1982676 [1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/snapshots/views.py#L109 Change-Id: Ied142440965b1a722e7a4dd1be3b1be3b3e1644b (cherry picked from commit 79d139594290779b2f74ca894332aa7f2f7e4735)
* Merge "Fix flavor specification at instance overview page" into stable/wallabyZuul2022-10-282-5/+30
|\
| * Fix flavor specification at instance overview pageTatiana Ovchinnikova2022-10-062-5/+30
| | | | | | | | | | | | | | | | | | | | The details page uses flavor id to resolve instance flavor, relying on legacy Nova API v2.46. This patch adds the current Nova API option, resolving instance flavor by flavor name, so flavor specification at instance overview page is displayed properly. Change-Id: I1fe45063c9d1cdd8682998329d81f843d30f80b3 (cherry picked from commit d0e9e976f2769b289196d481b0928893b702b011)
* | Merge "Modified the image page to use CSS class" into stable/wallabyZuul2022-10-271-2/+1
|\ \
| * | Modified the image page to use CSS classWei Lingfei2022-09-291-2/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | Pages can not display normal when language is Simplified Chinese(zh-cn), a row in the table can display only one Chinese character. Remove "width: 100%" rule from the "word-wrap" class. The page should now display normally. Partial-Bug: #1936830 Change-Id: If72d49c78a9f83687785a1225151d819b85e88d2 (cherry picked from commit e9ca0016234632f6ad0fbd766c5829c587b6a951)
* | Merge "Don't try and update port security if its not changing" into ↵Zuul2022-10-273-4/+22
|\ \ | | | | | | | | | stable/wallaby
| * | Don't try and update port security if its not changingSam Morrison2022-09-243-4/+22
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Default policy in neutron doesn't allow port security to change if network not owned by the user. To allow users to update other attributes of a port don't send port_security_enabled attribute to neutron unless it changes. If user tries to change port security on a port in a network not owned by them it will still error as it does now. Partial-Bug: #1841050 Change-Id: I301336103cabc3f1cab3ee72d7743385ff1a10d6 (cherry picked from commit d059b0bc40f04befc60657cd6504cc5711934b90)
* | zuul: Declare queue at top levelTakashi Kajinami2022-10-171-1/+1
|/ | | | | | | | | | | | | | Zuul deprecated declaring shared queues at a pipeline level with release 4.1.0[1]. This updates the job definition to use the top level declaration instead. See [2] for details. [1] https://zuul-ci.org/docs/zuul/latest/releasenotes.html#relnotes-4-1-0-deprecation-notes [2] http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028603.html Change-Id: Ie63dd3b161cb8fd9be89002027d699ce2c4a67a5 (cherry picked from commit 4212950a4a6b036f563a236cb005604e1c096f04)
* Imported Translations from Zanata19.3.0OpenStack Proposal Bot2022-06-294-8/+49
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I14ef48f665550971e45c1212f53bd69320384ba9
* Merge "Add default_availability_zone for VM creation" into stable/wallabyZuul2022-06-285-5/+107
|\
| * Add default_availability_zone for VM creationDavid Hill2021-06-185-5/+107
| | | | | | | | | | | | | | | | | | | | Add the LAUNCH_INSTANCE_DEFAULTS.default_availability_zone settings in VM creation dashboard in order to let administrator select a default availability zone instead of a random one when many are available. Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I297ff7f3c8e725c24c7f7687786c784f61f5d4e2 (cherry picked from commit fc8603a499fb3302aeb2ebef714420e0fdcbdfef)
* | Make existing empty metadata properties optionalTatiana Ovchinnikova2022-06-142-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | Editing of snapshot image or updating its metadata from Horizon is not allowed until existing properties with empty values are set or removed from metadata tree. They are allowed to be None, therefore Horizon should consider them optional too. Closes-Bug: #1945706 Change-Id: Idfec71d209430c7d069133a40ca1a7d340163783 (cherry picked from commit 4e0f5a5a85467ca83743e6e8126cd570f329afb9)
* | Merge "Add horizontal scrollbar to role dropdown" into stable/wallabyZuul2022-05-251-0/+2
|\ \
| * | Add horizontal scrollbar to role dropdownTatiana Ovchinnikova2021-09-211-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Manage members dialog has a dropdown which lists all the role names. If a role name is long enough, it pushes all the roles to the left and hides them partially. This patch adds horizontal scrollbar for such cases. Closes-Bug: #1926511 Change-Id: I1bbf3b23717f9924974920d6569e018b94e3dbe8 (cherry picked from commit 9b28ab402802e9848f5824b04d85cf4292f738d3)
* | | Merge "Fix Project Limits for resize instance dialog" into stable/wallabyZuul2022-04-191-20/+20
|\ \ \
| * | | Fix Project Limits for resize instance dialogTatiana Ovchinnikova2022-02-281-20/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resize instance dialog should use proper calls for quota and usage. This patch fixes that. Change-Id: Ied6fd4ad69b38a721b23700c98344e0edf14771b (cherry picked from commit e2bb7d833526e3ea6117cb2a5d58cbf90548c6da)
* | | | Change to a proper policy for Resume operationKeigo Noha2022-03-252-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, ToggleSuspend class checked 'os-rescue' policy for resuming an instance. To align to resume operation, this fix changes to 'os-suspend-server:resume'. Closes-Bug: #1963652 Change-Id: If6386ecdb81fb1f0d88dab447ee81c251b9857b7 (cherry picked from commit 29da801528a357449264e546182bd629f4654275) (cherry picked from commit db40c8ceb6c403bc94ac839f65c00805a5e4ff66)
* | | | Fix for "Resize instance" buttonThomas Goirand2022-03-095-22/+103
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, "Resize instance" widget is not working because it relies on legacy Nova API v2.46, obsoleted in Pike release. Proposed patch make Horizon use current Nova API (>=2.47). Note: It also cherry-picks a7956cd004 from the master branch which avoids the extra call of flavor_get in resize server form. Closes-Bug: #1940834 Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: Id2f38acfc27cdf93cc4341422873e512aaff716a (cherry picked from commit 4f4e8800904dc98a696c5aebe3ffcc947e2deabc)
* | | Imported Translations from ZanataOpenStack Proposal Bot2021-11-211-8/+63
| | | | | | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I97bd92b2953fd9bf166845e650f060718a9143ef
* | | Merge "Escape unicode characters when setting logout_reason cookie" into ↵Zuul2021-10-184-11/+21
|\ \ \ | | | | | | | | | | | | stable/wallaby
| * | | Escape unicode characters when setting logout_reason cookieRadomir Dopieralski2021-09-224-11/+21
| |/ / | | | | | | | | | | | | | | | Change-Id: Ic61a3958461a4a939acc40d1039881e2d4c3a1cd Closes-bug: #1894801 (cherry picked from commit e68e23937341d03be7475d71903f31a61403c1e2)
* | | Imported Translations from ZanataOpenStack Proposal Bot2021-10-022-6/+28
| | | | | | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I57240345acec490fd48c8308085fea44136a6183
* | | Dropping lower constraints testing from stable branchesmanchandavishal2021-09-223-164/+0
|/ / | | | | | | | | | | | | | | | | | | | | This topic was discussed on the ML and QA team proposed to test lower constraints [1]. As decided in horizon weekly meeting in the past[2], stable branches will drop the lower-constraints job from CI. [1]http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html [2]https://meetings.opendev.org/irclogs/%23openstack-meeting-alt/%23openstack-meeting-alt.2021-03-24.log.html#t2021-03-24T15:12:58 Change-Id: I3f4367817cdf04eacacba8b2ba2bbc06b09d3132
* | Merge "Fix Unable to use multiattach volume as boot for new server" into ↵Zuul2021-07-293-4/+5
|\ \ | | | | | | | | | stable/wallaby
| * | Fix Unable to use multiattach volume as boot for new servermanchandavishal2021-07-283-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we try to create a new server from a bootable volume that supports multiattach, it will fail to create with an error message that ``multiattach volumes are only supported starting with compute API version 2.60``. This patch fixes the issue. Closes-Bug: #1931440 Change-Id: Ic8330b947b1a733f70c3bdad8b3493f20a2f26fb (cherry picked from commit 64fe0abb653950c85d455dedd09ef42856c6b07b)
* | | Change with_data=False for swift_get_containerTobias Urdin2021-07-192-2/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function is only used in the Container get method which retrieves details about a container. It's not used for listing data in the container even though with_data was True doing a GET instead of a HEAD on the container. This indirectly also fixes the Ceph bug [1] in the Swift API implementation that doesn't expose metadata correctly for a GET but does for a HEAD. [1] https://tracker.ceph.com/issues/47861 Change-Id: Iba4215b2e3a414d1794faa05be31bf69e0e48bec (cherry picked from commit c87f0e7a90d05f9355bd58165c25561dedae36d5)
* | Imported Translations from ZanataOpenStack Proposal Bot2021-06-252-10/+7
|/ | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I82e2fc10ee4cdd580c91bccfd7365ce9724e105e
* doc: Update our IRC server to OFTCAkihiro Motoki2021-06-041-1/+1
| | | | | Change-Id: I985ea0b19a96e5e3160b824efda20659d855c2dc (cherry picked from commit cdb08a1ad6b01693d30de9c27b809652af77ab27)
* Imported Translations from ZanataOpenStack Proposal Bot2021-05-256-83/+703
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: Ia3bd62bc51c9f7ffb874adcd68be0aab9fb026ed
* Imported Translations from ZanataOpenStack Proposal Bot2021-04-205-55/+13
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I7930404ebd56bfdd1b2c949d857be0d740517bb5
* Imported Translations from ZanataOpenStack Proposal Bot2021-04-1516-28981/+487
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I869cc5fbb278e39ea4f2777a9660ddac60e9496a
* Merge "Use policy_rules for user role assignment and group tabs" into ↵19.2.0Zuul2021-04-091-8/+2
|\ | | | | | | stable/wallaby
| * Use policy_rules for user role assignment and group tabsMark Goddard2021-04-081-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | The policy_rules feature was added recently, which simplifies making tabs allowed conditionally based on policy. Use the feature for the User role assignments and groups tabs. This is a separate commit to allow the original patch to be backported. Related-Bug: #1920214 Change-Id: Ic4a16b27c4f2da0daa2ec066d129926c349d1e4b (cherry picked from commit f0736c5174f18476bf5d0a9df6a65c554ee7c65e)
* | Merge "Move "Domain" field under "User Name" and "Password"" into stable/wallabyZuul2021-04-081-4/+2
|\ \
| * | Move "Domain" field under "User Name" and "Password"Tatiana Ovchinnikova2021-04-071-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Autofocus on the login screen now is on the first field. It's either "User Name" or "Domain" with multidomain support. However it appears to be more convenient to keep the focus on "User Name" whether there is multidomain support or not. Also "Domain" is pre-filled with the last domain used, so often there's no need to change it. This patch moves "Domain" field under "User Name" and "Password" and keeps autofocus always on "User Name". Closes-Bug: #1916958 Change-Id: I590ce3a5cbaa0ebb470228a7114a60ff89467835 (cherry picked from commit b09e5b303c8ba0e967e5178794a39fcee628e4e0)
* | | Merge "Replace Delete Force Volume Backup with Force Delete Volume Backup" ↵Zuul2021-04-081-4/+4
|\ \ \ | | | | | | | | | | | | into stable/wallaby
| * | | Replace Delete Force Volume Backup with Force Delete Volume Backupmanchandavishal2021-04-071-4/+4
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch replaces the Delete Force Volume Backup/Backups with Force Delete Volume Backup/Backups as Delete Force Volume Backup looks incorrect. It also drops the usage of unicode prefix from ``admin/backups/tables.py`` file. Closes-bug: #1919120 Change-Id: I02f88b6444d268253a3888e2ba56a33bb2f51e73 (cherry picked from commit 893d0c026eaca47f6d2821100fb9cf3e2d2e6843)
* | | Merge "Get the timezone offset for the current day instead of January 1st." ↵Zuul2021-04-086-5/+27
|\ \ \ | | | | | | | | | | | | into stable/wallaby
| * | | Get the timezone offset for the current day instead of January 1st.David Hill2021-04-076-5/+27
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This bug only appears to be a cosmetic one where the TZ offset would be calculated on current_year/01/01 so would remain in daylight saving offset when displaying the timezones list. (Note by amotoki) The minimum version of Babel is bumped to 2.6.0 as Babel 2.3.4 returns "New Zealand Time" instead of "New Zealand (Auckland) Time" returned from the latest Babel (2.9.0). It is not a good idea to handle such difference in Babel in our UT and there is no reason to stick to Bump 2.3.4. 2.6.0 was chosen as it is available in Ubuntu Focal and there is no more reason than this. Change-Id: I0600086cc51cf5abcf1631565e75146114189667 Closes-bug: #1822849 (cherry picked from commit f60220329accd9c6492acfc25fe024c394e3eaea)
* | | Merge "handle missing access_rules" into stable/wallabyZuul2021-04-081-6/+9
|\ \ \
| * | | handle missing access_rulesLars Kellogg-Stedman2021-04-071-6/+9
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we delete the "access_rules" field from the form if keystone API version is less than 3.13, but we don't consider the case in clean() method. We are in Wallaby development cycle and we support N-4 release for upgrade [1]. This means horizon can run with Stein keystone. Pre-3.13 keystone API (i.e., 3.12) is part of Stein release [2], so it makes sense to consider this condition. [1] https://docs.openstack.org/horizon/latest/contributor/policies/supported-software.html [2] https://docs.openstack.org/api-ref/identity/ Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I02e124d90f99d400d8c59bff2c563fdc85e624d4 (cherry picked from commit dadd45addab8fe9ac582f16c3fbc19ff7d81c597)
* | | Merge "Don't load user role assignment or groups tabs for non-admins" into ↵Zuul2021-04-081-0/+8
|\ \ \ | | |/ | |/| | | | stable/wallaby
| * | Don't load user role assignment or groups tabs for non-adminsMark Goddard2021-04-071-0/+8
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a non admin user, navigate to Identity -> Users. Then click on the username of your user to go to the detail page. Only the allowed Overview tab is visible. The view shows three tabs: Overview, Role assignments, Groups. Click on either Role assignments or Groups. An error will appear, showing that the API call is unauthorised, and the table content will fail to load. This change fixes the issue by conditionally loading the tabs based on policy. Closes-Bug: #1920214 Change-Id: Ic8b723e6fd423b96a4f5eff54f9392cee534ed9e (cherry picked from commit 60cf32031565ed8b4b2a4a39380a060997c9d9e4)
* | Merge "Save instace_id inside Associate Floating IP workflow" into ↵Zuul2021-04-083-16/+22
|\ \ | | | | | | | | | stable/wallaby
| * | Save instace_id inside Associate Floating IP workflowRadomir Dopieralski2021-04-073-16/+22
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, rename instance_id field to proper port_id. Before this change, when instance_id was passed from the Instances page in the URL, the information would be lost on form submission, and if the form contained an error, the it would be redisplayed with the port drop-down containing all ports from all instances. This also made submitting this form slow, as the drop-down would be populated with all ports on form validation. It also creates a bug, where if there are more instances than Nova's pagination allows, the ports from newer instances would no longer appear in the drop-down, and the form would fail to validate, even though the choice of port on initial form was correct. Closes-bug: #1920010 Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb (cherry picked from commit 3d82d57353d1a29fb5b568ffaa93db86998e9d94)
* | Update cirros image to cirros-0.5.2-x86_64manchandavishal2021-04-072-3/+3
|/ | | | | | | | | Due to this change I12e0bdb3699e5343592ab834468ba6b2fcdcaaf4 our integration job is failing. This patch update cirror image version to fix our CI. Change-Id: I991fb9750ab9e35b67b06154764487375dd11d73 (cherry picked from commit a42235f6f77521e153dd5ab5cbadf3c795020f72)
* Update TOX_CONSTRAINTS_FILE for stable/wallabyOpenStack Release Bot2021-03-301-2/+2
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/wallaby branch, tests will continue to use the upper-constraints list on master. Change-Id: Ib6944bf7f8239e89b11074444579b358a68632c8
* Update .gitreview for stable/wallabyOpenStack Release Bot2021-03-301-0/+1
| | | | Change-Id: I67a3248eb3b32183c1ae957d4b04cf311bf51dfd
* Merge "Deprecate Django launch instance form"19.1.0Zuul2021-03-104-0/+37
|\
| * Deprecate Django launch instance formAkihiro Motoki2021-03-094-0/+37
| | | | | | | | | | | | | | | | | | As discussed in the horizon meeting, we think that feature gaps between the two implementations have been closed. Let's mark the Django version as deprecated and gather more attentions from operators. Change-Id: I55379c0897bad46decfabb443afe9439a31a3164
View Lorry Controller Status