summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Consume tempest-horizon from PyPI releaserocky-eolstable/rockyAkihiro Motoki2021-02-181-3/+1
| | | | | | | | | | | tempest-horizon has been retired (at least in the project-config level), so we cannot specify openstack/tempest-horizon in required-projects. Instead we need to install tempest-horizon from PyPI. The similar approach is adopted in stable/stein [1]. [1] https://review.opendev.org/c/openstack/horizon/+/771740 Change-Id: I80d67384a643362746c2e037da539503a8095d7b
* Merge "Fix open redirect" into stable/rockyZuul2020-12-233-3/+42
|\
| * Fix open redirectRadomir Dopieralski2020-12-083-3/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure the "next" URL is in the same origin as Horizon before redirecting to it. Conflicts: horizon/test/unit/workflows/test_workflows.py Change-Id: I06b2bfc8e3638591615547780c3fa34b0abe19f6 Closes-bug: #1865026 (cherry picked from commit 252467100f75587e18df9c43ed5802ee8f0017fa) (cherry picked from commit baa370f84332ad41502daea29a551705696f4421) (cherry picked from commit 6c208edf323ced07b15ec4bc3879bddb91d398bc)
* | Cap bandit for python 2.7 envAkihiro Motoki2020-12-112-2/+3
|/ | | | | | | | | | | | | | | | | bandit 1.6.3 supports only python>=3.5 and rokcy jobs with python 2.7 are broken when bandit 1.6.3 is being installed. bandit <1.6.3 supports python 2.7. We have no constraint for test only libraries so we need to cap it. This change is only required in rocky or older releases, so it is directly proposed to stable/rocky. doc/requirements.txt also needs to be updated to pass the requirements-check job as global-requirements.txt in the requirements repo was updated after the rocky release. Depends-On: https://review.opendev.org/c/openstack/requirements/+/766426 Change-Id: Iae6c7abecd1aec9db00c14f29fd98dd1a8682084
* Fix horizon-nodejs jobsAndreas Jaeger2020-08-202-1/+44
| | | | | | | | | | | | | | | | | | | | | | Tox is not anymore pre-installed on the OpenDev CI images. The file package.json needs tox, install it to fix the job. Install it via a pre-run playbook so that this is run in addition to all of the playbooks of the parent. Note for the reviewer in stable/stein we run nodejs-4 jobs as runtime. I have cherry-pick this change from master which run nodejs-10 job but simliar changes fixes the nodejs-4 jobs So I have added pre-run playbook for nodejs-4 job as well. Note in stable/rocky: We used nodejs4-jobs from openstack-zuul-jobs which consumes npm jobs from zuul-jobs. We would like to install tox in the 'pre-run' phase in each npm job, so this commit borrows the npm job definitions in stable/stein including the cherry-picked commit. Change-Id: Icf82fa96f7d90453f78cf564c847682a286ed575 (cherry picked from commit 7cd0debebe1a300a96f8d0f21626793be0a0bc41) (cherry picked from commit 8da0dcd21200cc851e57de4dfa46c3c838c73c3c)
* Fix tenant_id for a new port.shenjiatong2020-04-274-2/+73
| | | | | | | | | | To successfully create a port in a shared network which belongs to a different tenant, the tenant of the new port should be same as the tenant of a request user. Closes-bug: #1815461 Change-Id: Ia243f213b23f3f34845de5d97e8eaa5aa6979e76 (cherry picked from commit 3c33f46dc8196809d67301f20c8b920cad03b372)
* Fix .zuul.yaml syntax errorsAndreas Jaeger2020-04-251-1/+1
| | | | | | | | | | | | Zuul complains about: "bad escape \l at position 3" Fix the regex. This is a partial backport of change I70851622a91280eab99005bf285d8190bfbf8933. Change-Id: Ia12834d2f38a39e5773f954e80f6e869207e865b
* Merge "Authenticate before Authorization" into stable/rockyZuul2020-04-221-3/+3
|\
| * Authenticate before AuthorizationJacek Tomasiak2020-04-011-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When user is not logged in and given Dashboard has some `permissions` defined, `require_perms` decorator was raising `NotAuthorized('You are not authorized to access %s')` instead of `NotAuthenticated('Please log in to continue.')`. This was caused by the order of decorating the views. The decorator which is applied last is called first in the chain as it wraps the decorators which were applied before. This means that to check for authentication before checking permissions we need to apply the `require_auth` decorator after `require_perms`. Closes-Bug: 1869708 Change-Id: I94d3fa5c1472bb72c9111cab14c6e05180f88589 (cherry picked from commit e4fd69292c4a8340eba33f5c9d516796472e9269)
* | Gate fix: use tempest-horizon 0.2.0 explicitlyAkihiro Motoki2020-04-221-0/+1
|/ | | | | | | | | | tempest-horizon master no longer support python 2.7, but the tempest job in stable/rocky (and older) runs with python 2.7. tempest-horizon 0.2.0 is the last release with python 2.7, so we need to use the version explicitly. Change-Id: Ia5ae3aa2b024f554eb8c068b9cc271998db6f909 Closes-Bug: #1874171
* Merge "Ensure python versions" into stable/rockyZuul2020-02-101-1/+3
|\
| * Ensure python versionsAkihiro Motoki2020-01-111-1/+3
| | | | | | | | | | | | | | | | | | | | It looks like better to specify basepython for all tox envs. As of the rocky release, we used python 2.7 by default, so this commit adds python 2.7 for tox envs which have no default python. http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010957.html Change-Id: I586d1f63039b71f2ec757b06eb32a30a52705568
* | Fix typo in publicize_image policy namerocky-em14.1.0Ivan Kolodyazhny2020-01-172-1/+12
|/ | | | | | | | | | This patch is not cherry-picked from stable/train because if was fixed in a scope of a new feature implementation with https://review.opendev.org/#/c/602468/ commit. Change-Id: I519e15afc975e6da2afb9c72a05448541572bd10 Closes-Bug: 1859041 (cherry picked from commit fe61f2358a6e16ea462630747180b83337eb5b55)
* Fix "prev" link pagination for instances with identical timestampsKeithMnemonic2019-12-272-13/+29
| | | | | | | | | | | | | | | | This patch resolves an issue with the "prev" link when instances have identical "created_at" values. This can occur when creating instance using the "min/max count" option. The reverse sort does not work correctly as the server list returned from nova is not an exact reverse as the forward sort. It looks like the combination of sort_keys must be unique to ensure the forward and reverse pagination properly. As a workaround 'uuid' (server ID) is added to 'sort_keys'. In addition, 'display_name' is added before 'uuid' in 'sort_keys' to list servers in the alphabetical order (which sounds natural). Closes-Bug #1856243 Change-Id: I73234b2c69ce8ea648b4a9721abe4f5670031909 (cherry picked from commit 9637d733749d741d5aac3b89b92e100d32fbdbb0)
* Merge "Fix deleting port from port details page" into stable/rockyZuul2019-12-091-1/+2
|\
| * Fix deleting port from port details pageTatiana Ovchinnikova2019-12-031-1/+2
| | | | | | | | | | | | | | | | | | This patch fixes "Delete port" button at the port details page: Project -> Network -> Networks -> <network name> -> Ports -> <port name> Change-Id: I84f4da9c84d75c458b54bd456cbc7b92b303ba81 Closes-Bug: #1854514 (cherry picked from commit 18020e30b67efa9e67d061c317804a6f800b74c7)
* | Merge "Fix tenant floating_ip_allocation call in neutron rest api." into ↵Zuul2019-12-092-2/+2
|\ \ | | | | | | | | | stable/rocky
| * | Fix tenant floating_ip_allocation call in neutron rest api.Sam Morrison2019-11-292-2/+2
| |/ | | | | | | | | | | | | | | | | The call to allocate a new floating IP was incorrecting calling tenant_floating_ip_allocate, this is used by neutron-lbaas-dashboard. Change-Id: Ia4d1367ccd309a074a0ea84a555d7de6c07971a6 Closes-bug: #1831954 (cherry picked from commit 92d832028df65cb95030b2a585764a62dc1c0b75)
* | Add "prev" link to instance page list paginationFerenc Cserepkei2019-11-267-221/+489
|/ | | | | | | | | | | | | | | | | | | | | Currently there is no link to previous page at paginated instances table. This patch resolves that issue by re-using the pagination code for flavors. It also supports Ying Zuo's scenario: After I set only 1 item per page and deleted the instance on the first page, the expected behavior is showing the next instance in the table after one is deleted. xxxIndexView uses PagedTableMixin's _get_marker() from now instead of GET()- ing the markers Closes-Bug: #1274427 Co-Authored-By: Dmitry Ratushnyy <dratushn@cisco.com> Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: Id8eaae6bf1b5d6f42291291655e14b8715c08bc8 Signed-off-by: Ferenc Cserepkei <ferenc.cserepkei@ericsson.com> (cherry picked from commit 467669417979ec7443d5195d4b4635d5596cdc08)
* Call Glance list with certain image idsBubaVV2019-11-224-41/+110
| | | | | | | | | | | | | | | This patch uses glance list filtering, which allow to query images for the list of required ids. See [1] for details. Patch rebased to master. Added test for proposed Glance API request [1] https://developer.openstack.org/api-ref/image/v2/#show-images Related-Bug: #1508554 Co-Authored-By: Ivan Kolodyazhny <e0ne@e0ne.info> Co-Authored-By: Vadym Markov <markov.vadim@gmail.com> Change-Id: Iac485c1b448011fec97ba5bfaa83851914b294d9 (cherry picked from commit deb55b8411434b32a2ea92f1a825e7dea36deea5)
* Fix aes-xts key length in Horizon Admin Guide / Manage VolumesKeith Berger2019-10-221-8/+3
| | | | | | | | | | | When using aes-xts-plain64, a 512 bit key produces an error as this is not a supported barbican key length for aes-xts-plain64. This patch updates the horzion admin doc to remove the reference of a 512 bit key. Change-Id: Ie36e05a1e59eb88b779c9f3249a714c20b5f5fe0 Closes-Bug: #1708505 Closes-Bug: #1849196 (cherry picked from commit 85a1dddf126691921924edcecaee5c054c7df6c2)
* Remove the check which causes plugin's quotas update failure14.0.4Gloria Gu2019-10-101-3/+0
| | | | | | | | | | | | | | | | | | The check causes external plugin's quotas fields unknown exception because the quotas fields are not part of QUOTA_FIELDS which only includes the fields for cinder, neutron and nova. Meanwhile the exception message throws TypeError. This commit removes the uncessary check. It also helps fix the manila-ui's bug #1842119 Change-Id: If093f4ecf1e344792b347c5c338b441b1ab42a04 Closes-bug: #1798048 Closes-bug: #1842119 (cherry picked from commit 44987f02be671fd81b3dcd8d22f9fa1b219488c2) (cherry picked from commit be4d2301bb9654a772990d5d6f7bb2b126c7c127)
* Merge "Add Allowed Address Pair/Delete buttons are only visible to admin" ↵Zuul2019-10-093-0/+186
|\ | | | | | | into stable/rocky
| * Add Allowed Address Pair/Delete buttons are only visible to adminShilpa Devharakar2019-09-263-0/+186
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initially In Queens, when logging into Horizon in context of a _member_ in any project, the "Add Allowed Address Pair" and "Delete" buttons in "Network" -> "Networks" -> <select a network> -> "Ports" -> <select a port> -> "Allowed Address Pairs" are not visible. When accessing the same panel in context of a project where the user has the admin role, the "Add" and "Delete" button is visible and functional. This patch fixes the above issue by updating the policy_target. Change-Id: Ia7db6c2881c72580a156eb97b11bb51f295cfbce Closes-Bug: #1794421 (cherry picked from commit 87b57dfe7113da09715d5613ab9c91c15a75c189)
* | Updated max-width to be dynamic for .member classGloria Gu2019-10-012-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When member name is longer than $members-list-item-width (130px) in members list (for example, project group in Edit Project), current text-overflow will put ... (ellipsis) at the end of the name and name will be truncated. Updated the styling of .member class to make max-width dynamic 80% and wrap the name in case it is really long. Change-Id: Ic295a9b1e7fd3525c633d51a60054e713da6a657 Closes-bug: #1843480 (cherry picked from commit b635e625f75744938cde49fd250dd1a5f36ca1b7) (cherry picked from commit 6b9ddde90096be58510f3e99e81a04211d8f66b4)
* | Merge "Avoid forced logout when 403 error encountered" into stable/rockyZuul2019-10-014-15/+17
|\ \
| * | Avoid forced logout when 403 error encounteredGloria Gu2019-09-254-15/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this change when a 403 error was encountered, such as failure to have the permission to perform an operation, the user would get logged out from UI pages written in the AngularJS framework. For example, if an admin user lacks the get_project permission and tries to access the images page, project->compute->images, the 403 will forcibly log out the user. This change keeps the user logged in when a 403 error is encountered and displays an error message. The change only affects AngularJS pages. Change-Id: I10a6eeb96dd1418449e1d15b1a3869cd4de9cafa Closes-bug: #1840844 (cherry picked from commit ab0e96df9506fb6f1783e0ee79b63934dabe0cbe)
* | | Merge "Fix listing security groups when no rules" into stable/rockyZuul2019-09-264-4/+19
|\ \ \ | |_|/ |/| |
| * | Fix listing security groups when no rulesAkihiro Motoki2019-09-144-4/+19
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | When listing security groups in the dashboard and one or more security groups had no rules it failed because python throws a KeyError. This commit changes the neutron API wrapper in horizon to ensure ensure rule information in SG always exists. Closes-Bug: #1840465 Co-Authored-By: Tobias Urdin <tobias.urdin@binero.se> Change-Id: I6e05a7dc6b6655514ee2bff6bd327da86f13900a (cherry picked from commit cdb191ec83f86dffade56be07ca53077d7c78b14)
* | Merge "Allow creating ICMPV6 rules" into stable/rockyZuul2019-09-171-0/+31
|\ \ | |/ |/|
| * Allow creating ICMPV6 rulesRadomir Dopieralski2019-08-261-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now, even if we specify a ::/0 (or other IPv6) CIDR in an ICMP rule, Horizon sets 'icmp' as the ip_protocol of that rule but neutron expects 'ipv6-icmp' which is the right ip_protocol for ICMPv6. This results in that rule never matching anything. This change makes Horizon set the ip_protocol to ipv6-icmp when the CIDR is an IPv6 one, and icmp when it's IPv4. Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I1f68e1e5a3e073e38ac258de5ed9c43f8acb04e9 Closes-Bug: #1652619 (cherry picked from commit d5dcf1be93d9bb26bda7b375e41f03dd297888bb)
* | Fix quoting in zuul for tempest pluginsIvan Kolodyazhny2019-09-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Something has changed and the quoting used in the zuul jobs configuration no longer works. This patch removes the excess quoting. Conflicts: .zuul.yaml Change-Id: I4c6c3b1d0e0c38c8130440c2b6c162fd65532179 (cherry picked from commit e17325dd3bcedffe0b1a96c02b00e918d191a743)
* | Merge "Ensure to call patch_middleware_get_user() in api.test_base" into ↵Zuul2019-09-101-1/+1
|\ \ | |/ |/| | | stable/rocky
| * Ensure to call patch_middleware_get_user() in api.test_baseAkihiro Motoki2019-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | ApiHelperTests.test_url_for in openstack_dashboard.test.unit.api.test_base depends on keystone user and token information. To make this work, we need to call utils.patch_middleware_get_user(). This commit changes ApiHelperTests to inherit APITestCase. Change-Id: I3848f756604262b07700a65e9be5bacd48da191f Closes-Bug: #1815285 (cherry picked from commit 4bf069bb9292710ed86be245c1b091b0a7a7d678)
* | Fixing broken linksAlexandra Settle2019-08-152-2/+2
| | | | | | | | | | | | | | | | The bootswatchr host never resolves. I found this as the new option. This may need to be confirmed by others. Change-Id: I7694962b271b60c77c1a2846fd3cad5e02a06acd Backport: stein rocky
* | Make project volume group table work even with volumev3 only envAkihiro Motoki2019-06-073-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the volume group table in the project dashboard checked if 'volume' endpoint is available and 'volumev3' endpoint was not checked. 'volumev3' is an endpoint name commonly used for Volume v3 API and it is not surprising that only volumev3 is configured in deployments, so we should ensure that horizon works with environments only with 'volumev3' endpoint. The service endpoints are already checked in panel.py, so there is no need to have the permission check (i.e., service check) in the table. Similar patterns are found in tables in project/snapshots and project/vg_snapshots. They are also cleanup by this commit. Change-Id: I12d03745bec5d8dec10a8e2b4306c595f2f39560 Closes-Bug: #1829461 (cherry picked from commit 0cb5167b99d418c7ce8cbc9adda24f228fdd42d0)
* | Merge "Complete angular translation extract pattern" into stable/rockyZuul2019-05-272-3/+21
|\ \
| * | Complete angular translation extract patternfrancotseng2019-05-122-3/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently AngularGettextHTMLParser parses translations of form {$ 'content' | translate $}. However, there is another form in projects' html files: {$ ::'content' | translate $}. This commit fine-tunes the filter_regex and related handle_xxx functions to extract both forms of translations. Closes-Bug: #1824644 Change-Id: I7129a13d046b699328b77267ae4936d31af8144c (cherry picked from commit 5de40b3f397f812d5236a274b22515b18118015c)
* | | Imported Translations from ZanataOpenStack Proposal Bot2019-05-251-6/+6
| | | | | | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I441bde37c8c9dc7f55601d436cf7a33f1d670136
* | | OpenDev Migration Patch14.0.3OpenDev Sysadmins2019-04-192-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
* | | Merge "Not implicitly set vol_device_name to vda" into stable/rockyZuul2019-04-112-19/+0
|\ \ \ | |/ / |/| |
| * | Not implicitly set vol_device_name to vdaEric Desrochers2019-04-012-19/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using a scsi decorated image with: hw_disk_bus='scsi' hw_scsi_model='virtio-scsi' This solve the case where an instance is launched with 'image' selected as boot source with a new volume. This will result in /dev/vda instead of /dev/sda as it should. Not specifying device name in setFinalSpecBootImageToVolume() leaves the decision to nova to determine it. Example: ------- VM boot volume without scsi meta data decoration: Attached To 0a0cd660-7ce3-4033-9983-2e1099edc5f0 on /dev/vda VM boot volume with scsi meta data decoration: Attached To 91f50dbc-8bdf-4293-84ea-fc5df27b5ee4 on /dev/sda -------- Note: This commit doesn't address cases for where instances are launched using existing volume and snapshot, this will involve more work to migrate the code from BDMv1 to BDMv2. Closes-Bug #1560965 Change-Id: I9d114c2c2e6736a8f1a8092afa568f930b656f09 (cherry picked from commit 4788c4d2f59b8aa08e5f599a6d2c327b6004dc0c)
* | | Imported Translations from ZanataOpenStack Proposal Bot2019-04-051-8/+10
|/ / | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I30b1c6585e5e5545e93cd03d03b87bc37cea5e65
* | Imported Translations from ZanataOpenStack Proposal Bot2019-03-291-4/+5
| | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: Ib04adcbe30b839a9d3346fcdf81bad7371ab39f8
* | network topology: handle port AZ correctlyAkihiro Motoki2019-03-221-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously d3 version of the network topology view handles ports with device_owner 'compute:nova' and 'compute:None' specially. This leads to the situtaion that neutron ports with non-default AZ are not shown properly. There is no reason to handle neutron ports with the default AZ differently. What we would like to do is just to classify neutron ports attached to nova servers. This commit changes the logic to check device_owner of ports have a prefix 'compute:'. Note that we also need to check if device_owner is a string before checking the prefix. Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d Closes-Bug: #1820260 (cherry picked from commit ffbe0e2f2f96556f4476ea3873af1bc628c879ca)
* | Merge "Update geckodriver to version 0.23.0" into stable/rockyZuul2019-03-141-1/+1
|\ \
| * | Update geckodriver to version 0.23.0Ivan Kolodyazhny2018-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | The latest selenium webdriver fails with old geckodriver. This patch also fixes horizon-selenium-headless job. Change-Id: I8dfdc7e80dfe680d6699fc7f1f8325b85a9f7c8f (cherry picked from commit e3bfad6ade9cd6eb8498a41a0a9256c456f9cec5)
* | | Don't use check_for_language in the user settings formRadomir Dopieralski2019-03-071-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | That function is buggy and can't handle the Chinese language codes. Closes-Bug: #1818639 Change-Id: I6ea03949f3ad6db82f5965de3fa028a84edf6cf3 (cherry picked from commit 6372a689e20252e4a18a59a6ded8841bfa5ed004)
* | | Merge "Imported Translations from Zanata" into stable/rockyZuul2019-03-061-12/+12
|\ \ \ | |_|/ |/| |
| * | Imported Translations from ZanataOpenStack Proposal Bot2019-03-011-12/+12
| | | | | | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I77a6686db5539b8fd7fb75cfe073e4188c960d18
View Lorry Controller Status