| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: I68ca9943bd611061cf34f79d786b161226f13171
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Docutils 0.10 breaks manpage generation in sphinx 1.1.3. A fix to
sphinx has been merged, but not yet released (scheduled for dec
24-31). In the mean time, we should pin docutils to 0.9.1.
Similar change was present before as
I157f3c191bfc09d2191a3508d81bcbaea56205a6 but was incorrectly removed by
later requirements syncs.
Closes-Bug: 1091333
Change-Id: I157f3c191bfc09d2191a3508d81bcbaea56205a6
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Check that host is not none before trying to parse the services that
are up in each availability zone
Change-Id: I757f35ca2fa84da3441b544280c1c430bf3e8fb8
Closes-Bug: #1297920
(adopted from commit 7f30ab5124618c5b11eebf9c6d69bcfd8a47adc3,
change path from 'dashboards/admin/aggregate' to
'dashboards/admin/info')
Original fix by Santiago Baldassin <santiago.b.baldassin@intel.com>
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
New tox (>=1.7.0) sets a random python hash seed by default. This is
generally good for testing because it will help keep projects working
regardless of the hash seed, but horizon unittests don't currently pass
with a random hash seed so set it to the python default seed.
This change will allow us to use new tox again and remove the
restriction on tox<=1.6.1 to run unittests.
Also see Ib54364877a251db48c54dfdc43c503281ea1f04a.
Change-Id: I8834487e8c7bcdbeae8397c1a10a18873976ce61
Partial-Bug: #1348818
(cherry picked from commit b30072e47ead3625cbf29a3b2955cae19a8e7533)
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
When using the unordered_list filter in a Horizon table (as opposed to
a template directly), autoescaping is not set by default and the input
wasn't sanitised.
Closes-Bug: #1349491
Change-Id: Id82eefe48ccb17a158751ec65d24f3ac779380ec
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Don't access keystoneclient's UserManager in tests. This should be
considered private data of keystoneclient and is not actually used by
horizon tests.
Conflicts:
openstack_dashboard/test/test_data/keystone_data.py
Change-Id: I261e79b31dfc7388adb3dc63a3a5e54042f05e54
Closes-Bug: #1347236
(cherry picked from commit 821619fff324ba1bc3f697f585a0c350573f24a2)
|
|\ \
| | |
| | |
| | | |
stable/havana
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Ensure user emails are properly escaped
User emails in the Users and Groups panel are being passed through the
urlize filter to transform them into clickable links. However, urlize
expects input to be already escaped and safe. We should make sure to
escape the strings first as email addresses are not validated and can
contain any type of string.
Closes-Bug: #1320235
* Ensure network names are properly escaped in the Launch Instance menu
Closes-Bug: #1322197
* Escape the URLs generated for the Horizon tables
When generating the Horizon tables, there was an assumption that only
the anchor text needed to be escaped. However some URLs are generated
based on user-provided data and should be escaped as well. Also escape
the link attributes for good measure.
* Use 'reverse' to generate the Resource URLs in the stacks tables
Closes-Bug: #1308727
Conflicts:
horizon/tables/base.py
openstack_dashboard/dashboards/admin/users/tables.py
Change-Id: Ic8a92e69f66c2d265a802f350e30f091181aa42e
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
Sphinx-1.2b3 is failing with this error: "'source_dir' must be a
directory name". This change prevent that sphinx version from being
pulled, it's a backport of 6a276638
Change-Id: Ic63d776bec5c0ace7207a532c29ee193d171ee63
Closes-Bug: #1339273
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The Login form lives in openstack_auth.forms and should be directly
imported from that file.
Change-Id: I42808530024bebb01604adbf4828769812856bf3
Closes-Bug: #1332149
(cherry picked from commit 345ccc9d503e6e55fe46d7813958c0081cc1cffe)
|
|\ \
| | |
| | |
| | | |
stable/havana
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the class FloatingIpManager, the function filters the
resulting list of ports with all available floating ips.
The function now returns the target ID of a port with a
floating IP associated to it. Added a new function to get
this to pass. In the next phase is to refactor the
floating ip api to allow a finer granularity. This will
be useful later for managing floating ips.
Conflicts:
openstack_dashboard/dashboards/project/instances/tables.py
Change-Id: I02286dbbb60318b0157992622ffdeeae45a71bc1
Closes-Bug: 1265872
(cherry picked from commit 86f87944900e6e713d2baaacec18f55cbe81d878)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The image list in Rebuild Instance is constructed from (id, name)
pairs. As the name is a string, the transform function is never called
unless image name is None. In that case it crashes the view.
This change:
- Builds the image list with (id, image) so the correct thing
is passed to the transform
- Corrects the size/name attributes
- Handles None display name (displays id instead)
- Set the name of one of the public images in glance_data.py to
None so errors like these are picked up in the future.
Change-Id: I0d1f8594cccc404c0dd6f254b70d23789817dd06
Closes-bug: #1258349
(cherry picked from commit c720b4f90e59ad76ef846c8ba5b6b6d91883ee66)
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
project/instances, admin/instances and the instance details page
all get networking information from Nova. However, with Neutron
enabled, floating IP associations are done direcly with Neutron,
meaning that Nova's DB will fall out of sync and thus the GUI
won't reflect successful floating IP associations until Nova
polls Neutron again and updates its DB. The polling can take
up to several minutes to complete for consecutive floating IP
operations.
The solution is to update instances' networking information from
Neutron immediately after the call to list Nova instances.
Conflicts:
openstack_dashboard/dashboards/project/instances/tests.py
openstack_dashboard/dashboards/project/instances/views.py
Closes-Bug: #1265032
Change-Id: I0382fa9a4a9fff21e7b4d05cd3b76783f826735f
(cherry picked from commit 715d6b822838009530b7792cd7749164ae3fc663)
|
|/
|
|
| |
Change-Id: I396562a89b4f21d486e2ab83b829047f8c3609f5
|
|
|
|
|
|
|
|
|
|
| |
In Instances panel, associate and disassociate
Floating IPs now will be consistent.
Fixes bug #1247245
Change-Id: I6a84c43b8bc69fa08c63abff5343144cc4000c37
(cherry picked from commit 348ffe41c49a9a23c9c7da65cbceaf363b13a95e)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Escape help_text a second time to avoid bootstrap tooltip XSS issue
The "Description" parameter in a Heat template is used to populate
a help_text tooltip in the dynamically generated Heat form. Bootstrap
inserts this tooltip into the DOM using .html() which undoes any
escaping we do in Django (it should be using .text()).
This was fixed by forcing the help_text content to be escaped a second
time. The issue itself is mitigated in bootstrap.js release 2.0.3
(ours is currently 2.0.1).
2) Properly escape untrusted Heat template 'outputs'
The 'outputs' parameter in a Heat template was included in a Django
template with HTML autoescaping turned off. Malicious HTML content
could be included in a Heat template and would be rendered by Horizon
when details about a created stack were displayed.
This was fixed by not disabling autoescaping and explicitly escaping
untrusted values in any strings that are later marked "safe" to render
without further escaping.
Conflicts:
openstack_dashboard/dashboards/project/stacks/mappings.py
Change-Id: Icd9f9d9ca77068b12227d77469773a325c840001
Closes-Bug: #1289033
Co-Authored-By: Kieran Spear <kispear@gmail.com>
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, each client creates a new session for
each call. This fix makes novaclient re-use
sessions in the most obvoius cases.
Conflicts:
openstack_dashboard/api/nova.py
Partial-Bug: #1247056
Change-Id: Ie99ecb66304cf40e4f5fdd31fab5162ed11b863e
(cherry picked from commit ddc479272f5402ff778c45892acc3ac7613b7c11)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The Nova API makes the implicit assumption that flavorids are unique,
so if one creates two flavors with the same flavorid, subsequent
requests for flavor information can vary between "inaccurate" and
"wildly f*cking inaccurate"
From an end-user perspective, it makes it look like data such as
flavor access settings get lost between edits (because the API pulls
the access list from the wrong flavor)
Let the API assign a new flavorid on changes. The comments around
the handler code imply that is the desired behaviour, anyhow.
Cherry-picked from 4100a1cbc24184b58d5049dfb601b18e29e6107d
Change-Id: I5403202396a7b136b0ae8637d6aae1cf32550747
Closes-Bug: 1276371
|
| |
| |
| |
| |
| |
| | |
Change-Id: Id483d13d8d329aee4a57d0a89e6368fab3b201ec
Closes-Bug: #1256821
(cherry picked from commit 860b2a0be11ceb2e57c4c0d0e7ff020325277c78)
|
|\ \ |
|
| |/
| |
| |
| | |
Change-Id: Ia5b940faf01df6cae58df1f4b4f5e8fa2f3f078a
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Another item needs mocking with the new release of
python_keystoneclient. Adding it to mocked keystoneclient.Client
object.
Closes-Bug: #1279907
Change-Id: I3c43a7290a6e05c718082dcad369162bf21e3603
(cherry picked from commit 043085f812a1d06e8e082b2dbd52f406172bbfff)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Import the latest translations of ~100% completed languages.
12 translated languages are avaialable.
* Update POT files (English PO file)
This commit is directly proposed to stable/havana branch because
strings are different between stable/havana and master branches.
Change-Id: I117ea214d121d4c70e8f3679c88d0c758c586f99
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The session timeout code in the horizon/middleware.py can cause
inappropriate timeouts/logouts when running Horizon behind a load
balancer on two machines that are slightly out of sync time-wise.
Use timestamps rather than datetime as the arithmetic is simpler.
Closes-bug: #1243277
(cherry-picked from commit 13355dacdbfa9ef14a4e1c16afeffaece5c13a39,
minus the unrelated settings.py changes.)
Change-Id: I23159d2dee7fc05653a99fc89fbfd4d52e988df5
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I18N team decided to maintain Horizon translations for Havana
stable branch and Transifex resource names is renamed to *-havana.
.tx/config in Horizon stable/havana repo needs to be updated.
Closes-Bug: #1274005
Change-Id: I1a580f11d85ba5ce52898f42ee1229df224e940f
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Many of the tabs on the Instance Creation screen don't show a "*"
despite having require fields. This is due to faulty logic in determining
whether the workflow-step has require fields. (Previously, only keys from
the contributes list were checked.)
Closes-Bug: 1252005
Change-Id: Id609da27c51f8d4725683d7fd1534ead0c3bb984
(cherry picked from commit 788ec08c4f3e53b1f3dbaa40c19a0a71c21cdf42)
|
|\ \ \ \ \ |
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
before this patch, it's possible to try to create a volume
from an image, create a volume during instance creation etc.
The same applies to create a volume from snapshot.
Closes-bug: 1267438
(cherry picked from commit 33076684a9db19b5e25ba517ce3ac90bb5c25fc0)
Conflicts:
openstack_dashboard/dashboards/project/images_and_snapshots/images/tables.py
openstack_dashboard/dashboards/project/instances/workflows/create_instance.py
Change-Id: Ib573487938e0833668b002d05574e587734ef829
|
|\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | | |
stable/havana
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In Neutron API, resources from all tenants are listed when
retrieving a list of resources with admin role. Horizon
project dashboard is for project-specific operations,
so we should retrieve only resources of the given project.
LBaaS/VPNaaS panels have this problem, but FWaaS does not.
router_list should be called with tenant_id filter too.
This commit also fixes VPN/FWaaS tests so that it extract tenant_id
from request attribute rather than use tenant_id of test_data.
Change-Id: I080e6c6d1e426a878c1d088763bbc7e5add15820
Closes-Bug: #1244126
(cherry picked from commit 630b43349160f8b35d54196aabaa6e1afe5e4d61)
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes-Bug: #1237377
Change-Id: If901008171d964bf93941c0b6de2c66e20f0aa27
(cherry picked from commit 3a28423cd96596edd5e30a1a53956fa6c93f439f)
|
|\ \ \ \ \ |
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If OPENSTACK_API_VERSIONS["identity"] was not set in local_settings.py,
django_openstack_auth and horizon had their own fallback method which
did not necessarily fallback on the same version and was leading to
discrepancies and erratic behavior.
Refactored in order to use the same fallback method defined in
django_openstack_auth.utils
Change-Id: I583d49a73077a20baf5f01628b0b6e8480296964
Closes-Bug: #1231357
(cherry picked from commit ea447939a88dd80e54612a49a66ae57243e1164b)
|
|\ \ \ \ \ |
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
CreateKeyPair and ImportKeypair handled name checks in a different
way. When importing a keypair, one got a generic error message
without a hint, that the name was wrong.
This is the backport to Havana.
Managed to drop the original changei, which was
Ie82c0cd21f70aae3f55b84a1c05c9f170eaec312
Closes-Bug: #1265563
(cherry picked from commit eafe0b260d24f65d6f0b0487a74c352a01a53d84)
Change-Id: I10d5a7151242afeeed59965b361c89cc97b53b46
|
|\ \ \ \ \ |
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In Firefox $('body').scrollTop returns 0, that's why the modal
appear outside the visible screen. Added $('hmtl).scrollTop.
var scrollShift = $('body').scrollTop() || $('html').scrollTop()
Closes-Bug: 1251361
Change-Id: Icf691eb140e091615a98f1fbd415428cd418ba9e
(cherry picked from commit 8950b90d1777e265f98379098cebef7517642efe)
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In the "Create An image" window, there are "minimum disk" and "minimun
memory" text input. But both help text on the two text inputs are using
"the minimum disk size...". Actually for the second one we should say
"the minimum memory size...", and now this patch fix this.
Change-Id: Ife19acba5fafb41d99e9416d2f9e8082b9eaef53
(cherry picked from commit 0314d54391775f09b35759a650dbae2e2ba567aa)
|
|\ \ \ \ |
|