summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Dropping lower constraints testing from stable branchesstable/steinmanchandavishal2021-10-223-171/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This topic was discussed on the ML and QA team proposed to test lower constraints [1]. As decided in horizon weekly meeting in the past[2], stable branches will drop the lower-constraints job from CI. This patch also update ``.zuul.yaml`` to test stable/stein with tempest 24.0.0 for the below reasons: For every stable branch, Tempest as a range of versions to work[3] and we can pick either first supported or last supported version to test the specific EM stable branch (when Tempest master is in not used). For stable/stein, first supported version is Tempest 20.0.0 and last supported verson is 26.0.0. Till now we used the last supported version and it was working fine until jsonschema latest release 4.0.0 has some incompatible changes. Now we can say our upper constraints should protect us from this (like it protect in Tempest master case). But thing is little tricky here on whether we use the compatible constraints with tempest 26.0.0. or not. Compatible constraints for Tempest 26.0.0 is stable/victoria constraints (the time tag 26.0.0 was cut) but we used stable/stein constraints with tempest 26.0.0 in stable/stein[4]. We should always use the compatible constraints and tag combination. We have two option here to solve: 3. Use Tempest 24.0.0 and compatible stable/stein constraints (this commit) 4. Use Tempest 26.0.0 and compatible stable/victoria constraints I am going with the 1st approach as it is simple and 2nd approach need modification in run-tempest roles etc. Same fix is done at devstack side for stable/stein gate fix - https://review.opendev.org/c/openstack/devstack/+/812092 [1]http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html [2]https://meetings.opendev.org/irclogs/%23openstack-meeting-alt/%23openstack-meeting-alt.2021-03-24.log.html#t2021-03-24T15:12:58 Co-Author: Ghanshyam Mann <gmann@ghanshyammann.com> Change-Id: I3f4367817cdf04eacacba8b2ba2bbc06b09d3132 (cherry picked from commit 38ccf26b174c071f2ada5e65aa210634668786a3) (cherry picked from commit e96945376c1cdc69ab28e7820e3bcaf2a45fee71) (cherry picked from commit 0b7a77e8a1484fb2e1aa105f7f617655c1dd4ee6) (cherry picked from commit 852e372d1da69dca243601d299ff42bec90ecb1c)
* Correct confusing wording in a release noteAkihiro Motoki2021-04-132-3/+3
| | | | | | | | | | A release note in stein has a confusig wording and I believe it is worth fixing though it is from some old release. The contents of the rendered release notes is picked up from stable branches, so this commit is directly proposed to stable/stein. Change-Id: I5c58383dec5227d0be99844e4123167a1f8c380e Closes-Bug: #1921448
* Merge "Pin tempest and tempest-horizon in stein" into stable/steinZuul2021-02-021-2/+2
|\
| * Pin tempest and tempest-horizon in steinAkihiro Motoki2021-01-211-2/+2
| | | | | | | | | | | | | | | | | | | | | | stable/stein is in the extended maintenance phase and we will pin tempest version to the latest tempest release (26.0.0) in Wallaby. tempest 26.0.0 was released before merging tempest-horizon back, so we need tempest-horizon too. This commit tries to install tempest 26.0.0 and tempest-horizon 1.1.0 (latest release). It makes the merge of tempest-horizon more smooth. Change-Id: I5f2369e47cfaa9ccfdf8aa1f91348349c55b8515
* | Cap bandit for python 2.7 envmanchandavishal2020-12-243-7/+7
|/ | | | | | | | | | | | | bandit 1.6.3 supports only python>=3.5 and stein jobs with python 2.7 are broken when bandit 1.6.3 is being installed. bandit <1.6.3 supports python 2.7. We have no constraint for test only libraries so we need to cap it. doc/requirements.txt and lower-constraints.txt also needs to be updated to pass the requirements-check and lower-constarints-job respectively. Change-Id: Ia8c69501a1362cb08344aa50d00ed184e9f3d49f
* Fix open redirectstein-em15.3.2Radomir Dopieralski2020-10-203-3/+42
| | | | | | | | | | | | | | Make sure the "next" URL is in the same origin as Horizon before redirecting to it. Conflicts: horizon/test/unit/workflows/test_workflows.py Change-Id: I06b2bfc8e3638591615547780c3fa34b0abe19f6 Closes-bug: #1865026 (cherry picked from commit 252467100f75587e18df9c43ed5802ee8f0017fa) (cherry picked from commit baa370f84332ad41502daea29a551705696f4421) (cherry picked from commit 6c208edf323ced07b15ec4bc3879bddb91d398bc)
* Update geckodriver version to v0.27.0.manchandavishal2020-09-011-1/+1
| | | | | | | | | | | This patch updates geckodriver version to v0.27.0 from v0.23.0 to fix horizon-integration job. Fo more info. please refer [1]. [1] https://github.com/mozilla/geckodriver/issues/1771 Change-Id: Ie550beddf54e5bc43c34046bb18970638d10f303 (cherry picked from commit 16c74ad62fd94906d9f4453493227accd134717f)
* Fix horizon-nodejs jobs15.3.1Andreas Jaeger2020-06-242-0/+10
| | | | | | | | | | | | | | | | Tox is not anymore pre-installed on the OpenDev CI images. The file package.json needs tox, install it to fix the job. Install it via a pre-run playbook so that this is run in addition to all of the playbooks of the parent. Note for the reviewer in stable/stein we run nodejs-4 jobs as runtime. I have cherry-pick this change from master which run nodejs-10 job but simliar changes fixes the nodejs-4 jobs So I have added pre-run playbook for nodejs-4 job as well. Change-Id: Icf82fa96f7d90453f78cf564c847682a286ed575 (cherry picked from commit 7cd0debebe1a300a96f8d0f21626793be0a0bc41)
* Incoming tenant id when creating a subnet on create network formpengyuesheng2020-06-083-2/+8
| | | | | | | | | | | On admin panel, when creating a network and creating a subnet, the tenant to which the network belongs and the tenant to which the subnet belongs are inconsistent. This patch uniform network and subnet tenant ID Change-Id: I3744d8b7a0a37918962c9d9a2ac319002de93851 Closes-Bug: #1823627 (cherry picked from commit 8de1e272f08bcc294b10ce548616f181ee7bc800)
* Merge "Fix tenant_id for a new port." into stable/steinZuul2020-05-254-2/+73
|\
| * Fix tenant_id for a new port.shenjiatong2020-05-084-2/+73
| | | | | | | | | | | | | | | | | | | | To successfully create a port in a shared network which belongs to a different tenant, the tenant of the new port should be same as the tenant of a request user. Closes-bug: #1815461 Change-Id: Ia243f213b23f3f34845de5d97e8eaa5aa6979e76 (cherry picked from commit 3c33f46dc8196809d67301f20c8b920cad03b372)
* | Switch to new javascript jobsAndreas Jaeger2020-05-141-20/+20
|/ | | | | | | | | | | | Change I8013228ca05607a69f390a9bb75991fc6543f865 introduces new javascript jobs that better handle npm or yarn, update the jobs here to use it. Change the job names to start with horizon to follow the Zuul job naming policy. Change-Id: I86a56afcd2cde3a088abcc66c0294424cd03546f (cherry picked from commit a8ff4c376114a616fd21fc0b76d9b1dcb40b92e2)
* Merge "Implement 'selector-append' sass function" into stable/stein15.3.0Zuul2020-04-272-8/+13
|\
| * Implement 'selector-append' sass functionIvan Kolodyazhny2020-04-232-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'selector-append' is used in xstatic-mdi [1] but it isn't supported by the latest pyScss. As a workaround we use 'append-selector' function from pyScss until 'selector-append' will be supported. This patch also reverts Ia9e1e807591d4428f585177f521d4cb9d463b917 because we don't need it anymore. [1] https://opendev.org/openstack/xstatic-mdi/src/tag/1.6.50.2/xstatic/pkg/mdi/data/scss/_functions.scss#L2 stable/train backport: A release note on the known issue is now removed as it is fixed by this commit. Instead, a note on the workaround by this commit is added. Change-Id: Ib8ca0fcfe339cb68d6a157a00cbc2d34854ef4c5 Closes-Bug: #1771559 (cherry picked from commit 74d76e900f28e88190a35bff921c56349077ca53) (cherry picked from commit f26c88721614d1c25bcd26740b8fb20a7a97bd05)
* | Fix .zuul.yaml syntax errorsAndreas Jaeger2020-04-251-1/+1
|/ | | | | | | | | | | | Zuul complains about: "bad escape \l at position 3" Fix the regex. This is a partial backport of change I70851622a91280eab99005bf285d8190bfbf8933. Change-Id: I7885d46a6e37af77d258665eaab1532fc5d05f67
* Merge "Authenticate before Authorization" into stable/steinZuul2020-04-141-3/+3
|\
| * Authenticate before AuthorizationJacek Tomasiak2020-04-011-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When user is not logged in and given Dashboard has some `permissions` defined, `require_perms` decorator was raising `NotAuthorized('You are not authorized to access %s')` instead of `NotAuthenticated('Please log in to continue.')`. This was caused by the order of decorating the views. The decorator which is applied last is called first in the chain as it wraps the decorators which were applied before. This means that to check for authentication before checking permissions we need to apply the `require_auth` decorator after `require_perms`. Closes-Bug: 1869708 Change-Id: I94d3fa5c1472bb72c9111cab14c6e05180f88589 (cherry picked from commit e4fd69292c4a8340eba33f5c9d516796472e9269)
* | Merge "Tell reno to ignore the kilo branch" into stable/steinZuul2020-04-082-0/+6
|\ \
| * | Tell reno to ignore the kilo branchelajkat2020-03-232-0/+6
| |/ | | | | | | | | | | | | | | | | | | When reno 3.x runs under setuptools, it scans all of the branches it can find, including any that look like they're closed and have an -eol tag. This patch is a copy of one similar in cinder repo: https://review.opendev.org/707495 Change-Id: I50a50f75a1e70ccc183f598099f0e2f0fff8985a
* | Update pyScss to 1.3.7Ivan Kolodyazhny2020-03-314-3/+17
|/ | | | | | | | | | | | | | | | | | pyScss 1.3.4 is not compatible with setuptools 46. pyScss 1.3.7 was releaed to make it work with setuptools 46. Note that a workaround for the material design theme in commit ddc52a7405f0be38629f665d24bcf75022ce0018 is not backported in this change as the workaround is a partial fix of bug 1771559. Instead, a release note to mention this as a known issue is added. python-memcached in test-requirements.txt is updated to pass the requirements-check job. Depends-On: https://review.opendev.org/716023 Change-Id: I336a3449c1ed8be3984da6366e9b45f8e4d3f5c0 (cherry picked from commit 2c44702724f25c8114e1a7318d45cd0f87a6c131) (cherry picked from commit dbda462982d694b88ecacbe78da85bcc37868548)
* Merge "Fixes a series of bugs related to Floating IPs." into stable/steinZuul2020-02-1810-55/+196
|\
| * Fixes a series of bugs related to Floating IPs.Marek2020-01-1610-55/+196
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fixes KeyErrors when accessing 'floatingip' values in usages, which broken Floating IP allocation. - The quota display in the bottom right of the Allocation dialog are only displayed if 'enabled_quotas' is True - Adds security group rule tallying for the usages overview page, which fixes a KeyError crash for installations where Horizon 'enable_quotas' is set to true, but the 'quota_details' extension is not installed on in Neutron - Adds a policy check to show and hide The plus/add button in Instances->Associate Floating IP to match the Allocate IP To Project button in Floating IPs - Fixed the page title not being set for the non-modal version of the modal allocation dialog/form - Added an 'allowed' functionality for network usage overview charts to allow for them to be dynamically disabled - Added tests and mocks for the above - Added tests for non-legacy quota tallying for networks - Added test for disabled network quotas in overview Change-Id: I47f73ff94664d315a2400feb8ce8a25f4e6beced closes-bug: #1838522 (cherry picked from commit 161b4ae5d4a7a29f9e5c91d9b391dee49e075993)
* | Imported Translations from ZanataOpenStack Proposal Bot2020-02-151-9/+66
| | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I07d8202d4c0a6e411049bb0110171c6596c8a866
* | Allow to evacuate without specifying a target hostRikimaru Honjo2020-01-291-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | When the evacuate is run without specifying a target host, horizon sets an empty string for target host. But the evacuate api doesn't allow an empty string. As a result, nova returns "HTTP 400 Bad request". So this patch sets None as the target host when it isn't specified. Change-Id: Ia865a6c02e206fa49efc3095e8d3488f5638d0e3 Closes-Bug: 1793694 (cherry picked from commit f9e0f8a976b82088ef095a69cd1fa892cddde3ba)
* | Fix typo in publicize_image policy name15.2.0Ivan Kolodyazhny2020-01-152-1/+12
|/ | | | | | | | | This patch is not cherry-picked from stable/train because if was fixed in a scope of a new feature implementation with https://review.opendev.org/#/c/602468/ commit. Change-Id: I519e15afc975e6da2afb9c72a05448541572bd10 Closes-Bug: 1859041
* Merge "GUI hangs on creation of project in User creation form" into stable/steinZuul2020-01-061-1/+1
|\
| * GUI hangs on creation of project in User creation formHemanth Nakkina2019-12-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On creation of project in user creation form, the response is sent as html and the javascript try to parse the output as json and fails. The project creation response should be sent as text/plain so that javascript can parse the string as json. The bug have 3 parts 1. Users are not listed on GUI in different domain 2. Projects are not listed on GUI in different domain 3. Gui hangs during creation of user/project using + option Case 1 & 2 are fixed at https://review.opendev.org/#/c/697962/ This patch fixes case 3. Change-Id: I4936a158ad99cf9d7514e79c06ed2315ce11218b Closes-Bug: #1826114 (cherry picked from commit 8fb86b2adbdf4fae63faabc8937728c43c1777d5)
* | Fix "prev" link pagination for instances with identical timestampsKeithMnemonic2019-12-272-12/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch resolves an issue with the "prev" link when instances have identical "created_at" values. This can occur when creating instance using the "min/max count" option. The reverse sort does not work correctly as the server list returned from nova is not an exact reverse as the forward sort. It looks like the combination of sort_keys must be unique to ensure the forward and reverse pagination properly. As a workaround 'uuid' (server ID) is added to 'sort_keys'. In addition, 'display_name' is added before 'uuid' in 'sort_keys' to list servers in the alphabetical order (which sounds natural). Closes-Bug #1856243 Change-Id: I73234b2c69ce8ea648b4a9721abe4f5670031909 (cherry picked from commit 9637d733749d741d5aac3b89b92e100d32fbdbb0)
* | Merge "Imported Translations from Zanata" into stable/steinZuul2019-12-216-15/+165
|\ \
| * | Imported Translations from ZanataOpenStack Proposal Bot2019-12-206-15/+165
| | | | | | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I0d31c7406027d7396ec341818eb154f6d1101938
* | | Merge "Fix users/projects list when domain context is changed" into stable/steinZuul2019-12-211-2/+6
|\ \ \ | |/ / |/| |
| * | Fix users/projects list when domain context is changedHemanth Nakkina2019-12-131-2/+6
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case of Keystone Multidomain setup, the project and users list is empty when the domain context is changed. Horizon uses domain scoped token for keystone api calls to get list of projects and users. And domain scoped token cannot get information about projects and users in other domains, the list is empty. This patch modifies the use of domain scoped token only when domain context is not modified. The bug have 3 parts 1. Users are not listed on GUI in different domain 2. Projects are not listed on GUI in different domain 3. Gui hangs during creation of user/project using + option This patch handles case 1 and 2. Change-Id: Ibafe3e2eb3ee1ee5c9eb5d2a276a0edfa3e7c607 Partial-Bug: #1826114 Closes-Bug: #1830782 (cherry picked from commit 9aca7a94e28589484e312770cc1ee2b8243211bb)
* | Cap hacking version to <2Akihiro Motoki2019-12-191-1/+1
|/ | | | | | | | | | | Hacking 2.0.0 and its dependencies like flake8 have incompatible changes and bumping to them leads to pep8 check failure. It is good to address pep8 warnings in the master branch, but in case of stable branches it is good to continue to use the same version of hacking. This commit is proposed to the master branch so that it can be backported. Change-Id: I2b174ef3231956037650eba19aebe5989dffa617 (cherry picked from commit 7a7558b0583fa84f73d5ecb81204cbb76b0ef0e5)
* Merge "Fix deleting port from port details page" into stable/steinZuul2019-12-091-1/+2
|\
| * Fix deleting port from port details pageTatiana Ovchinnikova2019-12-031-1/+2
| | | | | | | | | | | | | | | | | | This patch fixes "Delete port" button at the port details page: Project -> Network -> Networks -> <network name> -> Ports -> <port name> Change-Id: I84f4da9c84d75c458b54bd456cbc7b92b303ba81 Closes-Bug: #1854514 (cherry picked from commit 18020e30b67efa9e67d061c317804a6f800b74c7)
* | Merge "Fix tenant floating_ip_allocation call in neutron rest api." into ↵Zuul2019-12-042-2/+2
|\ \ | |/ |/| | | stable/stein
| * Fix tenant floating_ip_allocation call in neutron rest api.Sam Morrison2019-11-292-2/+2
| | | | | | | | | | | | | | | | | | The call to allocate a new floating IP was incorrecting calling tenant_floating_ip_allocate, this is used by neutron-lbaas-dashboard. Change-Id: Ia4d1367ccd309a074a0ea84a555d7de6c07971a6 Closes-bug: #1831954 (cherry picked from commit 92d832028df65cb95030b2a585764a62dc1c0b75)
* | Imported Translations from ZanataOpenStack Proposal Bot2019-12-024-67/+11
|/ | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I0fd264195e88a7dfb84f9e87a17d14b35e899501
* Merge "Modify the regex for name on import public key form" into stable/steinZuul2019-11-151-1/+1
|\
| * Modify the regex for name on import public key formpengyuesheng2019-10-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | This patch fix does not match the regex in horizon and nova [1]. The service supports underscores, but the restriction imposed in horizon is different, so the regex is updated. [1] https://github.com/openstack/nova/blob/6ebb2c4cae65cb437e17a8c02fe5174a9825d8e0/nova/compute/api.py#L5674-L5690 Closes-Bug: #1848383 Change-Id: Icc5e9c6447253d6087c578ab931b52a923128e38 (cherry picked from commit 42349acc2fa08cadb8d37616d0262838c4629039)
* | Fix aes-xts key length in Horizon Admin Guide / Manage VolumesKeith Berger2019-10-221-8/+3
|/ | | | | | | | | | | When using aes-xts-plain64, a 512 bit key produces an error as this is not a supported barbican key length for aes-xts-plain64. This patch updates the horzion admin doc to remove the reference of a 512 bit key. Change-Id: Ie36e05a1e59eb88b779c9f3249a714c20b5f5fe0 Closes-Bug: #1708505 Closes-Bug: #1849196 (cherry picked from commit 85a1dddf126691921924edcecaee5c054c7df6c2)
* Merge "Add Allowed Address Pair/Delete buttons are only visible to admin" ↵15.1.1Zuul2019-10-093-0/+186
|\ | | | | | | into stable/stein
| * Add Allowed Address Pair/Delete buttons are only visible to adminShilpa Devharakar2019-09-263-0/+186
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initially In Queens, when logging into Horizon in context of a _member_ in any project, the "Add Allowed Address Pair" and "Delete" buttons in "Network" -> "Networks" -> <select a network> -> "Ports" -> <select a port> -> "Allowed Address Pairs" are not visible. When accessing the same panel in context of a project where the user has the admin role, the "Add" and "Delete" button is visible and functional. This patch fixes the above issue by updating the policy_target. Change-Id: Ia7db6c2881c72580a156eb97b11bb51f295cfbce Closes-Bug: #1794421 (cherry picked from commit 87b57dfe7113da09715d5613ab9c91c15a75c189)
* | Merge "Remove the check which causes plugin's quotas update failure" into ↵Zuul2019-10-091-3/+0
|\ \ | | | | | | | | | stable/stein
| * | Remove the check which causes plugin's quotas update failureGloria Gu2019-10-011-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The check causes external plugin's quotas fields unknown exception because the quotas fields are not part of QUOTA_FIELDS which only includes the fields for cinder, neutron and nova. Meanwhile the exception message throws TypeError. This commit removes the uncessary check. It also helps fix the manila-ui's bug #1842119 Change-Id: If093f4ecf1e344792b347c5c338b441b1ab42a04 Closes-bug: #1798048 Closes-bug: #1842119 (cherry picked from commit 44987f02be671fd81b3dcd8d22f9fa1b219488c2)
* | | Imported Translations from ZanataOpenStack Proposal Bot2019-10-042-7/+15
|/ / | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: Ib5077917a8678a3ba27ad0dfa8f5732618ba77d8
* | Merge "Updated max-width to be dynamic for .member class" into stable/steinZuul2019-10-012-2/+3
|\ \
| * | Updated max-width to be dynamic for .member classGloria Gu2019-09-262-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When member name is longer than $members-list-item-width (130px) in members list (for example, project group in Edit Project), current text-overflow will put ... (ellipsis) at the end of the name and name will be truncated. Updated the styling of .member class to make max-width dynamic 80% and wrap the name in case it is really long. Change-Id: Ic295a9b1e7fd3525c633d51a60054e713da6a657 Closes-bug: #1843480 (cherry picked from commit b635e625f75744938cde49fd250dd1a5f36ca1b7)
* | | Imported Translations from ZanataOpenStack Proposal Bot2019-10-011-4/+4
|/ / | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I865a5988d4983c07eb5a589773c79bf6e09f3e3f
* | Merge "Revert "Raise NotFound error when retrieved by not uuid"" into ↵Zuul2019-09-261-8/+0
|\ \ | | | | | | | | | stable/stein