summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Disable form auto-complete on login formstable/victoriaDavid Hill2023-05-051-2/+2
| | | | | | | | Disable form auto-complete on login form with autocomplete="off" for the email/password field. Change-Id: Ie550eae36ece160d19186a404c0e688f2f6e785b (cherry picked from commit e4a13dbcde0df213f9b6e7d72f45c6610192204a)
* Make readonly metadata properties unable to editTatiana Ovchinnikova2022-11-252-0/+10
| | | | | | | | | | | | | | Image metadata properties os_hash_algo and os_hash_value are readonly, and attempts to edit them fail with unclear message. This patch makes these fields readonly in update metadata form. Also, if the existing metadata property is null, Horizon should consider it optional too, in addition to empty field fix: https://review.opendev.org/c/openstack/horizon/+/812009 Change-Id: I892465ca4688fce9f7123682d02f11c92c7d2c5c (cherry picked from commit 892080ec0ff6174d5fd5de221ec4802bd21371a6)
* Fix app cred create without project_id for domain adminsRodrigo Barbieri2022-11-142-3/+58
| | | | | | | | | | | | | | | Users with domain admin role that are not cloud admins are not able to get scoped context and create an application credential with project_id, so this change forces the scoped context in that particular case. Closes-bug: #1827120 Change-Id: I076a97a6f943ab74a2db8bc5179a7db194009db4 (cherry picked from commit 6eeaf9852478e25ff77c21117664ac126c5357a4) (cherry picked from commit 778a52e66aeab883b31db729e04944eeecfec6a2) (cherry picked from commit 13e821a079134a458b24593d9593e0e5318e6cd6) (cherry picked from commit 084ee8aaea703d99720c0cdc2751b6479dab3b2f) (cherry picked from commit 2f8aaa03e8ed4c2c8e3628f1f723f304b24b1f82)
* Merge "Fix flavor specification at instance overview page" into stable/victoriaZuul2022-10-282-5/+30
|\
| * Fix flavor specification at instance overview pageTatiana Ovchinnikova2022-10-062-5/+30
| | | | | | | | | | | | | | | | | | | | The details page uses flavor id to resolve instance flavor, relying on legacy Nova API v2.46. This patch adds the current Nova API option, resolving instance flavor by flavor name, so flavor specification at instance overview page is displayed properly. Change-Id: I1fe45063c9d1cdd8682998329d81f843d30f80b3 (cherry picked from commit d0e9e976f2769b289196d481b0928893b702b011)
* | zuul: Declare queue at top levelTakashi Kajinami2022-10-171-1/+1
|/ | | | | | | | | | | | | | Zuul deprecated declaring shared queues at a pipeline level with release 4.1.0[1]. This updates the job definition to use the top level declaration instead. See [2] for details. [1] https://zuul-ci.org/docs/zuul/latest/releasenotes.html#relnotes-4-1-0-deprecation-notes [2] http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028603.html Change-Id: Ie63dd3b161cb8fd9be89002027d699ce2c4a67a5 (cherry picked from commit 4212950a4a6b036f563a236cb005604e1c096f04)
* Make existing empty metadata properties optionalTatiana Ovchinnikova2022-07-262-1/+7
| | | | | | | | | | | | | Editing of snapshot image or updating its metadata from Horizon is not allowed until existing properties with empty values are set or removed from metadata tree. They are allowed to be None, therefore Horizon should consider them optional too. Closes-Bug: #1945706 Change-Id: Idfec71d209430c7d069133a40ca1a7d340163783 (cherry picked from commit 4e0f5a5a85467ca83743e6e8126cd570f329afb9)
* Merge "Fix Project Limits for resize instance dialog" into stable/victoriavictoria-em18.6.4Zuul2022-04-191-20/+20
|\
| * Fix Project Limits for resize instance dialogTatiana Ovchinnikova2022-02-281-20/+20
| | | | | | | | | | | | | | | | Resize instance dialog should use proper calls for quota and usage. This patch fixes that. Change-Id: Ied6fd4ad69b38a721b23700c98344e0edf14771b (cherry picked from commit e2bb7d833526e3ea6117cb2a5d58cbf90548c6da)
* | Merge "Non-api filters not working with admin instance tab" into stable/victoriaZuul2022-04-181-6/+22
|\ \
| * | Non-api filters not working with admin instance tabvinay_m2022-02-021-6/+22
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue was that the filtering opts like project_name, image_name, flavor_name that are not supported by nova API (non-api filters) do not work expectedly. These filters are mapped to their IDs [1], but an instance list retrieved before resolving non-API filters is used [2]. This commit changes the logic to resolve non-API filters first and then retrieve instances using the updated search_opts. Note that the image list is handled a bit specially. If 'image_name' is specified as a filter, we retrieve a corresponding image detail first before fetching instances to resolve the image name into its ID. Otherwise, we retrieve images only related to instances retrieved and this happens after retrieving instances. [1] https://opendev.org/openstack/horizon/src/commit/f90c3cd50174af4927737e29e2765cd2d7ca507f/openstack_dashboard/dashboards/admin/instances/views.py#L166 [2] https://opendev.org/openstack/horizon/src/commit/f90c3cd50174af4927737e29e2765cd2d7ca507f/openstack_dashboard/dashboards/admin/instances/views.py#L154 Closes-Bug: #1888490 Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: Id43adbd44778d3375c0d49da3f7530cbb99e16fe (cherry picked from commit 6b79cdcc1b92a968c967286cc267bac39803c85e)
* | Imported Translations from ZanataOpenStack Proposal Bot2022-04-122-7/+110
| | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I7fdca39e63c6cccd6306fde5d4233c85855f3d2f
* | Change to a proper policy for Resume operationKeigo Noha2022-04-012-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | Previously, ToggleSuspend class checked 'os-rescue' policy for resuming an instance. To align to resume operation, this fix changes to 'os-suspend-server:resume'. Closes-Bug: #1963652 Change-Id: If6386ecdb81fb1f0d88dab447ee81c251b9857b7 (cherry picked from commit 29da801528a357449264e546182bd629f4654275) (cherry picked from commit db40c8ceb6c403bc94ac839f65c00805a5e4ff66) (cherry picked from commit d3bb9cd86a72fb270ff4f4d2b5ddea04c899ef53)
* | Merge "Fix for "Resize instance" button" into stable/victoriaZuul2022-03-235-22/+104
|\ \ | |/ |/|
| * Fix for "Resize instance" buttonThomas Goirand2022-03-095-22/+104
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, "Resize instance" widget is not working because it relies on legacy Nova API v2.46, obsoleted in Pike release. Proposed patch make Horizon use current Nova API (>=2.47). Note: It also cherry-picks a7956cd004 from the master branch which avoids the extra call of flavor_get in resize server form. Closes-Bug: #1940834 Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: Id2f38acfc27cdf93cc4341422873e512aaff716a (cherry picked from commit d269b1640f49e13aa1693a175083d66a3eaf5386)
* | Merge "Add horizontal scrollbar to role dropdown" into stable/victoria18.6.3Zuul2022-01-251-0/+2
|\ \ | |/ |/|
| * Add horizontal scrollbar to role dropdownTatiana Ovchinnikova2021-09-211-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Manage members dialog has a dropdown which lists all the role names. If a role name is long enough, it pushes all the roles to the left and hides them partially. This patch adds horizontal scrollbar for such cases. Closes-Bug: #1926511 Change-Id: I1bbf3b23717f9924974920d6569e018b94e3dbe8 (cherry picked from commit 9b28ab402802e9848f5824b04d85cf4292f738d3)
* | Imported Translations from ZanataOpenStack Proposal Bot2021-11-211-2/+5
| | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I6c492a851cc8a36cd32b68f91cf7319d0c1b84cd
* | Merge "Escape unicode characters when setting logout_reason cookie" into ↵Zuul2021-10-194-11/+21
|\ \ | | | | | | | | | stable/victoria
| * | Escape unicode characters when setting logout_reason cookieRadomir Dopieralski2021-09-224-11/+21
| |/ | | | | | | | | | | Change-Id: Ic61a3958461a4a939acc40d1039881e2d4c3a1cd Closes-bug: #1894801 (cherry picked from commit e68e23937341d03be7475d71903f31a61403c1e2)
* | Merge "Imported Translations from Zanata" into stable/victoriaZuul2021-10-181-2/+7
|\ \
| * | Imported Translations from ZanataOpenStack Proposal Bot2021-10-151-2/+7
| | | | | | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I1d4b53cabafe12b6d786d5e1d972c24807c267a6
* | | Merge "Handle an attached volume without volume_image_metadata" into ↵Zuul2021-10-181-3/+10
|\ \ \ | |/ / |/| | | | | stable/victoria
| * | Handle an attached volume without volume_image_metadataAkihiro Motoki2021-08-041-3/+10
| |/ | | | | | | | | | | | | | | | | | | There is a case where volume_image_metadata attribute does not exist. It looks like it happens for example when a volume was created before the volume_image_metadata feature was implemented. Change-Id: I0b8e6b2e540a1782b9edd9921490a9371d31afc7 Closes-Bug: #1916891 (cherry picked from commit b841952906de33ff93c90cc04ea0509afeaab89f)
* | Dropping lower constraints testing from stable branchesmanchandavishal2021-09-223-163/+0
|/ | | | | | | | | | | | This topic was discussed on the ML and QA team proposed to test lower constraints [1]. As decided in horizon weekly meeting in the past[2], stable branches will drop the lower-constraints job from CI. [1]http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html [2]https://meetings.opendev.org/irclogs/%23openstack-meeting-alt/%23openstack-meeting-alt.2021-03-24.log.html#t2021-03-24T15:12:58 Change-Id: I3f4367817cdf04eacacba8b2ba2bbc06b09d3132 (cherry picked from commit 38ccf26b174c071f2ada5e65aa210634668786a3)
* Merge "Change with_data=False for swift_get_container" into stable/victoriaZuul2021-08-022-2/+3
|\
| * Change with_data=False for swift_get_containerTobias Urdin2021-07-192-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function is only used in the Container get method which retrieves details about a container. It's not used for listing data in the container even though with_data was True doing a GET instead of a HEAD on the container. This indirectly also fixes the Ceph bug [1] in the Swift API implementation that doesn't expose metadata correctly for a GET but does for a HEAD. [1] https://tracker.ceph.com/issues/47861 Change-Id: Iba4215b2e3a414d1794faa05be31bf69e0e48bec (cherry picked from commit c87f0e7a90d05f9355bd58165c25561dedae36d5) (cherry picked from commit 8232ac0385782e8131b071fa1324001c1c429aaf)
* | Fix Unable to use multiattach volume as boot for new servermanchandavishal2021-07-283-4/+5
|/ | | | | | | | | | | If we try to create a new server from a bootable volume that supports multiattach, it will fail to create with an error message that ``multiattach volumes are only supported starting with compute API version 2.60``. This patch fixes the issue. Closes-Bug: #1931440 Change-Id: Ic8330b947b1a733f70c3bdad8b3493f20a2f26fb (cherry picked from commit 64fe0abb653950c85d455dedd09ef42856c6b07b)
* Merge "Don't load user role assignment or groups tabs for non-admins" into ↵Zuul2021-07-141-0/+8
|\ | | | | | | stable/victoria
| * Don't load user role assignment or groups tabs for non-adminsMark Goddard2021-03-291-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a non admin user, navigate to Identity -> Users. Then click on the username of your user to go to the detail page. Only the allowed Overview tab is visible. The view shows three tabs: Overview, Role assignments, Groups. Click on either Role assignments or Groups. An error will appear, showing that the API call is unauthorised, and the table content will fail to load. This change fixes the issue by conditionally loading the tabs based on policy. Closes-Bug: #1920214 Change-Id: Ic8b723e6fd423b96a4f5eff54f9392cee534ed9e (cherry picked from commit 60cf32031565ed8b4b2a4a39380a060997c9d9e4)
* | Imported Translations from ZanataOpenStack Proposal Bot2021-06-201-3/+7
| | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: Ie69b7725a1e83c47b47488c9d83b47e97c056792
* | Imported Translations from ZanataOpenStack Proposal Bot2021-06-093-56/+559
| | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I3c89da1ec8b3aba82490b0863e8b2757f6ec97eb
* | Merge "doc: Update our IRC server to OFTC" into stable/victoriaZuul2021-06-081-1/+1
|\ \
| * | doc: Update our IRC server to OFTCAkihiro Motoki2021-06-041-1/+1
| | | | | | | | | | | | | | | Change-Id: I985ea0b19a96e5e3160b824efda20659d855c2dc (cherry picked from commit cdb08a1ad6b01693d30de9c27b809652af77ab27)
* | | Imported Translations from ZanataOpenStack Proposal Bot2021-06-061-39/+547
| | | | | | | | | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I10102ce506ee7ee60e6cb50f5950f556132366e3
* | | Imported Translations from ZanataOpenStack Proposal Bot2021-06-041-9/+664
|/ / | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I362877bf6a2ebf1e7091a9c0bf4286fc45475072
* | Imported Translations from ZanataOpenStack Proposal Bot2021-05-256-45/+79
| | | | | | | | | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: Ibbae44180c3b8e9b79f89e141489d44fb13ee6e9
* | Merge "Save instace_id inside Associate Floating IP workflow" into ↵Zuul2021-05-013-16/+22
|\ \ | | | | | | | | | stable/victoria
| * | Save instace_id inside Associate Floating IP workflowRadomir Dopieralski2021-03-233-16/+22
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, rename instance_id field to proper port_id. Before this change, when instance_id was passed from the Instances page in the URL, the information would be lost on form submission, and if the form contained an error, the it would be redisplayed with the port drop-down containing all ports from all instances. This also made submitting this form slow, as the drop-down would be populated with all ports on form validation. It also creates a bug, where if there are more instances than Nova's pagination allows, the ports from newer instances would no longer appear in the drop-down, and the form would fail to validate, even though the choice of port on initial form was correct. Closes-bug: #1920010 Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb (cherry picked from commit 3d82d57353d1a29fb5b568ffaa93db86998e9d94)
* | Merge "Fix community image handling in launch instance form" into ↵Zuul2021-04-272-33/+63
|\ \ | | | | | | | | | stable/victoria
| * | Fix community image handling in launch instance formAkihiro Motoki2021-04-072-33/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Community images which are not owned by a focused project are not included in the normal image list API (i.e., without specifying "community" as visibility), so we need an extra call of the image list API specifying "community" visibility in a filter. It was originally fixed by [1] but was dropped in [2]. The main motivation of [2] is to address "Duplicates in a repeater are not allowed" error in the JavaScript console. The approach of [2] was to drop multiple glance API calls, but the right solution would be to check duplicated images included in both API calls. This situation with duplicated images happens when a community image is owned by a focused project. In such case, the community image is included in the responses of both API calls. This commit adds a logic to check image IDs already processed. [1] https://review.opendev.org/c/openstack/horizon/+/614688 [2] https://review.opendev.org/c/openstack/horizon/+/640762 Closes-Bug: #1914045 Related-Bug: #1779250 Related-Bug: #1818508 Change-Id: I2ed1b6064ddd6f62818d6112e98e5d5a98beae9d (cherry picked from commit c9bb0e95eaa7ae4f0cce21bc0a246a9b0cd2f880)
* | | Merge "Fix Material theme to work with any combination of pyScss and MDI ↵Zuul2021-04-167-2/+27
|\ \ \ | |/ / |/| | | | | icons" into stable/victoria
| * | Fix Material theme to work with any combination of pyScss and MDI iconsIvan Kolodyazhny2021-03-197-2/+27
| |/ | | | | | | | | | | | | | | | | | | | | ':before' class doesn't work as expected with current versions of xstatic-mdi and PyScss. It's a temporary workaround with copy ':before' styles from MDI directly into the Material theme. Closes-Bug: #1771559 Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I969ad70065c580ba90bb0a050c7a9cf242d805ec (cherry picked from commit f3bfa383417b270fce384fee18c5cb470cec15f7)
* | Merge "On the create instance from, when the image name is empty, show id" ↵Zuul2021-04-013-9/+10
|\ \ | |/ |/| | | into stable/victoria
| * On the create instance from, when the image name is empty, show idpengyuesheng2021-03-083-9/+10
| | | | | | | | | | | | Change-Id: I4ac734e0fb4ac3151ff56fa2c53d3071cdb9131d Closes-Bug: #1853551 (cherry picked from commit a8158f6c31675297c3d35ecfee2ef0e22243e529)
* | Imported Translations from ZanataOpenStack Proposal Bot2021-03-094-13/+179
|/ | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I549624e40edcd792fab517f9522d8e45d895c940
* Imported Translations from ZanataOpenStack Proposal Bot2021-02-241-3/+9
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: Ib407c3d21b316e181e278a7074d0e6c556ab9600
* Merge "Add default index URL to Server Groups module" into stable/victoria18.6.2Zuul2021-02-101-0/+1
|\
| * Add default index URL to Server Groups moduleTatiana Ovchinnikova2021-01-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | Default Index Url is missing for Server Groups which causes improper redirect to details page opened in a new tab. Related-Bug: #1902821 Closes-Bug: #1889397 Change-Id: I8d5e68085727bd7a6402a0041c93986b6b40bb32 (cherry picked from commit 0a4fda0c0c1d4031f18634ad749797cc3b06533d)
* | Merge "Add WEBROOT to ngdetails navigation" into stable/victoriaZuul2021-02-103-2/+23
|\ \
View Lorry Controller Status