summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Disable form auto-complete on login form" into stable/xenastable/xenaZuul2023-05-121-2/+2
|\
| * Disable form auto-complete on login formDavid Hill2023-05-051-2/+2
| | | | | | | | | | | | | | | | Disable form auto-complete on login form with autocomplete="off" for the email/password field. Change-Id: Ie550eae36ece160d19186a404c0e688f2f6e785b (cherry picked from commit e4a13dbcde0df213f9b6e7d72f45c6610192204a)
* | Remove Description from Edit Image MetadataTatiana Ovchinnikova2023-05-051-0/+6
|/ | | | | | | | | | | | | | | Image description can be edited through Edit Image -> Image Detail, however it also appears as a property in Edit Image -> Metadata when the description is not empty. It's confusing to have it in two sections of one dialog form, and moreover, the Image Detail field always overwrites the Metadata field. This patch removes Description from Edit Metadata. Closes-Bug: #2017698 Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3 (cherry picked from commit 283b38e4f10b14c61dff42936c80ae3987f017cf)
* Fix instance error with attribute cells.Jan Jasek2023-04-241-0/+10
| | | | | | | | Selenium read data faster than the data are loaded. Added wait until element is visible. Change-Id: I2975ea5836a898d113a2baaab6a8f9bf8af8d742 (cherry picked from commit b14958df8bbf93c5c8623b6e367dfba607d795d1)
* Fix delete image tests.Jan Jasek2023-04-242-0/+18
| | | | | | | | | | | | Add wait until checkbox is in active state. Fix edit_image_description_and_name test. Add wait until the name text box is filled by default name (is not empty). In the other case selenium write new name into text box faster than default name is written there so default name then rewrite the new name. Change-Id: I56803e19dd80180cc432ca872a28a7ee7f41290d (cherry picked from commit 01c4ab920d82ed7e84dab84d9c925cd476902f1e)
* Merge "Fix success_url parameter issue for Edit Snapshot" into stable/xenaxena-em20.1.4Zuul2023-04-101-11/+1
|\
| * Fix success_url parameter issue for Edit Snapshotmanchandavishal2022-10-291-11/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The "success_url" param is used when updating the project snapshot [1] and it lacks sanitizing the input URL that allows an attacker to redirect the user to another website. This patch update 'Updateview' class to not use the "sucess_url" method. Closes-bug: #1982676 [1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/snapshots/views.py#L109 Change-Id: Ied142440965b1a722e7a4dd1be3b1be3b3e1644b (cherry picked from commit 79d139594290779b2f74ca894332aa7f2f7e4735)
* | Merge "Fix instance table behavior after deleting an instance" into stable/xenaZuul2023-03-291-3/+3
|\ \
| * | Fix instance table behavior after deleting an instanceHeather Lemon2023-02-021-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After deleting a VM from the instances table, all VMs above it in the table list disappear from the UI until the page is refreshed. Partial-Bug: #1859851 Change-Id: Icae04fd0f0c3f3fa5127309b64fc1b15e3bbc677 (cherry picked from commit c90c0b709c170fae299acc5917e7da69fb2ef2a8)
* | | Merge "Add a Note Under Install and configure Section in documentation" into ↵Zuul2023-03-294-0/+24
|\ \ \ | | | | | | | | | | | | stable/xena
| * | | Add a Note Under Install and configure Section in documentationmanchandavishal2023-01-184-0/+24
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds a note to use keystone port 5000 while configuring horizon for all distros like ubuntu/debian/rdo/obs under the install and configure section. Right now if a user tries to set up an OpenStack env. manually using documentation [1], [2] leads to some confusion because keystone documents suggest creating keystone endpoint at http://controller:5000/v3/ rather than http://controller/v3/ while horizon document consider keystone doesn't run at 5000 port updated by [3]. Closes-Bug: #1910476 Closes-Bug: #1926096 Closes-Bug: #1950919 Closes-Bug: #1956437 Closes-Bug: #1892279 Closes-Bug: #1903320 Change-Id: I18d0d2105ea54ba02f8979ab7a15a75a0425b8c7 [1] https://docs.openstack.org/keystone/latest/install/keystone-install-ubuntu.html#install-and-configure-components [2] https://docs.openstack.org/horizon/latest/install/install-ubuntu.html#install-and-configure-components [3] https://review.opendev.org/c/openstack/horizon/+/697406 Change-Id: I537a963c9d955b8d7e21f0d05b0197588907419e (cherry picked from commit 029de21c1190bb9d2e38063b62c689c1dbb8ef37)
* | | Merge "Fix rescue of volume-based instances" into stable/xenaZuul2023-03-292-3/+7
|\ \ \
| * | | Fix rescue of volume-based instancesJan Hartkopf2022-10-262-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rescue of volume-based instances is supported since Nova microversion 2.87. However, Horizon does not use this microversion when requesting rescue of any instances, causing a Nova exception for volume- based ones. The patch fixes this by explicitly setting the required microversion. Closes-Bug: #1941744 Signed-off-by: Jan Hartkopf <jhartkopf@inovex.de> Change-Id: Ic0cdfd326475882f839fd218cd7b4bfa62a2a76b (cherry picked from commit 05dd53a3cf3e1ced265d23d1c02765abd468a483) (cherry picked from commit 761e466e7a0628ae939dd654152f615732ad4f79) (cherry picked from commit 1cd150cdc568e81eb2ead8819d5559cf3e23a296)
* | | | Merge "Integration test navigation machinery for Angular pages" into stable/xenaZuul2023-03-0310-236/+483
|\ \ \ \
| * | | | Integration test navigation machinery for Angular pagesTatiana Ovchinnikova2023-02-1510-236/+483
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's an implementation of navigation modules for pages written in Angular. Legacy tests for images page are rewritten to work with the new navigation. Change-Id: Ib8a40f0adb0a46c9d646c6796a4242988eefa6e3 (cherry picked from commit 4743c6c748be79c3a80a350d05aeed7bbe63c577)
* | | | | Add setup and teardown to the volumes pagination testsRadomir Dopieralski2023-02-171-0/+9
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | For now just delete the old volumes at the start Change-Id: I013da554f58e1638178d3655459c9742fd7f85ba (cherry picked from commit 81edf08676f2651f4343498c23d93b000fca7127)
* | | | Speed up integration testsRadomir Dopieralski2023-02-081-6/+2
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have a place in the form-handling code where we look for the blue form submit button, and if it's not found, we look for the red form submit button. It looks correct at first glance, however it takes 10 seconds to throw NoSuchElementException, because there is a delay that makes sure that the page loads fully before raising that exception. Replacing this with a selector that finds both the blue and the red buttons in one query speeds the whole integration tests suite by half an hour, because there is no more waiting on every delete confirmation dialog. Change-Id: Ie256118c0a84a8868393018b25b0aa049582a17d (cherry picked from commit 2e6eca294718deb7e82f50c071d332377c35085f)
* | | Merge "Fix flavor id auto generation" into stable/xena20.1.3Zuul2023-01-171-2/+2
|\ \ \
| * | | Fix flavor id auto generationTatiana Ovchinnikova2022-12-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the flavor creation form always check for the uniqueness of the UUID field, even when it is set to "auto". That means that if we create a flavor with UUID value of "auto", the check will fail. This patch disable the check when UUID is automatically generated. Change-Id: Ie31307d67cf3857e3bb80c124e92c81e0c6a2982 (cherry picked from commit af7e6c4f75299b9e47db059dc7ddbaf2e0b1a3fc)
* | | | Merge "Don't try and update port security if its not changing" into stable/xenaZuul2023-01-173-4/+22
|\ \ \ \
| * | | | Don't try and update port security if its not changingSam Morrison2022-09-243-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Default policy in neutron doesn't allow port security to change if network not owned by the user. To allow users to update other attributes of a port don't send port_security_enabled attribute to neutron unless it changes. If user tries to change port security on a port in a network not owned by them it will still error as it does now. Partial-Bug: #1841050 Change-Id: I301336103cabc3f1cab3ee72d7743385ff1a10d6 (cherry picked from commit d059b0bc40f04befc60657cd6504cc5711934b90)
* | | | | Pin tox<4 for stable branches testingmanchandavishal2023-01-121-0/+8
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | horizon npm jobs start failing due to some recent changes in tox4. As discussed on open-discuss ML, it is decided to keep testing the stable branch with the tox version that they release with and not with the tox 4. This patch set the 'ensure_tox_version' to use 4, which will tell zuul to install tox<4 if it's not present. For more info. please refer [1]. [1] https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031668.html Change-Id: I3652d87d817030bcd3855d26bfa41b8b7061d08e
* | | | Merge "Fix preselection for launch Instance dialog" into stable/xenaZuul2022-12-011-2/+11
|\ \ \ \
| * | | | Fix preselection for launch Instance dialogTatiana Ovchinnikova2022-11-251-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Launch instance from a volumes/volume snapshot/instance snapshot should open a dialog with preselected boot source. However the dialog shows Image as selected boot source in any case, discarding the preselection. This patch fixes it, explicitly changing the boot source according to the preselection. Change-Id: I1a5a46d7be12ed179474a6a74647d0872b27b492 (cherry picked from commit 452c37dd369d2fa4c0dac9da1aba53bf1da89a30)
* | | | | Merge "Make readonly metadata properties unable to edit" into stable/xenaZuul2022-12-012-0/+10
|\ \ \ \ \
| * | | | | Make readonly metadata properties unable to editTatiana Ovchinnikova2022-11-252-0/+10
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Image metadata properties os_hash_algo and os_hash_value are readonly, and attempts to edit them fail with unclear message. This patch makes these fields readonly in update metadata form. Also, if the existing metadata property is null, Horizon should consider it optional too, in addition to empty field fix: https://review.opendev.org/c/openstack/horizon/+/812009 Change-Id: I892465ca4688fce9f7123682d02f11c92c7d2c5c (cherry picked from commit 892080ec0ff6174d5fd5de221ec4802bd21371a6)
* | | | | Merge "Get ports directly instead of via loop" into stable/xenaZuul2022-11-292-39/+30
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Get ports directly instead of via loopNicolas Bock2022-07-242-39/+30
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to get a list of available ports, the current implementation of the form code in `project/instances/attach_interface` loops through the available networks in the project and requests a list of ports for each via the Neutron API. This implementation is O(N) in time with a large prefactor (the time for a Neutron API call) where N is the number of networks. Instead of calling the Neutron API for each network this change uses one call to the Neutron API to get the list of ports on all networks and filters this list via a list comprehension. While this implementation is still O(N) the prefactor is significantly smaller. Includes some unit test fixes to workaround the fact that patch 6ac31e0 is not backported beyond Y. Closes-Bug: #1943639 Change-Id: I8fd32c3aad22d8ef7f57201f5144f6b2e357ef10 Signed-off-by: Nicolas Bock <nicolas.bock@canonical.com> (cherry picked from commit 9f5d659d160d24d359992dda22fecb0db6b6f805)
* | | | Merge "Fix app cred create without project_id for domain admins" into ↵Zuul2022-11-042-3/+58
|\ \ \ \ | |_|_|/ |/| | | | | | | stable/xena
| * | | Fix app cred create without project_id for domain adminsRodrigo Barbieri2022-10-242-3/+58
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Users with domain admin role that are not cloud admins are not able to get scoped context and create an application credential with project_id, so this change forces the scoped context in that particular case. Closes-bug: #1827120 Change-Id: I076a97a6f943ab74a2db8bc5179a7db194009db4 (cherry picked from commit 6eeaf9852478e25ff77c21117664ac126c5357a4) (cherry picked from commit 778a52e66aeab883b31db729e04944eeecfec6a2) (cherry picked from commit 13e821a079134a458b24593d9593e0e5318e6cd6)
* | | Merge "Fix flavor specification at instance overview page" into stable/xenaZuul2022-10-282-5/+30
|\ \ \
| * | | Fix flavor specification at instance overview pageTatiana Ovchinnikova2022-10-062-5/+30
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | The details page uses flavor id to resolve instance flavor, relying on legacy Nova API v2.46. This patch adds the current Nova API option, resolving instance flavor by flavor name, so flavor specification at instance overview page is displayed properly. Change-Id: I1fe45063c9d1cdd8682998329d81f843d30f80b3 (cherry picked from commit d0e9e976f2769b289196d481b0928893b702b011)
* | | Merge "Modified the image page to use CSS class" into stable/xenaZuul2022-10-271-2/+1
|\ \ \ | |_|/ |/| |
| * | Modified the image page to use CSS classWei Lingfei2022-09-291-2/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | Pages can not display normal when language is Simplified Chinese(zh-cn), a row in the table can display only one Chinese character. Remove "width: 100%" rule from the "word-wrap" class. The page should now display normally. Partial-Bug: #1936830 Change-Id: If72d49c78a9f83687785a1225151d819b85e88d2 (cherry picked from commit e9ca0016234632f6ad0fbd766c5829c587b6a951)
* | zuul: Declare queue at top levelTakashi Kajinami2022-10-171-1/+1
|/ | | | | | | | | | | | | | Zuul deprecated declaring shared queues at a pipeline level with release 4.1.0[1]. This updates the job definition to use the top level declaration instead. See [2] for details. [1] https://zuul-ci.org/docs/zuul/latest/releasenotes.html#relnotes-4-1-0-deprecation-notes [2] http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028603.html Change-Id: Ie63dd3b161cb8fd9be89002027d699ce2c4a67a5 (cherry picked from commit 4212950a4a6b036f563a236cb005604e1c096f04)
* Make existing empty metadata properties optionalTatiana Ovchinnikova2022-06-142-1/+7
| | | | | | | | | | | | | Editing of snapshot image or updating its metadata from Horizon is not allowed until existing properties with empty values are set or removed from metadata tree. They are allowed to be None, therefore Horizon should consider them optional too. Closes-Bug: #1945706 Change-Id: Idfec71d209430c7d069133a40ca1a7d340163783 (cherry picked from commit 4e0f5a5a85467ca83743e6e8126cd570f329afb9)
* Merge "Fix Project Limits for resize instance dialog" into stable/xena20.1.2Zuul2022-04-141-20/+20
|\
| * Fix Project Limits for resize instance dialogTatiana Ovchinnikova2022-02-281-20/+20
| | | | | | | | | | | | | | | | Resize instance dialog should use proper calls for quota and usage. This patch fixes that. Change-Id: Ied6fd4ad69b38a721b23700c98344e0edf14771b (cherry picked from commit e2bb7d833526e3ea6117cb2a5d58cbf90548c6da)
* | Merge "Change to a proper policy for Resume operation" into stable/xenaZuul2022-03-252-1/+7
|\ \
| * | Change to a proper policy for Resume operationKeigo Noha2022-03-072-1/+7
| |/ | | | | | | | | | | | | | | | | | | Previously, ToggleSuspend class checked 'os-rescue' policy for resuming an instance. To align to resume operation, this fix changes to 'os-suspend-server:resume'. Closes-Bug: #1963652 Change-Id: If6386ecdb81fb1f0d88dab447ee81c251b9857b7 (cherry picked from commit 29da801528a357449264e546182bd629f4654275)
* | Fix for "Resize instance" buttonThomas Goirand2022-03-085-22/+103
|/ | | | | | | | | | | | | Currently, "Resize instance" widget is not working because it relies on legacy Nova API v2.46, obsoleted in Pike release. Proposed patch make Horizon use current Nova API (>=2.47). Note: It also cherry-picks a7956cd004 from the master branch which avoids the extra call of flavor_get in resize server form. Closes-Bug: #1940834 Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: Id2f38acfc27cdf93cc4341422873e512aaff716a
* Fix maximum recursion depth error when generating documentation20.1.1Erik Olof Gunnar Andersson2022-01-271-1/+4
| | | | | | | | | | | | | | Troubleshooting an issue with Senlin documentation, > RecursionError: maximum recursion depth exceeded in __instancecheck__ it turns out that attrs['base_options'] creates a recursive reference when no base classes have 'base_options'. This happens when BaseAction is created. Closes-Bug: #1955773 Change-Id: I2724f07339134b3e06b7ea925939bf7072162106 (cherry picked from commit b8cc0043d46318c7e11952109450587bee9567ab)
* Update TOX_CONSTRAINTS_FILE for stable/xenaOpenStack Release Bot2021-09-231-2/+2
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/xena branch, tests will continue to use the upper-constraints list on master. Change-Id: I78fd0ec6b339ea6d2702bc304de7ba35947fedbd
* Update .gitreview for stable/xenaOpenStack Release Bot2021-09-231-0/+1
| | | | Change-Id: If9d89b8abf6320177c029f650ccef3e81bc413ef
* workflow: Do not touch dict during iteration20.1.0Akihiro Motoki2021-09-221-1/+1
| | | | | | | | | | Django 3.2 stored the field information as dict instead OrderedDict because python 3.7+ ensure the field order of dict as the language spec. We cannot touch dict itself during iteration. We need to pass a list instead of a value from .items() itself to avoid the error. Change-Id: Ie22865995d14fa60c16cf2cea582aa0eec46b65d Closes-Bug: #1944548
* Add a release note on Django 3.2 supportAkihiro Motoki2021-09-222-0/+9
| | | | | | | We consider Django 3.2 support as experimental in Xena, but it is worth documenting it. Change-Id: Ibdaed0f4eafd18c61289e70e41584e97d6c60dd7
* Merge "Add horizontal scrollbar to role dropdown"Zuul2021-09-211-0/+2
|\
| * Add horizontal scrollbar to role dropdownTatiana Ovchinnikova2021-09-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | Manage members dialog has a dropdown which lists all the role names. If a role name is long enough, it pushes all the roles to the left and hides them partially. This patch adds horizontal scrollbar for such cases. Closes-Bug: #1926511 Change-Id: I1bbf3b23717f9924974920d6569e018b94e3dbe8
* | Merge "Proper title for Format column"Zuul2021-09-181-3/+5
|\ \
| * | Proper title for Format columnTatiana Ovchinnikova2021-08-201-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | At Launch Instance dialog, Source tab, for boot sources Image and Instance Snapshot there's Format table column. However the title for it is Type, which is confusing since there is a different property Type for an image/instance snapshot. Change-Id: I8f1d3338c58ae4e25bc8437c2a11fd053b2952c1
View Lorry Controller Status